[PATCH] lustre:include:linux:libcfs:libcfs_private.h:fixes the duplicate case value issue.

[PATCH] lustre:include:linux:libcfs:libcfs_private.h:fixes the duplicate case value issue.

[chowdegowda.ms]

From: Chowdegowda <Chowdegowda.MS@smartplayin.com>

In the expession used in switch statement must be a variable not a
constant integer. Expression for case statement must be constant
of same data type that should not be a variable.
---
 drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
index 2817112..0c222c5 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
@@ -408,7 +408,7 @@ int cfs_percpt_atomic_summary(atomic_t **refs);
  *       value  after  conversion...
  *
  */
-#define CLASSERT(cond) do {switch (42) {case (cond): case 0: break; } } while (0)
+#define CLASSERT(cond) do {switch (cond) { case 0: case 1: break;} } while (0)
 
 /* support decl needed both by kernel and liblustre */
 int	 libcfs_isknown_lnd(int type);
-- 
1.9.1

Re: [PATCH] lustre:include:linux:libcfs:libcfs_private.h:fixes the duplicate case value issue.

[Jeremiah Mahler]

On Fri, Jan 30, 2015 at 03:55:49PM +0530, chowdegowda.ms@smartplayin.com wrote:
> From: Chowdegowda <Chowdegowda.MS@smartplayin.com>
> 

There are a lot of problems with this patch.  First, is "Chowdegowda"
your full name that you would use to sign legal documents?

In your Subject line

  Subject: [PATCH] lustre:include:linux:libcfs:libcfs_private.h:fixes the

you are using far too many tags.  The path to the file is not necessary
since this can be deduced from the patch.  In this case I might use
"staging: lustre:".

If you want a crash course in submitting patches I recommend watching
Greg Kroah-Hartman's presentation on how to write and submit your first
Linux kernel patch [1].

  [1]: https://www.youtube.com/watch?v=LLBrBBImJt4

-- 
- Jeremiah Mahler