* [PATCH] ASoC: atmel-pcm-dma: won't check direction when configure dma
@ 2015-02-02 6:44 Bo Shen
2015-02-02 12:19 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Bo Shen @ 2015-02-02 6:44 UTC (permalink / raw)
To: Mark Brown
Cc: nicolas.ferre, Ludovic.Desroches, alsa-devel, linux-sound,
linux-arm-kernel, linux-kernel, Bo Shen
As DMA framework request DMA using direction only in prep_slave
function, (The At91 xdma driver has adapted to this request).
So won't check direction when do DMA configuration.
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
sound/soc/atmel/atmel-pcm-dma.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/sound/soc/atmel/atmel-pcm-dma.c b/sound/soc/atmel/atmel-pcm-dma.c
index 33fb3bb..b8e7bad 100644
--- a/sound/soc/atmel/atmel-pcm-dma.c
+++ b/sound/soc/atmel/atmel-pcm-dma.c
@@ -105,13 +105,11 @@ static int atmel_pcm_configure_dma(struct snd_pcm_substream *substream,
return ret;
}
- if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
- slave_config->dst_addr = ssc->phybase + SSC_THR;
- slave_config->dst_maxburst = 1;
- } else {
- slave_config->src_addr = ssc->phybase + SSC_RHR;
- slave_config->src_maxburst = 1;
- }
+ slave_config->dst_addr = ssc->phybase + SSC_THR;
+ slave_config->dst_maxburst = 1;
+
+ slave_config->src_addr = ssc->phybase + SSC_RHR;
+ slave_config->src_maxburst = 1;
prtd->dma_intr_handler = atmel_pcm_dma_irq;
--
2.3.0.rc0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: atmel-pcm-dma: won't check direction when configure dma
2015-02-02 6:44 [PATCH] ASoC: atmel-pcm-dma: won't check direction when configure dma Bo Shen
@ 2015-02-02 12:19 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-02-02 12:19 UTC (permalink / raw)
To: Bo Shen
Cc: nicolas.ferre, Ludovic.Desroches, alsa-devel, linux-sound,
linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
On Mon, Feb 02, 2015 at 02:44:46PM +0800, Bo Shen wrote:
> As DMA framework request DMA using direction only in prep_slave
> function, (The At91 xdma driver has adapted to this request).
> So won't check direction when do DMA configuration.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-02 12:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-02 6:44 [PATCH] ASoC: atmel-pcm-dma: won't check direction when configure dma Bo Shen
2015-02-02 12:19 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).