* [PATCH] of/fdt: fix sparse warning
@ 2015-02-04 12:04 Lad Prabhakar
2015-02-04 16:01 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Lad Prabhakar @ 2015-02-04 12:04 UTC (permalink / raw)
To: Grant Likely, Rob Herring; +Cc: linux-kernel, Lad, Prabhakar
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
this patch fixes following sparse warning:
fdt.c:765:12: warning: symbol 'early_init_dt_scan_chosen_serial' was not declared. Should it be static?
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
Found this issue on linux-next and applies on top linux-next.
drivers/of/fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 5100742..3a896c9 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -762,7 +762,7 @@ static inline void early_init_dt_check_for_initrd(unsigned long node)
#ifdef CONFIG_SERIAL_EARLYCON
extern struct of_device_id __earlycon_of_table[];
-int __init early_init_dt_scan_chosen_serial(void)
+static int __init early_init_dt_scan_chosen_serial(void)
{
int offset;
const char *p;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] of/fdt: fix sparse warning
2015-02-04 12:04 [PATCH] of/fdt: fix sparse warning Lad Prabhakar
@ 2015-02-04 16:01 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2015-02-04 16:01 UTC (permalink / raw)
To: Lad Prabhakar; +Cc: Grant Likely, Rob Herring, linux-kernel
On Wed, Feb 4, 2015 at 6:04 AM, Lad Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warning:
>
> fdt.c:765:12: warning: symbol 'early_init_dt_scan_chosen_serial' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Applied, thanks.
Rob
> ---
> Found this issue on linux-next and applies on top linux-next.
>
> drivers/of/fdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 5100742..3a896c9 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -762,7 +762,7 @@ static inline void early_init_dt_check_for_initrd(unsigned long node)
> #ifdef CONFIG_SERIAL_EARLYCON
> extern struct of_device_id __earlycon_of_table[];
>
> -int __init early_init_dt_scan_chosen_serial(void)
> +static int __init early_init_dt_scan_chosen_serial(void)
> {
> int offset;
> const char *p;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-04 16:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-04 12:04 [PATCH] of/fdt: fix sparse warning Lad Prabhakar
2015-02-04 16:01 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).