* [PATCH] net: ethernet: ti/cpsw-common.c: fix sparse warning
@ 2015-02-04 12:31 Lad Prabhakar
2015-02-05 8:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Lad Prabhakar @ 2015-02-04 12:31 UTC (permalink / raw)
To: David S. Miller, netdev; +Cc: linux-kernel, Tony Lindgren, Lad, Prabhakar
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
this patch fixes following sparse warning:
cpsw-common.c:23:5: warning: symbol 'cpsw_am33xx_cm_get_macid' was not declared. Should it be static?
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
drivers/net/ethernet/ti/cpsw-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/ti/cpsw-common.c b/drivers/net/ethernet/ti/cpsw-common.c
index 763ada1..f595094 100644
--- a/drivers/net/ethernet/ti/cpsw-common.c
+++ b/drivers/net/ethernet/ti/cpsw-common.c
@@ -17,6 +17,8 @@
#include <linux/regmap.h>
#include <linux/mfd/syscon.h>
+#include "cpsw.h"
+
#define AM33XX_CTRL_MAC_LO_REG(offset, id) ((offset) + 0x8 * (id))
#define AM33XX_CTRL_MAC_HI_REG(offset, id) ((offset) + 0x8 * (id) + 0x4)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: ti/cpsw-common.c: fix sparse warning
2015-02-04 12:31 [PATCH] net: ethernet: ti/cpsw-common.c: fix sparse warning Lad Prabhakar
@ 2015-02-05 8:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-02-05 8:28 UTC (permalink / raw)
To: prabhakar.csengg; +Cc: netdev, linux-kernel, tony
From: Lad Prabhakar <prabhakar.csengg@gmail.com>
Date: Wed, 4 Feb 2015 12:31:28 +0000
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warning:
>
> cpsw-common.c:23:5: warning: symbol 'cpsw_am33xx_cm_get_macid' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-05 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-04 12:31 [PATCH] net: ethernet: ti/cpsw-common.c: fix sparse warning Lad Prabhakar
2015-02-05 8:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).