* [PATCH] samsung-laptop: fix sparse warning
@ 2015-02-05 14:40 Lad Prabhakar
2015-02-07 2:45 ` Darren Hart
0 siblings, 1 reply; 2+ messages in thread
From: Lad Prabhakar @ 2015-02-05 14:40 UTC (permalink / raw)
To: Corentin Chary, Darren Hart, platform-driver-x86
Cc: linux-kernel, Lad, Prabhakar
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
this patch fixes following sparse warning:
samsung-laptop.c:1365:52: warning: Using plain integer as NULL pointer
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
Found this issue on linux-next (gcc version 4.9.2,
sparse version 0.4.5-rc1)and applies on top linux-next.
drivers/platform/x86/samsung-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index ce364a4..c3c31e0 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -1362,7 +1362,7 @@ static int __init samsung_sabi_init(struct samsung_laptop *samsung)
samsung_sabi_diag(samsung);
/* Try to find one of the signatures in memory to find the header */
- for (i = 0; sabi_configs[i].test_string != 0; ++i) {
+ for (i = 0; sabi_configs[i].test_string != NULL; ++i) {
samsung->config = &sabi_configs[i];
loca = find_signature(samsung->f0000_segment,
samsung->config->test_string);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] samsung-laptop: fix sparse warning
2015-02-05 14:40 [PATCH] samsung-laptop: fix sparse warning Lad Prabhakar
@ 2015-02-07 2:45 ` Darren Hart
0 siblings, 0 replies; 2+ messages in thread
From: Darren Hart @ 2015-02-07 2:45 UTC (permalink / raw)
To: Lad Prabhakar; +Cc: Corentin Chary, platform-driver-x86, linux-kernel
On Thu, Feb 05, 2015 at 02:40:05PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warning:
>
> samsung-laptop.c:1365:52: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Queued, thanks.
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-07 2:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-05 14:40 [PATCH] samsung-laptop: fix sparse warning Lad Prabhakar
2015-02-07 2:45 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).