* [PATCH] x86: thinkpad_acpi.c: fix sparse warning
@ 2015-02-05 14:45 Lad Prabhakar
2015-02-05 14:53 ` Henrique de Moraes Holschuh
2015-02-07 3:02 ` Darren Hart
0 siblings, 2 replies; 3+ messages in thread
From: Lad Prabhakar @ 2015-02-05 14:45 UTC (permalink / raw)
To: Henrique de Moraes Holschuh, Darren Hart, ibm-acpi-devel,
platform-driver-x86
Cc: linux-kernel, Lad, Prabhakar
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
this patch fixes following sparse warning:
thinkpad_acpi.c:3459:11: warning: symbol 'adaptive_keyboard_modes' was not declared. Should it be static?
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
Found this issue on linux-next (gcc version 4.9.2,
sparse version 0.4.5-rc1) and applies on top linux-next.
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index c3d11fa..0e9262b 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -3456,7 +3456,7 @@ enum ADAPTIVE_KEY_MODE {
LAYFLAT_MODE
};
-const int adaptive_keyboard_modes[] = {
+static const int adaptive_keyboard_modes[] = {
HOME_MODE,
/* WEB_BROWSER_MODE = 2,
WEB_CONFERENCE_MODE = 3, */
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: thinkpad_acpi.c: fix sparse warning
2015-02-05 14:45 [PATCH] x86: thinkpad_acpi.c: fix sparse warning Lad Prabhakar
@ 2015-02-05 14:53 ` Henrique de Moraes Holschuh
2015-02-07 3:02 ` Darren Hart
1 sibling, 0 replies; 3+ messages in thread
From: Henrique de Moraes Holschuh @ 2015-02-05 14:53 UTC (permalink / raw)
To: Lad Prabhakar, Darren Hart, ibm-acpi-devel, platform-driver-x86
Cc: linux-kernel
On Thu, Feb 5, 2015, at 12:45, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warning:
>
> thinkpad_acpi.c:3459:11: warning: symbol 'adaptive_keyboard_modes' was
> not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> ---
> Found this issue on linux-next (gcc version 4.9.2,
> sparse version 0.4.5-rc1) and applies on top linux-next.
>
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index c3d11fa..0e9262b 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3456,7 +3456,7 @@ enum ADAPTIVE_KEY_MODE {
> LAYFLAT_MODE
> };
>
> -const int adaptive_keyboard_modes[] = {
> +static const int adaptive_keyboard_modes[] = {
> HOME_MODE,
> /* WEB_BROWSER_MODE = 2,
> WEB_CONFERENCE_MODE = 3, */
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: thinkpad_acpi.c: fix sparse warning
2015-02-05 14:45 [PATCH] x86: thinkpad_acpi.c: fix sparse warning Lad Prabhakar
2015-02-05 14:53 ` Henrique de Moraes Holschuh
@ 2015-02-07 3:02 ` Darren Hart
1 sibling, 0 replies; 3+ messages in thread
From: Darren Hart @ 2015-02-07 3:02 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Henrique de Moraes Holschuh, ibm-acpi-devel, platform-driver-x86,
linux-kernel
On Thu, Feb 05, 2015 at 02:45:38PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warning:
Please use the imperative, command form, in the future:
"Fix the following sparse warning:"
For the subject, just the module name is sufficient, no need to preface with
x86:. Always capitalize the first word after the filename:
thinkpad_acpi: Fix sparse warning
Corrected and applied, thanks!
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-07 3:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-05 14:45 [PATCH] x86: thinkpad_acpi.c: fix sparse warning Lad Prabhakar
2015-02-05 14:53 ` Henrique de Moraes Holschuh
2015-02-07 3:02 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).