linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] classmate-laptop: fix sparse warning
@ 2015-02-05 14:57 Lad Prabhakar
  2015-02-06 22:32 ` Thadeu Lima de Souza Cascardo
  2015-02-07 20:12 ` Darren Hart
  0 siblings, 2 replies; 3+ messages in thread
From: Lad Prabhakar @ 2015-02-05 14:57 UTC (permalink / raw)
  To: Thadeu Lima de Souza Cascardo, Daniel Oliveira Nascimento, Darren Hart
  Cc: platform-driver-x86, linux-kernel, Lad, Prabhakar

From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>

this patch fixes following sparse warning:

classmate-laptop.c:523:61: warning: Using plain integer as NULL pointer

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
 Found this issue on linux-next (gcc  version 4.9.2,
 sparse version  0.4.5-rc1) and applies on top linux-next.

 drivers/platform/x86/classmate-laptop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
index 70d355a..55cf10b 100644
--- a/drivers/platform/x86/classmate-laptop.c
+++ b/drivers/platform/x86/classmate-laptop.c
@@ -520,7 +520,7 @@ static acpi_status cmpc_get_accel(acpi_handle handle,
 {
 	union acpi_object param[2];
 	struct acpi_object_list input;
-	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, 0 };
+	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
 	unsigned char *locs;
 	acpi_status status;
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] classmate-laptop: fix sparse warning
  2015-02-05 14:57 [PATCH] classmate-laptop: fix sparse warning Lad Prabhakar
@ 2015-02-06 22:32 ` Thadeu Lima de Souza Cascardo
  2015-02-07 20:12 ` Darren Hart
  1 sibling, 0 replies; 3+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2015-02-06 22:32 UTC (permalink / raw)
  To: Lad Prabhakar
  Cc: Daniel Oliveira Nascimento, Darren Hart, platform-driver-x86,
	linux-kernel

On Thu, Feb 05, 2015 at 02:57:44PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> 
> this patch fixes following sparse warning:
> 
> classmate-laptop.c:523:61: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

> ---
>  Found this issue on linux-next (gcc  version 4.9.2,
>  sparse version  0.4.5-rc1) and applies on top linux-next.
> 
>  drivers/platform/x86/classmate-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index 70d355a..55cf10b 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -520,7 +520,7 @@ static acpi_status cmpc_get_accel(acpi_handle handle,
>  {
>  	union acpi_object param[2];
>  	struct acpi_object_list input;
> -	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, 0 };
> +	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
>  	unsigned char *locs;
>  	acpi_status status;
>  
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] classmate-laptop: fix sparse warning
  2015-02-05 14:57 [PATCH] classmate-laptop: fix sparse warning Lad Prabhakar
  2015-02-06 22:32 ` Thadeu Lima de Souza Cascardo
@ 2015-02-07 20:12 ` Darren Hart
  1 sibling, 0 replies; 3+ messages in thread
From: Darren Hart @ 2015-02-07 20:12 UTC (permalink / raw)
  To: Lad Prabhakar
  Cc: Thadeu Lima de Souza Cascardo, Daniel Oliveira Nascimento,
	platform-driver-x86, linux-kernel

On Thu, Feb 05, 2015 at 02:57:44PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> 
> this patch fixes following sparse warning:
> 
> classmate-laptop.c:523:61: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Queued, thanks Lad.

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-07 20:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-05 14:57 [PATCH] classmate-laptop: fix sparse warning Lad Prabhakar
2015-02-06 22:32 ` Thadeu Lima de Souza Cascardo
2015-02-07 20:12 ` Darren Hart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).