* MIPS: CONFIG_MIPS_R6?
@ 2015-02-14 17:21 Paul Bolle
2015-02-15 1:22 ` Leonid Yegoshin
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2015-02-14 17:21 UTC (permalink / raw)
To: Leonid Yegoshin
Cc: Valentin Rothberg, Markos Chandras, Ralf Baechle, linux-mips,
linux-kernel
Your commits 430857eae56c ("MIPS: mm: Add MIPS R6 instruction
encodings") and 90163242784b ("MIPS: kernel: unaligned: Add support for
the MIPS R6") are included in yesterday's linux-next (ie,
next-20150213). I noticed because a script I use to check linux-next
spotted a problem with it.
These commits added three references to CONFIG_MIPS_R6, were probably
CONFIG_CPU_MIPSR6 was intended. One reference is in a comment, which
should be trivial to get fixed. The other two references are in
(negative) preprocessor checks. It's not certain, at least not to me,
how these should be fixed.
Paul Bolle
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: MIPS: CONFIG_MIPS_R6?
2015-02-14 17:21 MIPS: CONFIG_MIPS_R6? Paul Bolle
@ 2015-02-15 1:22 ` Leonid Yegoshin
2015-02-16 8:39 ` Paul Bolle
0 siblings, 1 reply; 3+ messages in thread
From: Leonid Yegoshin @ 2015-02-15 1:22 UTC (permalink / raw)
To: Paul Bolle
Cc: Valentin Rothberg, Markos Chandras, Ralf Baechle, linux-mips, LKML
On 02/14/2015 09:21 AM, Paul Bolle wrote:
> Your commits 430857eae56c ("MIPS: mm: Add MIPS R6 instruction
> encodings") and 90163242784b ("MIPS: kernel: unaligned: Add support for
> the MIPS R6") are included in yesterday's linux-next (ie,
> next-20150213). I noticed because a script I use to check linux-next
> spotted a problem with it.
>
> These commits added three references to CONFIG_MIPS_R6, were probably
> CONFIG_CPU_MIPSR6 was intended. One reference is in a comment, which
> should be trivial to get fixed. The other two references are in
> (negative) preprocessor checks. It's not certain, at least not to me,
> how these should be fixed.
>
>
> Paul Bolle
Yes, please.
- Leonid.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: MIPS: CONFIG_MIPS_R6?
2015-02-15 1:22 ` Leonid Yegoshin
@ 2015-02-16 8:39 ` Paul Bolle
0 siblings, 0 replies; 3+ messages in thread
From: Paul Bolle @ 2015-02-16 8:39 UTC (permalink / raw)
To: Leonid Yegoshin
Cc: Valentin Rothberg, Markos Chandras, Ralf Baechle, linux-mips, LKML
Leonid,
On Sat, 2015-02-14 at 17:22 -0800, Leonid Yegoshin wrote:
> On 02/14/2015 09:21 AM, Paul Bolle wrote:
> > Your commits 430857eae56c ("MIPS: mm: Add MIPS R6 instruction
> > encodings") and 90163242784b ("MIPS: kernel: unaligned: Add support for
> > the MIPS R6") are included in yesterday's linux-next (ie,
> > next-20150213). I noticed because a script I use to check linux-next
> > spotted a problem with it.
> >
> > These commits added three references to CONFIG_MIPS_R6, were probably
> > CONFIG_CPU_MIPSR6 was intended. One reference is in a comment, which
> > should be trivial to get fixed. The other two references are in
> > (negative) preprocessor checks. It's not certain, at least not to me,
> > how these should be fixed.
> >
> >
> > Paul Bolle
>
> Yes, please.
The obvious fix (ie, three times s/CONFIG_MIPS_R6/CONFIG_CPU_MIPSR6/)
isn't trivial and requires run time testing, which I have no idea how to
do, sorry.
Paul Bolle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-16 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-14 17:21 MIPS: CONFIG_MIPS_R6? Paul Bolle
2015-02-15 1:22 ` Leonid Yegoshin
2015-02-16 8:39 ` Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).