[PATCH v2] dts: vt8500: Add SDHC node to DTS file for WM8650

[PATCH v2] dts: vt8500: Add SDHC node to DTS file for WM8650

[Roman Volkov]

The current kernel contains SDHC driver but not DTS node for it.
Add missing node to make SDHC controller working by default on WM8650.

Signed-off-by: Roman Volkov <v1ron@v1ros.org>
---
 arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/wm8650.dtsi b/arch/arm/boot/dts/wm8650.dtsi
index b1c59a7..5d85ccd 100644
--- a/arch/arm/boot/dts/wm8650.dtsi
+++ b/arch/arm/boot/dts/wm8650.dtsi
@@ -187,6 +187,15 @@
 			interrupts = <43>;
 		};
 
+		sdhc@d800a000 {
+			compatible = "wm,wm8505-sdhc";
+			reg = <0xd800a000 0x400>;
+			interrupts = <20 21>;
+			clocks = <&clksdhc>;
+			bus-width = <4>;
+			sdon-inverted;
+		};
+
 		fb: fb@d8050800 {
 			compatible = "wm,wm8505-fb";
 			reg = <0xd8050800 0x200>;
-- 
2.2.1

[PATCH] dts: vt8500: Add SDHC node to DTS file for WM8650

[Roman Volkov]

There is no DT node for SDHC controller for WM8650, while the driver already
exists. Add missing node to make the controller working by default.

Signed-off-by: Roman Volkov <v1ron@v1ros.org>
Reviewed-by: Alexey Charkov <alchark@gmail.com>
---
 arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/wm8650.dtsi b/arch/arm/boot/dts/wm8650.dtsi
index b1c59a7..5d85ccd 100644
--- a/arch/arm/boot/dts/wm8650.dtsi
+++ b/arch/arm/boot/dts/wm8650.dtsi
@@ -187,6 +187,15 @@
 			interrupts = <43>;
 		};
 
+		sdhc@d800a000 {
+			compatible = "wm,wm8505-sdhc";
+			reg = <0xd800a000 0x400>;
+			interrupts = <20>, <21>;
+			clocks = <&clksdhc>;
+			bus-width = <4>;
+			sdon-inverted;
+		};
+
 		fb: fb@d8050800 {
 			compatible = "wm,wm8505-fb";
 			reg = <0xd8050800 0x200>;
-- 
2.2.2

[PATCH v2 RESEND] dts: vt8500: Add SDHC node to DTS file for WM8650

[Roman Volkov]

There is no DT node for SDHC controller for WM8650, while the driver already
exists. Add missing node to make the controller working by default.

Signed-off-by: Roman Volkov <v1ron@v1ros.org>
Reviewed-by: Alexey Charkov <alchark@gmail.com>
---
 arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/wm8650.dtsi b/arch/arm/boot/dts/wm8650.dtsi
index b1c59a7..e12213d 100644
--- a/arch/arm/boot/dts/wm8650.dtsi
+++ b/arch/arm/boot/dts/wm8650.dtsi
@@ -187,6 +187,15 @@
 			interrupts = <43>;
 		};
 
+		sdhc@d800a000 {
+			compatible = "wm,wm8505-sdhc";
+			reg = <0xd800a000 0x400>;
+			interrupts = <20>, <21>;
+			clocks = <&clksdhc>;
+			bus-width = <4>;
+			sdon-inverted;
+		};
+
 		fb: fb@d8050800 {
 			compatible = "wm,wm8505-fb";
 			reg = <0xd8050800 0x200>;
-- 
2.2.2

[PATCH v3 0/2] WM8505/WM8650 DT fixes for SD card controller

[Roman Volkov]

This patch set enables SD controller support for WM8650 and
fixes minor errors in WM8505 Device Tree file.

Changes in v3:
1. Add minor fixes for WM8505 SDHC node

Tested on both WM8505 and WM8650.

Roman Volkov (2):
  dts: vt8500: Add SDHC node to DTS file for WM8650
  dts: vt8500: Fix errors in SDHC node for WM8505

 arch/arm/boot/dts/wm8505.dtsi | 4 ++--
 arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
 2 files changed, 11 insertions(+), 2 deletions(-)

-- 
Hi maintainers, I see my previous versions were not applied. Could this
little patch set be applied for the linux-next? I don't think this is new
functionality, this must be considered as bugfix for existing Device Tree.

Any other suggestions?

2.3.1

[PATCH v3 1/2] dts: vt8500: Add SDHC node to DTS file for WM8650

[Roman Volkov]

Since WM8650 has the same 'WMT' SDHC controller as WM8505, and the driver
is already in the kernel, this node enables the controller support for
WM8650

Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
Reviewed-by: Alexey Charkov <alchark@gmail.com>
---
 arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/wm8650.dtsi b/arch/arm/boot/dts/wm8650.dtsi
index b1c59a7..e12213d 100644
--- a/arch/arm/boot/dts/wm8650.dtsi
+++ b/arch/arm/boot/dts/wm8650.dtsi
@@ -187,6 +187,15 @@
 			interrupts = <43>;
 		};
 
+		sdhc@d800a000 {
+			compatible = "wm,wm8505-sdhc";
+			reg = <0xd800a000 0x400>;
+			interrupts = <20>, <21>;
+			clocks = <&clksdhc>;
+			bus-width = <4>;
+			sdon-inverted;
+		};
+
 		fb: fb@d8050800 {
 			compatible = "wm,wm8505-fb";
 			reg = <0xd8050800 0x200>;
-- 
2.3.1

[PATCH v3 2/2] dts: vt8500: Fix errors in SDHC node for WM8505

[Roman Volkov]

According to datasheet, the registers space of SDHC controller is 1Kb,
not '0x1000', the correct value should be '0x400'. Bracket interrupt
numbers individually per recommendations.

Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
---
 arch/arm/boot/dts/wm8505.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/wm8505.dtsi b/arch/arm/boot/dts/wm8505.dtsi
index a1a854b..e9ef539 100644
--- a/arch/arm/boot/dts/wm8505.dtsi
+++ b/arch/arm/boot/dts/wm8505.dtsi
@@ -281,8 +281,8 @@
 
 		sdhc@d800a000 {
 			compatible = "wm,wm8505-sdhc";
-			reg = <0xd800a000 0x1000>;
-			interrupts = <20 21>;
+			reg = <0xd800a000 0x400>;
+			interrupts = <20>, <21>;
 			clocks = <&clksdhc>;
 			bus-width = <4>;
 		};
-- 
2.3.1

Re: [PATCH v3 1/2] dts: vt8500: Add SDHC node to DTS file for WM8650

[Sergei Shtylyov]

On 3/1/2015 7:06 PM, Roman Volkov wrote:

> Since WM8650 has the same 'WMT' SDHC controller as WM8505, and the driver
> is already in the kernel, this node enables the controller support for
> WM8650

> Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
> Reviewed-by: Alexey Charkov <alchark@gmail.com>
> ---
>   arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
>   1 file changed, 9 insertions(+)

> diff --git a/arch/arm/boot/dts/wm8650.dtsi b/arch/arm/boot/dts/wm8650.dtsi
> index b1c59a7..e12213d 100644
> --- a/arch/arm/boot/dts/wm8650.dtsi
> +++ b/arch/arm/boot/dts/wm8650.dtsi
> @@ -187,6 +187,15 @@
>   			interrupts = <43>;
>   		};
>
> +		sdhc@d800a000 {

    According to the ePAPR standard, the device nodes should have generic 
names according to their functions, so this node should be named just 
"sd@d800a000".

WBR, Sergei

Re: [PATCH v3 1/2] dts: vt8500: Add SDHC node to DTS file for WM8650

[Roman Volkov]

В Sun, 01 Mar 2015 20:59:13 +0300
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> пишет:

> On 3/1/2015 7:06 PM, Roman Volkov wrote:
> 
> > Since WM8650 has the same 'WMT' SDHC controller as WM8505, and the
> > driver is already in the kernel, this node enables the controller
> > support for WM8650
> 
> > Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
> > Reviewed-by: Alexey Charkov <alchark@gmail.com>
> > ---
> >   arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> 
> > diff --git a/arch/arm/boot/dts/wm8650.dtsi
> > b/arch/arm/boot/dts/wm8650.dtsi index b1c59a7..e12213d 100644
> > --- a/arch/arm/boot/dts/wm8650.dtsi
> > +++ b/arch/arm/boot/dts/wm8650.dtsi
> > @@ -187,6 +187,15 @@
> >   			interrupts = <43>;
> >   		};
> >
> > +		sdhc@d800a000 {
> 
>     According to the ePAPR standard, the device nodes should have
> generic names according to their functions, so this node should be
> named just "sd@d800a000".
> 
> WBR, Sergei
> 

Sergei,

Why not "sdmmc" or "sdhci" or "sdio" then? It would be great to name
nodes in same way, but there is no exact requirement in ePAPR v1.1
regarding SD/MMC controllers. Also, in Linux I don't see that someone
strictly follows this requirement. This renaming will affect driver,
since .compatible strings likely also need changing.

Roman

Re: [PATCH v3 0/2] WM8505/WM8650 DT fixes for SD card controller

[Arnd Bergmann]

On Sunday 01 March 2015 19:06:45 Roman Volkov wrote:
> This patch set enables SD controller support for WM8650 and
> fixes minor errors in WM8505 Device Tree file.
> 
> Changes in v3:
> 1. Add minor fixes for WM8505 SDHC node
> 
> Tested on both WM8505 and WM8650.
> 
> Roman Volkov (2):
>   dts: vt8500: Add SDHC node to DTS file for WM8650
>   dts: vt8500: Fix errors in SDHC node for WM8505
> 
>  arch/arm/boot/dts/wm8505.dtsi | 4 ++--
>  arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> -- 
> Hi maintainers, I see my previous versions were not applied. Could this
> little patch set be applied for the linux-next? I don't think this is new
> functionality, this must be considered as bugfix for existing Device Tree.
> 
> Any other suggestions?

According to the MAINTAINERS file, Tony Prisk should be the person to
pick them up, but he was not the recipient of the mail.

	Arnd

Re: [PATCH v3 0/2] WM8505/WM8650 DT fixes for SD card controller

[Roman Volkov]

В Sun, 01 Mar 2015 20:52:55 +0100
Arnd Bergmann <arnd@arndb.de> пишет:

> On Sunday 01 March 2015 19:06:45 Roman Volkov wrote:
> > This patch set enables SD controller support for WM8650 and
> > fixes minor errors in WM8505 Device Tree file.
> > 
> > Changes in v3:
> > 1. Add minor fixes for WM8505 SDHC node
> > 
> > Tested on both WM8505 and WM8650.
> > 
> > Roman Volkov (2):
> >   dts: vt8500: Add SDHC node to DTS file for WM8650
> >   dts: vt8500: Fix errors in SDHC node for WM8505
> > 
> >  arch/arm/boot/dts/wm8505.dtsi | 4 ++--
> >  arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> > 
> > -- 
> > Hi maintainers, I see my previous versions were not applied. Could
> > this little patch set be applied for the linux-next? I don't think
> > this is new functionality, this must be considered as bugfix for
> > existing Device Tree.
> > 
> > Any other suggestions?
> 
> According to the MAINTAINERS file, Tony Prisk should be the person to
> pick them up, but he was not the recipient of the mail.
> 
> 	Arnd

Thanks for the tip. Tony probably need to add these files to his list
of maintained files. get_maintainer.pl doesn't mention him.

Roman

[PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

[Roman Volkov]

This patch set enables SD controller support for WM8650 and
fixes minor errors in WM8505 Device Tree file.

Changes in v3:
1. Add minor fixes for WM8505 SDHC node

Tested on both WM8505 and WM8650.

Roman Volkov (2):
  dts: vt8500: Add SDHC node to DTS file for WM8650
  dts: vt8500: Fix errors in SDHC node for WM8505

 arch/arm/boot/dts/wm8505.dtsi | 4 ++--
 arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
 2 files changed, 11 insertions(+), 2 deletions(-)

-- 
Hi maintainers, I see my previous versions were not applied. Could this
little patch set be applied for the linux-next? I don't think this is new
functionality, this must be considered as bugfix for existing Device Tree.

Any other suggestions?

2.3.1

[PATCH v3 RESEND 1/2] dts: vt8500: Add SDHC node to DTS file for WM8650

[Roman Volkov]

Since WM8650 has the same 'WMT' SDHC controller as WM8505, and the driver
is already in the kernel, this node enables the controller support for
WM8650

Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
Reviewed-by: Alexey Charkov <alchark@gmail.com>
---
 arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/wm8650.dtsi b/arch/arm/boot/dts/wm8650.dtsi
index b1c59a7..e12213d 100644
--- a/arch/arm/boot/dts/wm8650.dtsi
+++ b/arch/arm/boot/dts/wm8650.dtsi
@@ -187,6 +187,15 @@
 			interrupts = <43>;
 		};
 
+		sdhc@d800a000 {
+			compatible = "wm,wm8505-sdhc";
+			reg = <0xd800a000 0x400>;
+			interrupts = <20>, <21>;
+			clocks = <&clksdhc>;
+			bus-width = <4>;
+			sdon-inverted;
+		};
+
 		fb: fb@d8050800 {
 			compatible = "wm,wm8505-fb";
 			reg = <0xd8050800 0x200>;
-- 
2.3.1

[PATCH v3 RESEND 2/2] dts: vt8500: Fix errors in SDHC node for WM8505

[Roman Volkov]

According to datasheet, the registers space of SDHC controller is 1Kb,
not '0x1000', the correct value should be '0x400'. Bracket interrupt
numbers individually per recommendations.

Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
---
 arch/arm/boot/dts/wm8505.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/wm8505.dtsi b/arch/arm/boot/dts/wm8505.dtsi
index a1a854b..e9ef539 100644
--- a/arch/arm/boot/dts/wm8505.dtsi
+++ b/arch/arm/boot/dts/wm8505.dtsi
@@ -281,8 +281,8 @@
 
 		sdhc@d800a000 {
 			compatible = "wm,wm8505-sdhc";
-			reg = <0xd800a000 0x1000>;
-			interrupts = <20 21>;
+			reg = <0xd800a000 0x400>;
+			interrupts = <20>, <21>;
 			clocks = <&clksdhc>;
 			bus-width = <4>;
 		};
-- 
2.3.1

Re: [PATCH v3 1/2] dts: vt8500: Add SDHC node to DTS file for WM8650

[Sergei Shtylyov]

Hello.

On 03/01/2015 10:49 PM, Roman Volkov wrote:

>>> Since WM8650 has the same 'WMT' SDHC controller as WM8505, and the
>>> driver is already in the kernel, this node enables the controller
>>> support for WM8650

>>> Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
>>> Reviewed-by: Alexey Charkov <alchark@gmail.com>
>>> ---
>>>    arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
>>>    1 file changed, 9 insertions(+)

>>> diff --git a/arch/arm/boot/dts/wm8650.dtsi
>>> b/arch/arm/boot/dts/wm8650.dtsi index b1c59a7..e12213d 100644
>>> --- a/arch/arm/boot/dts/wm8650.dtsi
>>> +++ b/arch/arm/boot/dts/wm8650.dtsi
>>> @@ -187,6 +187,15 @@
>>>    			interrupts = <43>;
>>>    		};
>>>
>>> +		sdhc@d800a000 {

>>      According to the ePAPR standard, the device nodes should have
>> generic names according to their functions, so this node should be
>> named just "sd@d800a000".

>> WBR, Sergei

> Sergei,

> Why not "sdmmc" or "sdhci" or "sdio" then? It would be great to name

    SDHCI is the SD host controller standard, while the names should describe 
"the function of the device and not its precise programming model". SDIO isn't 
the physical interface name, the physical interface underneath is still SD. 
"mmcsd" or "mmc-sd" would be appropriate, however just "mmc" is typically used.

> nodes in same way, but there is no exact requirement in ePAPR v1.1
> regarding SD/MMC controllers.

    Yes, MMC/SD node names are not yet standardized.

> Also, in Linux I don't see that someone
> strictly follows this requirement.

    Because people for the most part are not aware of it, despite 
http://www.devicetree.org/Device_Tree_Usage points to ePAPR and the section 
2.4 of this page also tells to use generic names.

> This renaming will affect driver,
> since .compatible strings likely also need changing.

    Why on earth they'll need change?!

> Roman

WBR, Sergei

Re: [PATCH v3 0/2] WM8505/WM8650 DT fixes for SD card controller

[Roman Volkov]

В Sun, 1 Mar 2015 23:39:11 +0300
Roman Volkov <rvolkov@v1ros.org> пишет:

> В Sun, 01 Mar 2015 20:52:55 +0100
> Arnd Bergmann <arnd@arndb.de> пишет:
> 
> > On Sunday 01 March 2015 19:06:45 Roman Volkov wrote:
> > > This patch set enables SD controller support for WM8650 and
> > > fixes minor errors in WM8505 Device Tree file.
> > > 
> > > Changes in v3:
> > > 1. Add minor fixes for WM8505 SDHC node
> > > 
> > > Tested on both WM8505 and WM8650.
> > > 
> > > Roman Volkov (2):
> > >   dts: vt8500: Add SDHC node to DTS file for WM8650
> > >   dts: vt8500: Fix errors in SDHC node for WM8505
> > > 
> > >  arch/arm/boot/dts/wm8505.dtsi | 4 ++--
> > >  arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
> > >  2 files changed, 11 insertions(+), 2 deletions(-)
> > > 
> > > -- 
> > > Hi maintainers, I see my previous versions were not applied. Could
> > > this little patch set be applied for the linux-next? I don't think
> > > this is new functionality, this must be considered as bugfix for
> > > existing Device Tree.
> > > 
> > > Any other suggestions?
> > 
> > According to the MAINTAINERS file, Tony Prisk should be the person
> > to pick them up, but he was not the recipient of the mail.
> > 
> > 	Arnd
> 
> Thanks for the tip. Tony probably need to add these files to his list
> of maintained files. get_maintainer.pl doesn't mention him.
> 
> Roman

Arnd,

No response yet from Tony for over a month.

Roman

Re: [PATCH v3 0/2] WM8505/WM8650 DT fixes for SD card controller

[Roman Volkov]

В Sat, 4 Apr 2015 15:27:20 +0300
Roman Volkov <v1ron@v1ros.org> пишет:

> В Sun, 1 Mar 2015 23:39:11 +0300
> Roman Volkov <rvolkov@v1ros.org> пишет:
> 
> > В Sun, 01 Mar 2015 20:52:55 +0100
> > Arnd Bergmann <arnd@arndb.de> пишет:
> >   
> > > On Sunday 01 March 2015 19:06:45 Roman Volkov wrote:  
> > > > This patch set enables SD controller support for WM8650 and
> > > > fixes minor errors in WM8505 Device Tree file.
> > > > 
> > > > Changes in v3:
> > > > 1. Add minor fixes for WM8505 SDHC node
> > > > 
> > > > Tested on both WM8505 and WM8650.
> > > > 
> > > > Roman Volkov (2):
> > > >   dts: vt8500: Add SDHC node to DTS file for WM8650
> > > >   dts: vt8500: Fix errors in SDHC node for WM8505
> > > > 
> > > >  arch/arm/boot/dts/wm8505.dtsi | 4 ++--
> > > >  arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
> > > >  2 files changed, 11 insertions(+), 2 deletions(-)
> > > > 
> > > > -- 
> > > > Hi maintainers, I see my previous versions were not applied.
> > > > Could this little patch set be applied for the linux-next? I
> > > > don't think this is new functionality, this must be considered
> > > > as bugfix for existing Device Tree.
> > > > 
> > > > Any other suggestions?  
> > > 
> > > According to the MAINTAINERS file, Tony Prisk should be the person
> > > to pick them up, but he was not the recipient of the mail.
> > > 
> > > 	Arnd  
> > 
> > Thanks for the tip. Tony probably need to add these files to his
> > list of maintained files. get_maintainer.pl doesn't mention him.
> > 
> > Roman  
> 
> Arnd,
> 
> No response yet from Tony for over a month.
> 
> Roman

Ping. At least two patch sets for vt8500 are waiting to be picked up.
vt8500 maintainer is inactive for over a year.

Regards,
Roman

Re: [PATCH v3 0/2] WM8505/WM8650 DT fixes for SD card controller

[Alexey Charkov]

2015-12-24 0:48 GMT+03:00 Roman Volkov <v1ron@mail.ru>:
> В Sat, 4 Apr 2015 15:27:20 +0300
> Roman Volkov <v1ron@v1ros.org> пишет:
>
>> В Sun, 1 Mar 2015 23:39:11 +0300
>> Roman Volkov <rvolkov@v1ros.org> пишет:
>>
>> > В Sun, 01 Mar 2015 20:52:55 +0100
>> > Arnd Bergmann <arnd@arndb.de> пишет:
>> >
>> > > On Sunday 01 March 2015 19:06:45 Roman Volkov wrote:
>> > > > This patch set enables SD controller support for WM8650 and
>> > > > fixes minor errors in WM8505 Device Tree file.
>> > > >
>> > > > Changes in v3:
>> > > > 1. Add minor fixes for WM8505 SDHC node
>> > > >
>> > > > Tested on both WM8505 and WM8650.
>> > > >
>> > > > Roman Volkov (2):
>> > > >   dts: vt8500: Add SDHC node to DTS file for WM8650
>> > > >   dts: vt8500: Fix errors in SDHC node for WM8505
>> > > >
>> > > >  arch/arm/boot/dts/wm8505.dtsi | 4 ++--
>> > > >  arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
>> > > >  2 files changed, 11 insertions(+), 2 deletions(-)
>> > > >
>> > > > --
>> > > > Hi maintainers, I see my previous versions were not applied.
>> > > > Could this little patch set be applied for the linux-next? I
>> > > > don't think this is new functionality, this must be considered
>> > > > as bugfix for existing Device Tree.
>> > > >
>> > > > Any other suggestions?
>> > >
>> > > According to the MAINTAINERS file, Tony Prisk should be the person
>> > > to pick them up, but he was not the recipient of the mail.
>> > >
>> > >   Arnd
>> >
>> > Thanks for the tip. Tony probably need to add these files to his
>> > list of maintained files. get_maintainer.pl doesn't mention him.
>> >
>> > Roman
>>
>> Arnd,
>>
>> No response yet from Tony for over a month.
>>
>> Roman
>
> Ping. At least two patch sets for vt8500 are waiting to be picked up.
> vt8500 maintainer is inactive for over a year.

This series (as available at https://lkml.org/lkml/2015/3/1/172) looks
good to me as far as VT8500 is concerned. Tony is unfortunately
unresponsive lately, but I was the author of vt8500 code pre-DT, and
these changes look all correct.

Rob/Grant, any chance you could push these via the OF tree?

Best regards,
Alexey

Re: [PATCH v3 0/2] WM8505/WM8650 DT fixes for SD card controller

[Arnd Bergmann]

On Thursday 24 December 2015 00:48:25 Roman Volkov wrote:
> В Sat, 4 Apr 2015 15:27:20 +0300
> Roman Volkov <v1ron@v1ros.org> пишет:
> 
> > В Sun, 1 Mar 2015 23:39:11 +0300
> > Roman Volkov <rvolkov@v1ros.org> пишет:
> > 
> > > В Sun, 01 Mar 2015 20:52:55 +0100
> > > Arnd Bergmann <arnd@arndb.de> пишет:
> > > > > Any other suggestions?  
> > > > 
> > > > According to the MAINTAINERS file, Tony Prisk should be the person
> > > > to pick them up, but he was not the recipient of the mail.
> > > > 
> > > >   Arnd  
> > > 
> > > Thanks for the tip. Tony probably need to add these files to his
> > > list of maintained files. get_maintainer.pl doesn't mention him.
> > > 
> > > Roman  
> > 
> > Arnd,
> > 
> > No response yet from Tony for over a month.
> > 
> > Roman
> 
> Ping. At least two patch sets for vt8500 are waiting to be picked up.
> vt8500 maintainer is inactive for over a year.

I seem to have lost the original mails now, as it's been a while. Can you
send the entire series of patches to arm@kernel.org please?

	Arnd

Re: [PATCH v3 0/2] WM8505/WM8650 DT fixes for SD card controller

[Arnd Bergmann]

On Thursday 31 December 2015 16:31:02 Arnd Bergmann wrote:
> On Thursday 24 December 2015 00:48:25 Roman Volkov wrote:
> > В Sat, 4 Apr 2015 15:27:20 +0300
> > Roman Volkov <v1ron@v1ros.org> пишет:
> > 
> > > В Sun, 1 Mar 2015 23:39:11 +0300
> > > Roman Volkov <rvolkov@v1ros.org> пишет:
> > > 
> > > > В Sun, 01 Mar 2015 20:52:55 +0100
> > > > Arnd Bergmann <arnd@arndb.de> пишет:
> > > > > > Any other suggestions?  
> > > > > 
> > > > > According to the MAINTAINERS file, Tony Prisk should be the person
> > > > > to pick them up, but he was not the recipient of the mail.
> > > > > 
> > > > >   Arnd  
> > > > 
> > > > Thanks for the tip. Tony probably need to add these files to his
> > > > list of maintained files. get_maintainer.pl doesn't mention him.
> > > > 
> > > > Roman  
> > > 
> > > Arnd,
> > > 
> > > No response yet from Tony for over a month.
> > > 
> > > Roman
> > 
> > Ping. At least two patch sets for vt8500 are waiting to be picked up.
> > vt8500 maintainer is inactive for over a year.
> 
> I seem to have lost the original mails now, as it's been a while. Can you
> send the entire series of patches to arm@kernel.org please?

To clarify, please first make sure they still apply cleanly on a recent
kernel, then send them to arm@kernel.org with all the involved parties
and the mailing list(s) in Cc.

	Arnd

Re: [PATCH v3 0/2] WM8505/WM8650 DT fixes for SD card controller

[Roman Volkov]

В Thu, 31 Dec 2015 16:32:59 +0100
Arnd Bergmann <arnd@arndb.de> пишет:

> On Thursday 31 December 2015 16:31:02 Arnd Bergmann wrote:
> > On Thursday 24 December 2015 00:48:25 Roman Volkov wrote:  
> > > В Sat, 4 Apr 2015 15:27:20 +0300
> > > Roman Volkov <v1ron@v1ros.org> пишет:
> > >   
> > > > В Sun, 1 Mar 2015 23:39:11 +0300
> > > > Roman Volkov <rvolkov@v1ros.org> пишет:
> > > >   
> > > > > В Sun, 01 Mar 2015 20:52:55 +0100
> > > > > Arnd Bergmann <arnd@arndb.de> пишет:  
> > > > > > > Any other suggestions?    
> > > > > > 
> > > > > > According to the MAINTAINERS file, Tony Prisk should be the
> > > > > > person to pick them up, but he was not the recipient of the
> > > > > > mail.
> > > > > > 
> > > > > >   Arnd    
> > > > > 
> > > > > Thanks for the tip. Tony probably need to add these files to
> > > > > his list of maintained files. get_maintainer.pl doesn't
> > > > > mention him.
> > > > > 
> > > > > Roman    
> > > > 
> > > > Arnd,
> > > > 
> > > > No response yet from Tony for over a month.
> > > > 
> > > > Roman  
> > > 
> > > Ping. At least two patch sets for vt8500 are waiting to be picked
> > > up. vt8500 maintainer is inactive for over a year.  
> > 
> > I seem to have lost the original mails now, as it's been a while.
> > Can you send the entire series of patches to arm@kernel.org
> > please?  
> 
> To clarify, please first make sure they still apply cleanly on a
> recent kernel, then send them to arm@kernel.org with all the involved
> parties and the mailing list(s) in Cc.
> 

Arnd,
These series are still applicable (for next-20151231). I resent both
SDHC and clocksource series, and got my emails returned with:

> <linux+armsoc@arm.linux.org.uk> (expanded from <arm@kernel.org>): host
>    mx0.arm.linux.org.uk[78.32.30.218] said: 550-We do not accept
> v1ron@mail.ru from mail.kernel.org - please use mail.ru's 550 mail
> servers (in reply to RCPT TO command)

Please confirm what you received and let me know if I must resend again.

Happy New Year,
Roman

Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

[Roman Volkov]

В Fri, 01 Jan 2016 22:53:33 +0100
Arnd Bergmann <arnd@arndb.de> пишет:

> On Friday 01 January 2016 20:32:30 Roman Volkov wrote:
> > > Applied both to next/dt, thanks a lot for following up!
> > > 
> > > Let me know if you think this should go into stable backports as
> > > well, I did not apply it to the fixes branch as you don't have a
> > > 'Cc: stable@vger.kernel.org' tag and it has never worked so far.  
> > 
> > Yes, this must go into the stable too. Let me know if I must change
> > something or resend.  
> 
> I can put them in the fixes branch with the appropriate stable
> tag myself, but please clarify whether we need just the first or
> both patches there. It looks to me that the second one while
> correct only addresses a cosmetic problem and everything works
> without it.

Correct, everything works without the second one. One of reviewers
noticed that addresses are different between WM8505 and WM8650 where
the hardware is the same. If such trivial changes are not accepted,
please do not apply.

Happy New Year,
Roman

Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

[Arnd Bergmann]

On Friday 01 January 2016 20:32:30 Roman Volkov wrote:
> > Applied both to next/dt, thanks a lot for following up!
> > 
> > Let me know if you think this should go into stable backports as well,
> > I did not apply it to the fixes branch as you don't have a
> > 'Cc: stable@vger.kernel.org' tag and it has never worked so far.
> 
> Yes, this must go into the stable too. Let me know if I must change
> something or resend.

I can put them in the fixes branch with the appropriate stable
tag myself, but please clarify whether we need just the first or
both patches there. It looks to me that the second one while
correct only addresses a cosmetic problem and everything works
without it.

	Arnd

Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

[Roman Volkov]

В Fri, 01 Jan 2016 15:29:29 +0100
Arnd Bergmann <arnd@arndb.de> пишет:

> On Friday 01 January 2016 16:38:10 Roman Volkov wrote:
> > From: Roman Volkov <rvolkov@v1ros.org>
> > 
> > This patch set enables SD controller support for WM8650 and
> > fixes minor errors in WM8505 Device Tree file.
> > 
> > Changes in v3:
> > 1. Add minor fixes for WM8505 SDHC node
> > 
> > Tested on both WM8505 and WM8650.
> > 
> > Roman Volkov (2):
> >   dts: vt8500: Add SDHC node to DTS file for WM8650
> >   dts: vt8500: Fix errors in SDHC node for WM8505
> > 
> >  arch/arm/boot/dts/wm8505.dtsi | 4 ++--
> >  arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> > 
> > -- 
> > Hi maintainers, I see my previous versions were not applied. Could
> > this little patch set be applied for the linux-next? I don't think
> > this is new functionality, this must be considered as bugfix for
> > existing Device Tree.
> > 
> > Any other suggestions?
> >   
> 
> Applied both to next/dt, thanks a lot for following up!
> 
> Let me know if you think this should go into stable backports as well,
> I did not apply it to the fixes branch as you don't have a
> 'Cc: stable@vger.kernel.org' tag and it has never worked so far.

Yes, this must go into the stable too. Let me know if I must change
something or resend.

Thanks,
Roman

Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

[Arnd Bergmann]

On Friday 01 January 2016 16:38:10 Roman Volkov wrote:
> From: Roman Volkov <rvolkov@v1ros.org>
> 
> This patch set enables SD controller support for WM8650 and
> fixes minor errors in WM8505 Device Tree file.
> 
> Changes in v3:
> 1. Add minor fixes for WM8505 SDHC node
> 
> Tested on both WM8505 and WM8650.
> 
> Roman Volkov (2):
>   dts: vt8500: Add SDHC node to DTS file for WM8650
>   dts: vt8500: Fix errors in SDHC node for WM8505
> 
>  arch/arm/boot/dts/wm8505.dtsi | 4 ++--
>  arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> -- 
> Hi maintainers, I see my previous versions were not applied. Could this
> little patch set be applied for the linux-next? I don't think this is new
> functionality, this must be considered as bugfix for existing Device Tree.
> 
> Any other suggestions?
> 

Applied both to next/dt, thanks a lot for following up!

Let me know if you think this should go into stable backports as well,
I did not apply it to the fixes branch as you don't have a
'Cc: stable@vger.kernel.org' tag and it has never worked so far.

	Arnd

[PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

[Roman Volkov]

From: Roman Volkov <rvolkov@v1ros.org>

This patch set enables SD controller support for WM8650 and
fixes minor errors in WM8505 Device Tree file.

Changes in v3:
1. Add minor fixes for WM8505 SDHC node

Tested on both WM8505 and WM8650.

Roman Volkov (2):
  dts: vt8500: Add SDHC node to DTS file for WM8650
  dts: vt8500: Fix errors in SDHC node for WM8505

 arch/arm/boot/dts/wm8505.dtsi | 4 ++--
 arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
 2 files changed, 11 insertions(+), 2 deletions(-)

-- 
Hi maintainers, I see my previous versions were not applied. Could this
little patch set be applied for the linux-next? I don't think this is new
functionality, this must be considered as bugfix for existing Device Tree.

Any other suggestions?

2.3.1

[PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

[Roman Volkov]

From: Roman Volkov <rvolkov@v1ros.org>

This patch set enables SD controller support for WM8650 and
fixes minor errors in WM8505 Device Tree file.

Changes in v3:
1. Add minor fixes for WM8505 SDHC node

Tested on both WM8505 and WM8650.

Roman Volkov (2):
  dts: vt8500: Add SDHC node to DTS file for WM8650
  dts: vt8500: Fix errors in SDHC node for WM8505

 arch/arm/boot/dts/wm8505.dtsi | 4 ++--
 arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
 2 files changed, 11 insertions(+), 2 deletions(-)

-- 
Hi maintainers, I see my previous versions were not applied. Could this
little patch set be applied for the linux-next? I don't think this is new
functionality, this must be considered as bugfix for existing Device Tree.

Any other suggestions?

2.3.1