* [PATCH] phy: samsung-usb2: Remove NULL terminating entry from phys array
@ 2015-03-03 1:08 Axel Lin
2015-03-04 14:47 ` Kamil Debski
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-03-03 1:08 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Kamil Debski, Kukjin Kim, linux-kernel, linux-samsung-soc
Current code uses num_phys settings to tell the number of entries in phys.
Thus remove the NULL terminating entry from phys array which is not necessary.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/phy/phy-exynos4210-usb2.c | 1 -
drivers/phy/phy-exynos4x12-usb2.c | 1 -
drivers/phy/phy-exynos5250-usb2.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/phy/phy-exynos4210-usb2.c b/drivers/phy/phy-exynos4210-usb2.c
index 236a52a..f30bbb0 100644
--- a/drivers/phy/phy-exynos4210-usb2.c
+++ b/drivers/phy/phy-exynos4210-usb2.c
@@ -250,7 +250,6 @@ static const struct samsung_usb2_common_phy exynos4210_phys[] = {
.power_on = exynos4210_power_on,
.power_off = exynos4210_power_off,
},
- {},
};
const struct samsung_usb2_phy_config exynos4210_usb2_phy_config = {
diff --git a/drivers/phy/phy-exynos4x12-usb2.c b/drivers/phy/phy-exynos4x12-usb2.c
index 0b9de88..765da90 100644
--- a/drivers/phy/phy-exynos4x12-usb2.c
+++ b/drivers/phy/phy-exynos4x12-usb2.c
@@ -361,7 +361,6 @@ static const struct samsung_usb2_common_phy exynos4x12_phys[] = {
.power_on = exynos4x12_power_on,
.power_off = exynos4x12_power_off,
},
- {},
};
const struct samsung_usb2_phy_config exynos3250_usb2_phy_config = {
diff --git a/drivers/phy/phy-exynos5250-usb2.c b/drivers/phy/phy-exynos5250-usb2.c
index 1c139aa..2ed1735 100644
--- a/drivers/phy/phy-exynos5250-usb2.c
+++ b/drivers/phy/phy-exynos5250-usb2.c
@@ -391,7 +391,6 @@ static const struct samsung_usb2_common_phy exynos5250_phys[] = {
.power_on = exynos5250_power_on,
.power_off = exynos5250_power_off,
},
- {},
};
const struct samsung_usb2_phy_config exynos5250_usb2_phy_config = {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] phy: samsung-usb2: Remove NULL terminating entry from phys array
2015-03-03 1:08 [PATCH] phy: samsung-usb2: Remove NULL terminating entry from phys array Axel Lin
@ 2015-03-04 14:47 ` Kamil Debski
0 siblings, 0 replies; 2+ messages in thread
From: Kamil Debski @ 2015-03-04 14:47 UTC (permalink / raw)
To: 'Axel Lin', 'Kishon Vijay Abraham I'
Cc: 'Kukjin Kim', linux-kernel, linux-samsung-soc
From: Axel Lin [mailto:axel.lin@ingics.com]
Sent: Tuesday, March 03, 2015 2:09 AM
>
> Current code uses num_phys settings to tell the number of entries in
> phys.
> Thus remove the NULL terminating entry from phys array which is not
> necessary.
The patch looks good.
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Kamil Debski <k.debski@samsung.com>
Best wishes,
--
Kamil Debski
Samsung R&D Institute Poland
> ---
> drivers/phy/phy-exynos4210-usb2.c | 1 - drivers/phy/phy-exynos4x12-
> usb2.c | 1 - drivers/phy/phy-exynos5250-usb2.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/phy/phy-exynos4210-usb2.c b/drivers/phy/phy-
> exynos4210-usb2.c
> index 236a52a..f30bbb0 100644
> --- a/drivers/phy/phy-exynos4210-usb2.c
> +++ b/drivers/phy/phy-exynos4210-usb2.c
> @@ -250,7 +250,6 @@ static const struct samsung_usb2_common_phy
> exynos4210_phys[] = {
> .power_on = exynos4210_power_on,
> .power_off = exynos4210_power_off,
> },
> - {},
> };
>
> const struct samsung_usb2_phy_config exynos4210_usb2_phy_config = {
> diff --git a/drivers/phy/phy-exynos4x12-usb2.c b/drivers/phy/phy-
> exynos4x12-usb2.c
> index 0b9de88..765da90 100644
> --- a/drivers/phy/phy-exynos4x12-usb2.c
> +++ b/drivers/phy/phy-exynos4x12-usb2.c
> @@ -361,7 +361,6 @@ static const struct samsung_usb2_common_phy
> exynos4x12_phys[] = {
> .power_on = exynos4x12_power_on,
> .power_off = exynos4x12_power_off,
> },
> - {},
> };
>
> const struct samsung_usb2_phy_config exynos3250_usb2_phy_config = {
> diff --git a/drivers/phy/phy-exynos5250-usb2.c b/drivers/phy/phy-
> exynos5250-usb2.c
> index 1c139aa..2ed1735 100644
> --- a/drivers/phy/phy-exynos5250-usb2.c
> +++ b/drivers/phy/phy-exynos5250-usb2.c
> @@ -391,7 +391,6 @@ static const struct samsung_usb2_common_phy
> exynos5250_phys[] = {
> .power_on = exynos5250_power_on,
> .power_off = exynos5250_power_off,
> },
> - {},
> };
>
> const struct samsung_usb2_phy_config exynos5250_usb2_phy_config = {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-04 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-03 1:08 [PATCH] phy: samsung-usb2: Remove NULL terminating entry from phys array Axel Lin
2015-03-04 14:47 ` Kamil Debski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).