* [PATCH] Staging: dgnc: fix bitmask
@ 2015-03-09 20:14 Matteo Semenzato
2015-03-10 6:51 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Matteo Semenzato @ 2015-03-09 20:14 UTC (permalink / raw)
To: gregkh, lidza.louina, markh; +Cc: devel, linux-kernel, Matteo Semenzato
From: Matteo Semenzato <mattew8898@gmail.com>
The bitmask should be used on msignals since the signals variable is not
used anywhere in the function.
Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
---
drivers/staging/dgnc/dgnc_cls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index bedc522..29c6316 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -1137,7 +1137,7 @@ static void cls_parse_modem(struct channel_t *ch, unsigned char signals)
* Scrub off lower bits. They signify delta's, which I don't
* care about
*/
- signals &= 0xf0;
+ msignals &= 0xf0;
spin_lock_irqsave(&ch->ch_lock, flags);
if (msignals & UART_MSR_DCD)
--
2.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: dgnc: fix bitmask
2015-03-09 20:14 [PATCH] Staging: dgnc: fix bitmask Matteo Semenzato
@ 2015-03-10 6:51 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-03-10 6:51 UTC (permalink / raw)
To: markh; +Cc: Matteo Semenzato, gregkh, lidza.louina, devel, linux-kernel
On Mon, Mar 09, 2015 at 09:14:38PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@gmail.com>
>
> The bitmask should be used on msignals since the signals variable is not
> used anywhere in the function.
>
You're probably right. I would really like to get Mark's Ack on this
though becuase it's sort of a guess and not tested.
regards,
dan carpenter
> Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_cls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index bedc522..29c6316 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1137,7 +1137,7 @@ static void cls_parse_modem(struct channel_t *ch, unsigned char signals)
> * Scrub off lower bits. They signify delta's, which I don't
> * care about
> */
> - signals &= 0xf0;
> + msignals &= 0xf0;
>
> spin_lock_irqsave(&ch->ch_lock, flags);
> if (msignals & UART_MSR_DCD)
> --
> 2.3.1
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-10 6:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-09 20:14 [PATCH] Staging: dgnc: fix bitmask Matteo Semenzato
2015-03-10 6:51 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).