* [PATCH] perf/builtin-diff: remove unnecessary error output
@ 2015-03-13 18:19 Alexander Kuleshov
0 siblings, 0 replies; only message in thread
From: Alexander Kuleshov @ 2015-03-13 18:19 UTC (permalink / raw)
To: Peter Zijlstra, Paul Mackerras, Ingo Molnar, linux-kernel
Cc: Alexander Kuleshov
This patch prevents duplicated error output. per_session__new function calls
perf_data_file__open which will print error message if it can not open the file
and we will get duplicated output of the error message:
failed to open perf.data.old: No such file or directory
Failed to open perf.data.old
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
tools/perf/builtin-diff.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 74aada5..a18bf98 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -742,7 +742,6 @@ static int __cmd_diff(void)
data__for_each_file(i, d) {
d->session = perf_session__new(&d->file, false, &tool);
if (!d->session) {
- pr_err("Failed to open %s\n", d->file.path);
ret = -1;
goto out_delete;
}
--
2.3.1.291.g7a9409c
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-03-13 18:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-13 18:19 [PATCH] perf/builtin-diff: remove unnecessary error output Alexander Kuleshov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).