[PATCH 0/1] ARM: dts: rockchip: disable gmac by default in rk3288.dtsi

[PATCH 0/1] ARM: dts: rockchip: disable gmac by default in rk3288.dtsi

[Alexandru M Stan]

The way it is right now, each board using rk3288.dtsi has to disable
it or else (given CONFIG_DWMAC_RK is set) it will try loading the driver
and looking for phy's even though none are connected.

The status should be "disabled".

PS: I'm ok with "the big relicensing"
(http://www.spinics.net/lists/arm-kernel/msg403629.html) to GPLv2/X11.


Alexandru M Stan (1):
  ARM: dts: rockchip: disable gmac by default in rk3288.dtsi

 arch/arm/boot/dts/rk3288.dtsi | 1 +
 1 file changed, 1 insertion(+)

-- 
2.2.0.rc0.207.ga3a616c

[PATCH] ARM: dts: rockchip: disable gmac by default in rk3288.dtsi

[Alexandru M Stan]

This block should not be enabled by default or else if the kconfig is set,
it will try to load/probe even if there's no phy connected.

Signed-off-by: Alexandru M Stan <amstan@chromium.org>
---
 arch/arm/boot/dts/rk3288.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index d771f68..eccc78d 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -411,6 +411,7 @@
 			"mac_clk_rx", "mac_clk_tx",
 			"clk_mac_ref", "clk_mac_refout",
 			"aclk_mac", "pclk_mac";
+		status = "disabled";
 	};
 
 	usb_host0_ehci: usb@ff500000 {
-- 
2.2.0.rc0.207.ga3a616c

Re: [PATCH] ARM: dts: rockchip: disable gmac by default in rk3288.dtsi

[Heiko Stuebner]

Am Freitag, 13. März 2015, 17:55:32 schrieb Alexandru M Stan:
> This block should not be enabled by default or else if the kconfig is set,
> it will try to load/probe even if there's no phy connected.
> 
> Signed-off-by: Alexandru M Stan <amstan@chromium.org>

applied to my fixes branch


Thanks
Heiko

> ---
>  arch/arm/boot/dts/rk3288.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index d771f68..eccc78d 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -411,6 +411,7 @@
>  			"mac_clk_rx", "mac_clk_tx",
>  			"clk_mac_ref", "clk_mac_refout",
>  			"aclk_mac", "pclk_mac";
> +		status = "disabled";
>  	};
> 
>  	usb_host0_ehci: usb@ff500000 {