* [PATCH RFC] remove pointless early_printk call in x86/kernel/head64.c
@ 2015-03-17 12:59 Alexander Kuleshov
2015-03-17 13:00 ` [PATCH] x86/head64.c: remove pointless early_printk call Alexander Kuleshov
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kuleshov @ 2015-03-17 12:59 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Andrew Morton,
Borislav Petkov
Cc: linux-kernel
There is the call of the early_printk function in the x86/kernel/head64.c, but
if i understand correctly early_printk initialized by setup_early_printk
which is early_param, but early_param initialized only in the init/main.c in
the do_early_param function. So early_printk from the x86/kernel/head64.c
will not print anything in any case.
Alexander Kuleshov (1):
x86/head64.c: remove pointless early_printk call
arch/x86/kernel/head64.c | 3 ---
1 file changed, 3 deletions(-)
--
2.3.3.472.g20ceeac.dirty
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] x86/head64.c: remove pointless early_printk call
2015-03-17 12:59 [PATCH RFC] remove pointless early_printk call in x86/kernel/head64.c Alexander Kuleshov
@ 2015-03-17 13:00 ` Alexander Kuleshov
2015-03-17 13:09 ` [tip:x86/boot] x86/boot/64: Remove pointless early_printk() message tip-bot for Alexander Kuleshov
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kuleshov @ 2015-03-17 13:00 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Andrew Morton,
Borislav Petkov
Cc: linux-kernel, Alexander Kuleshov
earlyprintk not initialised yet by the setup_early_printk
so we can remove it.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
arch/x86/kernel/head64.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
index c4f8d46..2b55ee6 100644
--- a/arch/x86/kernel/head64.c
+++ b/arch/x86/kernel/head64.c
@@ -177,9 +177,6 @@ asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data)
*/
load_ucode_bsp();
- if (console_loglevel >= CONSOLE_LOGLEVEL_DEBUG)
- early_printk("Kernel alive\n");
-
clear_page(init_level4_pgt);
/* set init_level4_pgt kernel high mapping*/
init_level4_pgt[511] = early_level4_pgt[511];
--
2.3.3.472.g20ceeac.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:x86/boot] x86/boot/64: Remove pointless early_printk() message
2015-03-17 13:00 ` [PATCH] x86/head64.c: remove pointless early_printk call Alexander Kuleshov
@ 2015-03-17 13:09 ` tip-bot for Alexander Kuleshov
0 siblings, 0 replies; 3+ messages in thread
From: tip-bot for Alexander Kuleshov @ 2015-03-17 13:09 UTC (permalink / raw)
To: linux-tip-commits; +Cc: kuleshovmail, bp, tglx, mingo, hpa, linux-kernel
Commit-ID: 91d8f0416f3989e248d3a3d3efb821eda10a85d2
Gitweb: http://git.kernel.org/tip/91d8f0416f3989e248d3a3d3efb821eda10a85d2
Author: Alexander Kuleshov <kuleshovmail@gmail.com>
AuthorDate: Tue, 17 Mar 2015 19:00:05 +0600
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 17 Mar 2015 14:03:04 +0100
x86/boot/64: Remove pointless early_printk() message
earlyprintk is not initialised yet by the setup_early_printk() function
so we can remove it.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Borislav Petkov <bp@suse.de>
Link: http://lkml.kernel.org/r/1426597205-5142-1-git-send-email-kuleshovmail@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/head64.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
index eda1a86..8c58135 100644
--- a/arch/x86/kernel/head64.c
+++ b/arch/x86/kernel/head64.c
@@ -172,9 +172,6 @@ asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data)
*/
load_ucode_bsp();
- if (console_loglevel >= CONSOLE_LOGLEVEL_DEBUG)
- early_printk("Kernel alive\n");
-
clear_page(init_level4_pgt);
/* set init_level4_pgt kernel high mapping*/
init_level4_pgt[511] = early_level4_pgt[511];
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-17 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-17 12:59 [PATCH RFC] remove pointless early_printk call in x86/kernel/head64.c Alexander Kuleshov
2015-03-17 13:00 ` [PATCH] x86/head64.c: remove pointless early_printk call Alexander Kuleshov
2015-03-17 13:09 ` [tip:x86/boot] x86/boot/64: Remove pointless early_printk() message tip-bot for Alexander Kuleshov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).