* [PATCH v2 1/2] phy: spear1310-miphy: Return proper error for spear1310_miphy_xlate
@ 2015-04-01 0:44 Axel Lin
2015-04-01 0:45 ` [PATCH v2 2/2] phy: spear1340-miphy: Return proper error for spear1340_miphy_xlate Axel Lin
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-04-01 0:44 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: Peter Griffin, linux-kernel
The of_xlate callback should return ERR_PTR on error.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
v2: Return -ENODEV instead of -EINVAL so that phy_optional_get() doesn't fail.
drivers/phy/phy-spear1310-miphy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c
index 9f47fae..4684b04 100644
--- a/drivers/phy/phy-spear1310-miphy.c
+++ b/drivers/phy/phy-spear1310-miphy.c
@@ -192,14 +192,14 @@ static struct phy *spear1310_miphy_xlate(struct device *dev,
if (args->args_count < 1) {
dev_err(dev, "DT did not pass correct no of args\n");
- return NULL;
+ return ERR_PTR(-ENODEV);
}
priv->mode = args->args[0];
if (priv->mode != SATA && priv->mode != PCIE) {
dev_err(dev, "DT did not pass correct phy mode\n");
- return NULL;
+ return ERR_PTR(-ENODEV);
}
return priv->phy;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2 2/2] phy: spear1340-miphy: Return proper error for spear1340_miphy_xlate
2015-04-01 0:44 [PATCH v2 1/2] phy: spear1310-miphy: Return proper error for spear1310_miphy_xlate Axel Lin
@ 2015-04-01 0:45 ` Axel Lin
0 siblings, 0 replies; 2+ messages in thread
From: Axel Lin @ 2015-04-01 0:45 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: Peter Griffin, linux-kernel
The of_xlate callback should return ERR_PTR on error.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
v2: Return -ENODEV instead of -EINVAL so that phy_optional_get() doesn't fail.
drivers/phy/phy-spear1340-miphy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-spear1340-miphy.c b/drivers/phy/phy-spear1340-miphy.c
index e42bc20..210979b 100644
--- a/drivers/phy/phy-spear1340-miphy.c
+++ b/drivers/phy/phy-spear1340-miphy.c
@@ -229,14 +229,14 @@ static struct phy *spear1340_miphy_xlate(struct device *dev,
if (args->args_count < 1) {
dev_err(dev, "DT did not pass correct no of args\n");
- return NULL;
+ return ERR_PTR(-ENODEV);
}
priv->mode = args->args[0];
if (priv->mode != SATA && priv->mode != PCIE) {
dev_err(dev, "DT did not pass correct phy mode\n");
- return NULL;
+ return ERR_PTR(-ENODEV);
}
return priv->phy;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-01 0:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-01 0:44 [PATCH v2 1/2] phy: spear1310-miphy: Return proper error for spear1310_miphy_xlate Axel Lin
2015-04-01 0:45 ` [PATCH v2 2/2] phy: spear1340-miphy: Return proper error for spear1340_miphy_xlate Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).