From: Michael Ellerman <mpe@ellerman.id.au>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [RFC/RFT, RESEND] powerpc: move cacheinfo sysfs to generic cacheinfo infrastructure
Date: Wed, 01 Apr 2015 15:40:42 +1100 [thread overview]
Message-ID: <1427863242.4256.10.camel@ellerman.id.au> (raw)
In-Reply-To: <551AD5E4.2040103@arm.com>
On Tue, 2015-03-31 at 18:14 +0100, Sudeep Holla wrote:
>
> On 31/03/15 11:56, Michael Ellerman wrote:
> > On Mon, 2015-23-02 at 18:18:20 UTC, Sudeep Holla wrote:
> >> This patch removes the redundant sysfs cacheinfo code by reusing
> >> the newly introduced generic cacheinfo infrastructure through the
> >> commit 246246cbde5e ("drivers: base: support cpu cache information
> >> interface to userspace via sysfs")
>
> > Removing the include doesn't fix it, it needs cacheinfo_cpu_on/offline().
> >
>
> I agree, had a quick look at that, and it requires some rework not sure
> if that should be in generic code or ppc specific.
Yeah OK.
Also if I just remove the references from the suspend code, it still causes
changes to the result, some of which look wrong:
--- cpu0.before 2015-04-01 15:34:58.985470973 +1100
+++ cpu0.after-no-power 2015-04-01 15:36:31.313435304 +1100
@@ -3,22 +3,24 @@
./cpu0/cache/index0/level:1
./cpu0/cache/index0/number_of_sets:8
./cpu0/cache/index0/shared_cpu_map:0000,000000ff
+./cpu0/cache/index0/shared_cpu_list:0-7 <- additional, OK
./cpu0/cache/index0/coherency_line_size:128
./cpu0/cache/index0/ways_of_associativity:64
-./cpu0/cache/index1/size:32K <- we lost the size of the Icache?
./cpu0/cache/index1/type:Instruction
./cpu0/cache/index1/level:1
-./cpu0/cache/index1/number_of_sets:4 }-.
-./cpu0/cache/index1/shared_cpu_map:0000,000000ff .
-./cpu0/cache/index1/coherency_line_size:128 . These changes are no good
-./cpu0/cache/index1/ways_of_associativity:64 .
+./cpu0/cache/index1/shared_cpu_map:ffff,ffffffff .
+./cpu0/cache/index1/shared_cpu_list:0-47 }-
./cpu0/cache/index2/size:512K
./cpu0/cache/index2/type:Unified
./cpu0/cache/index2/level:2
./cpu0/cache/index2/number_of_sets:8
./cpu0/cache/index2/shared_cpu_map:0000,000000ff
+./cpu0/cache/index2/shared_cpu_list:0-7 <- additional, OK
+./cpu0/cache/index2/ways_of_associativity:0 <- this is new but wrong I think
./cpu0/cache/index3/size:8192K
./cpu0/cache/index3/type:Unified
./cpu0/cache/index3/level:3
./cpu0/cache/index3/number_of_sets:8
./cpu0/cache/index3/shared_cpu_map:0000,000000ff
+./cpu0/cache/index3/shared_cpu_list:0-7
+./cpu0/cache/index3/ways_of_associativity:0 <- ditto
cheers
next prev parent reply other threads:[~2015-04-01 4:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 18:18 [PATCH RFC/RFT][RESEND] powerpc: move cacheinfo sysfs to generic cacheinfo infrastructure Sudeep Holla
2015-03-31 10:56 ` [RFC/RFT, RESEND] " Michael Ellerman
2015-03-31 17:14 ` Sudeep Holla
2015-04-01 4:40 ` Michael Ellerman [this message]
2015-04-01 9:56 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427863242.4256.10.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).