From: Michael Ellerman <mpe@ellerman.id.au>
To: Sudeep Holla <Sudeep.Holla@arm.com>,
linux-kernel@vger.kernel.org,
Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [RFC/RFT, RESEND] powerpc: move cacheinfo sysfs to generic cacheinfo infrastructure
Date: Tue, 31 Mar 2015 21:56:37 +1100 (AEDT) [thread overview]
Message-ID: <20150331105637.39B451400DE@ozlabs.org> (raw)
In-Reply-To: <1424715500-21725-1-git-send-email-sudeep.holla@arm.com>
On Mon, 2015-23-02 at 18:18:20 UTC, Sudeep Holla wrote:
> This patch removes the redundant sysfs cacheinfo code by reusing
> the newly introduced generic cacheinfo infrastructure through the
> commit 246246cbde5e ("drivers: base: support cpu cache information
> interface to userspace via sysfs")
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
> Cc: linuxppc-dev@lists.ozlabs.org
> ---
> arch/powerpc/kernel/cacheinfo.c | 811 +++++-----------------------------------
> arch/powerpc/kernel/cacheinfo.h | 8 -
> arch/powerpc/kernel/sysfs.c | 12 +-
> 3 files changed, 91 insertions(+), 740 deletions(-)
> delete mode 100644 arch/powerpc/kernel/cacheinfo.h
>
> Hi,
>
> This patch is not tested. Last time Anshuman tested, he had seen issues.
> The core driver has changed a lot after that. Since PPC depends a lot
> on DT for cache information, there might be issues in the core later
> which I could not identify with ARM/ARM64. It would be much appreciable
> if someone help me in testing and fixing those so that PPC can migrate
> to new/common cacheinfo infrastructure. This resend is rebased on v4.0-rc1
Doesn't build for me.
arch/powerpc/platforms/pseries/suspend.c:29:36: fatal error: ../../kernel/cacheinfo.h: No such file or directory
#include "../../kernel/cacheinfo.h"
Anshuman must have worked around that somehow to test it previously?
Removing the include doesn't fix it, it needs cacheinfo_cpu_on/offline().
cheers
next prev parent reply other threads:[~2015-03-31 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 18:18 [PATCH RFC/RFT][RESEND] powerpc: move cacheinfo sysfs to generic cacheinfo infrastructure Sudeep Holla
2015-03-31 10:56 ` Michael Ellerman [this message]
2015-03-31 17:14 ` [RFC/RFT, RESEND] " Sudeep Holla
2015-04-01 4:40 ` Michael Ellerman
2015-04-01 9:56 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331105637.39B451400DE@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=Sudeep.Holla@arm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).