* [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards
@ 2015-04-07 13:03 Javier Martinez Canillas
2015-04-07 15:09 ` Doug Anderson
0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-04-07 13:03 UTC (permalink / raw)
To: Kukjin Kim
Cc: Olof Johansson, Doug Anderson, Kevin Hilman, Tyler Baker,
Abhilash Kesavan, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Javier Martinez Canillas
The Marvell mwifiex driver prevents the system to enter into a suspend
state if the card power is not preserved during a suspend/resume cycle.
So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
and Exynos5420 Peach Pit Chromebooks.
Add the keep-power-in-suspend Power Management property to the SDIO/MMC
node so the mwifiex suspend handler doesn't fail and the system is able
to enter into a suspend state.
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 0788d08fb43e..146e71118a72 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -711,6 +711,7 @@
num-slots = <1>;
broken-cd;
cap-sdio-irq;
+ keep-power-in-suspend;
card-detect-delay = <200>;
clock-frequency = <400000000>;
samsung,dw-mshc-ciu-div = <1>;
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 412f41d62686..02eb8b15374f 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -674,6 +674,7 @@
num-slots = <1>;
broken-cd;
cap-sdio-irq;
+ keep-power-in-suspend;
card-detect-delay = <200>;
clock-frequency = <400000000>;
samsung,dw-mshc-ciu-div = <1>;
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards
2015-04-07 13:03 [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards Javier Martinez Canillas
@ 2015-04-07 15:09 ` Doug Anderson
2015-04-15 8:07 ` Javier Martinez Canillas
0 siblings, 1 reply; 4+ messages in thread
From: Doug Anderson @ 2015-04-07 15:09 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Kukjin Kim, Olof Johansson, Kevin Hilman, Tyler Baker,
Abhilash Kesavan, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Javier,
On Tue, Apr 7, 2015 at 6:03 AM, Javier Martinez Canillas
<javier.martinez@collabora.co.uk> wrote:
> The Marvell mwifiex driver prevents the system to enter into a suspend
> state if the card power is not preserved during a suspend/resume cycle.
>
> So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
> and Exynos5420 Peach Pit Chromebooks.
>
> Add the keep-power-in-suspend Power Management property to the SDIO/MMC
> node so the mwifiex suspend handler doesn't fail and the system is able
> to enter into a suspend state.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
> 2 files changed, 2 insertions(+)
Reviewed-by: Doug Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards
2015-04-07 15:09 ` Doug Anderson
@ 2015-04-15 8:07 ` Javier Martinez Canillas
2015-04-30 0:41 ` Javier Martinez Canillas
0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-04-15 8:07 UTC (permalink / raw)
To: Kukjin Kim
Cc: Doug Anderson, Olof Johansson, Kevin Hilman, Tyler Baker,
Abhilash Kesavan, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Hello Kukjin,
On 04/07/2015 05:09 PM, Doug Anderson wrote:
> Javier,
>
> On Tue, Apr 7, 2015 at 6:03 AM, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
>> The Marvell mwifiex driver prevents the system to enter into a suspend
>> state if the card power is not preserved during a suspend/resume cycle.
>>
>> So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
>> and Exynos5420 Peach Pit Chromebooks.
>>
>> Add the keep-power-in-suspend Power Management property to the SDIO/MMC
>> node so the mwifiex suspend handler doesn't fail and the system is able
>> to enter into a suspend state.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> ---
>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
>> 2 files changed, 2 insertions(+)
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
>
Any comments on this patch?
Best regards,
Javier
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards
2015-04-15 8:07 ` Javier Martinez Canillas
@ 2015-04-30 0:41 ` Javier Martinez Canillas
0 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-04-30 0:41 UTC (permalink / raw)
To: Kukjin Kim, kgene.kim
Cc: Doug Anderson, Olof Johansson, Kevin Hilman, Tyler Baker,
Abhilash Kesavan, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Hello Kukjin,
On 04/15/2015 10:07 AM, Javier Martinez Canillas wrote:
>
> On 04/07/2015 05:09 PM, Doug Anderson wrote:
>> Javier,
>>
>> On Tue, Apr 7, 2015 at 6:03 AM, Javier Martinez Canillas
>> <javier.martinez@collabora.co.uk> wrote:
>>> The Marvell mwifiex driver prevents the system to enter into a suspend
>>> state if the card power is not preserved during a suspend/resume cycle.
>>>
>>> So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
>>> and Exynos5420 Peach Pit Chromebooks.
>>>
>>> Add the keep-power-in-suspend Power Management property to the SDIO/MMC
>>> node so the mwifiex suspend handler doesn't fail and the system is able
>>> to enter into a suspend state.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>> ---
>>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
>>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
>>> 2 files changed, 2 insertions(+)
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>>
>
> Any comments on this patch?
>
> Best regards,
> Javier
>
Gentle reminder about this patch.
Best regards,
Javier
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-30 0:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-07 13:03 [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards Javier Martinez Canillas
2015-04-07 15:09 ` Doug Anderson
2015-04-15 8:07 ` Javier Martinez Canillas
2015-04-30 0:41 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).