From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
Matt Fleming <matt@codeblueprint.co.uk>,
Ming Lei <ming.lei@canonical.com>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware
Date: Tue, 21 Apr 2015 21:51:09 -0700 [thread overview]
Message-ID: <1429678269.18798.9.camel@HansenPartnership.com> (raw)
In-Reply-To: <CALCETrVsmQxoJ6WxVnW03Q9Hq8oH=zuv662S6TJxFwb26d=erQ@mail.gmail.com>
On Tue, 2015-04-21 at 20:24 -0700, Andy Lutomirski wrote:
> On Tue, Apr 21, 2015 at 7:20 PM, James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
> > On Tue, 2015-04-21 at 18:58 -0700, Andy Lutomirski wrote:
> >> On Tue, Apr 21, 2015 at 6:21 PM, James Bottomley
> >> <James.Bottomley@hansenpartnership.com> wrote:
> >> > Andy, just on the misc device idea, what about triggering the capsule
> >> > update from close()? In theory close returns an error code (not sure if
> >> > most tools actually check this, though). That means we can do the write
> >> > in chunks but pass it in atomically on the close and cat will work
> >> > (provided it checks the return code of close).
> >>
> >> I thought about this but IIRC cat doesn't check the return value from close.
> >
> > It does in my copy (coreutils-8.23) :
> >
> > if (!STREQ (infile, "-") && close (input_desc) < 0)
> > {
> > error (0, errno, "%s", infile);
> > ok = false;
> > }
> > [...]
> > if (have_read_stdin && close (STDIN_FILENO) < 0)
> > error (EXIT_FAILURE, errno, _("closing standard input"));
> >
>
> True, but it's stdout that we care about, not stdin :(
Gosh you're determined to force me to wade through this source code,
aren't you? That's handled in lib/closeout.c:
/* Close standard output. On error, issue a diagnostic and _exit
with status 'exit_failure'.
...
The point is that, admittedly much to my surprise, it all looks to be
handled by cat ... so we could proceed to have the transaction completed
in close in a misc device (or a sysfs file).
Unless there are any other rabbits you'd like to pull out of the hat?
James
next prev parent reply other threads:[~2015-04-22 4:51 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 9:44 [PATCH v4 0/2] Enable capsule loader interface for efi firmware updating Kweh, Hock Leong
2015-04-14 9:44 ` [PATCH v4 1/2] firmware_loader: introduce new API - request_firmware_direct_full_path() Kweh, Hock Leong
2015-04-14 14:08 ` Greg Kroah-Hartman
2015-04-14 15:56 ` Andy Lutomirski
2015-04-14 16:18 ` Borislav Petkov
2015-04-15 10:14 ` Matt Fleming
2015-04-15 10:18 ` Borislav Petkov
2015-04-15 11:09 ` Matt Fleming
2015-04-15 13:15 ` Greg Kroah-Hartman
2015-04-15 15:53 ` Andy Lutomirski
2015-04-15 12:48 ` Matt Fleming
2015-04-14 9:44 ` [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware Kweh, Hock Leong
2015-04-14 14:09 ` Greg Kroah-Hartman
2015-04-14 15:52 ` Andy Lutomirski
2015-04-15 13:20 ` Greg Kroah-Hartman
2015-04-15 15:45 ` Andy Lutomirski
2015-04-16 0:19 ` Roy Franz
2015-04-17 13:50 ` Greg KH
2015-04-15 11:32 ` Kweh, Hock Leong
2015-04-15 13:19 ` Greg Kroah-Hartman
2015-04-16 9:42 ` Kweh, Hock Leong
2015-04-17 13:49 ` Greg Kroah-Hartman
2015-04-17 14:36 ` Matt Fleming
2015-04-20 3:28 ` Kweh, Hock Leong
2015-04-20 14:43 ` Greg Kroah-Hartman
2015-04-21 3:23 ` Kweh, Hock Leong
2015-04-21 7:56 ` Greg Kroah-Hartman
2015-04-22 1:21 ` James Bottomley
2015-04-22 1:58 ` Andy Lutomirski
2015-04-22 2:20 ` James Bottomley
2015-04-22 3:24 ` Andy Lutomirski
2015-04-22 4:51 ` James Bottomley [this message]
2015-04-22 16:50 ` Andy Lutomirski
2015-04-22 17:34 ` James Bottomley
2015-04-22 17:45 ` Andy Lutomirski
2015-04-22 13:27 ` Peter Jones
2015-04-22 15:18 ` James Bottomley
2015-04-22 15:24 ` One Thousand Gnomes
2015-04-23 8:30 ` Kweh, Hock Leong
2015-04-23 14:09 ` James Bottomley
2015-04-24 2:14 ` Kweh, Hock Leong
2015-04-24 15:16 ` James Bottomley
2015-04-27 21:59 ` Andy Lutomirski
2015-04-27 22:35 ` James Bottomley
2015-04-27 22:40 ` Andy Lutomirski
2015-04-27 22:51 ` James Bottomley
2015-04-29 11:23 ` Kweh, Hock Leong
2015-04-29 18:40 ` Andy Lutomirski
2015-04-29 21:37 ` James Bottomley
2015-04-30 9:17 ` Kweh, Hock Leong
2015-04-30 17:55 ` Andy Lutomirski
2015-04-29 21:35 ` James Bottomley
2015-04-29 21:36 ` Andy Lutomirski
2015-04-29 21:39 ` James Bottomley
2015-04-29 21:42 ` Andy Lutomirski
2015-04-20 17:59 ` James Bottomley
2015-04-22 15:35 ` James Bottomley
2015-04-22 15:46 ` Greg Kroah-Hartman
2015-04-22 16:11 ` James Bottomley
2015-04-23 9:50 ` Greg Kroah-Hartman
2015-04-23 16:14 ` James Bottomley
2015-04-23 20:38 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429678269.18798.9.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=boon.leong.ong@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hock.leong.kweh@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=matt@codeblueprint.co.uk \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).