* [PATCH] perf report: Fix -T/--threads option to work again
@ 2015-04-29 12:08 Namhyung Kim
2015-04-29 21:36 ` Arnaldo Carvalho de Melo
2015-05-06 4:36 ` [tip:perf/urgent] perf report: Fix -T/ --threads " tip-bot for Namhyung Kim
0 siblings, 2 replies; 3+ messages in thread
From: Namhyung Kim @ 2015-04-29 12:08 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ingo Molnar, Peter Zijlstra, Jiri Olsa, LKML, David Ahern,
Stephane Eranian, Andi Kleen
The commit 512ae1bd6acb ("perf tools: Consolidate management of default
sort orders") changed default value of the 'sort_order' variable to NULL
indicating that users don't set any sort keys on the command line.
However it missed to update a check in perf_evlist__tty_browse_hists()
so that 'perf report -T' cannot show the per-thread values after the
normal output. This patch fixes it to work again.
Note that the -T option only works on --stdio and neither --sort nor
--parent option was given.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 476cdf7afcca..b63aeda719be 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -329,7 +329,7 @@ static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist,
fprintf(stdout, "\n\n");
}
- if (sort_order == default_sort_order &&
+ if (sort_order == NULL &&
parent_pattern == default_parent_pattern) {
fprintf(stdout, "#\n# (%s)\n#\n", help);
--
2.3.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf report: Fix -T/--threads option to work again
2015-04-29 12:08 [PATCH] perf report: Fix -T/--threads option to work again Namhyung Kim
@ 2015-04-29 21:36 ` Arnaldo Carvalho de Melo
2015-05-06 4:36 ` [tip:perf/urgent] perf report: Fix -T/ --threads " tip-bot for Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-04-29 21:36 UTC (permalink / raw)
To: Namhyung Kim
Cc: Ingo Molnar, Peter Zijlstra, Jiri Olsa, LKML, David Ahern,
Stephane Eranian, Andi Kleen
Em Wed, Apr 29, 2015 at 09:08:48PM +0900, Namhyung Kim escreveu:
> The commit 512ae1bd6acb ("perf tools: Consolidate management of default
> sort orders") changed default value of the 'sort_order' variable to NULL
> indicating that users don't set any sort keys on the command line.
>
> However it missed to update a check in perf_evlist__tty_browse_hists()
> so that 'perf report -T' cannot show the per-thread values after the
> normal output. This patch fixes it to work again.
>
> Note that the -T option only works on --stdio and neither --sort nor
> --parent option was given.
Thanks, applied to perf/urgent.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/urgent] perf report: Fix -T/ --threads option to work again
2015-04-29 12:08 [PATCH] perf report: Fix -T/--threads option to work again Namhyung Kim
2015-04-29 21:36 ` Arnaldo Carvalho de Melo
@ 2015-05-06 4:36 ` tip-bot for Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Namhyung Kim @ 2015-05-06 4:36 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, eranian, linux-kernel, dsahern, a.p.zijlstra, andi, mingo,
tglx, hpa, namhyung, jolsa
Commit-ID: e944ec2ca00fb0170ba9d7f2aeec32c22dc0d4ec
Gitweb: http://git.kernel.org/tip/e944ec2ca00fb0170ba9d7f2aeec32c22dc0d4ec
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Wed, 29 Apr 2015 21:08:48 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 1 May 2015 10:13:30 -0300
perf report: Fix -T/--threads option to work again
The commit 512ae1bd6acb ("perf tools: Consolidate management of default
sort orders") changed default value of the 'sort_order' variable to NULL
indicating that users don't set any sort keys on the command line.
However it missed to update a check in perf_evlist__tty_browse_hists()
so that 'perf report -T' cannot show the per-thread values after the
normal output. This patch fixes it to work again.
Note that the -T option only works on --stdio and neither --sort nor
--parent option was given.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1430309328-28317-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 476cdf7..b63aeda 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -329,7 +329,7 @@ static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist,
fprintf(stdout, "\n\n");
}
- if (sort_order == default_sort_order &&
+ if (sort_order == NULL &&
parent_pattern == default_parent_pattern) {
fprintf(stdout, "#\n# (%s)\n#\n", help);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-06 4:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-29 12:08 [PATCH] perf report: Fix -T/--threads option to work again Namhyung Kim
2015-04-29 21:36 ` Arnaldo Carvalho de Melo
2015-05-06 4:36 ` [tip:perf/urgent] perf report: Fix -T/ --threads " tip-bot for Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).