linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iio: doc: fix typo
@ 2015-04-30 14:36 Martin Kepplinger
  2015-05-03 19:14 ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Kepplinger @ 2015-04-30 14:36 UTC (permalink / raw)
  To: jic23, irina.tirdea; +Cc: linux-api, linux-kernel, Martin Kepplinger

Since we have deviceX, we don't need accelX. This has no users as of now, so
correcting this is no problem.

Signed-off-by: Martin Kepplinger <martink@posteo.de>
---

That's really just a question now. If I'm wrong, sorry for the noise.

 Documentation/ABI/testing/sysfs-bus-iio | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
index 3befcb1..efd1334 100644
--- a/Documentation/ABI/testing/sysfs-bus-iio
+++ b/Documentation/ABI/testing/sysfs-bus-iio
@@ -1119,7 +1119,7 @@ Description:
 		This attribute is used to read the amount of quadrature error
 		present in the device at a given time.
 
-What:		/sys/.../iio:deviceX/in_accelX_power_mode
+What:		/sys/.../iio:deviceX/in_accel_power_mode
 KernelVersion:	3.11
 Contact:	linux-iio@vger.kernel.org
 Description:
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: doc: fix typo
  2015-04-30 14:36 [PATCH] iio: doc: fix typo Martin Kepplinger
@ 2015-05-03 19:14 ` Jonathan Cameron
  2015-05-17 16:16   ` Martin Kepplinger
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2015-05-03 19:14 UTC (permalink / raw)
  To: Martin Kepplinger, irina.tirdea; +Cc: linux-api, linux-kernel

On 30/04/15 15:36, Martin Kepplinger wrote:
> Since we have deviceX, we don't need accelX. This has no users as of now, so
> correcting this is no problem.
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
The X is certainly misleading.  The interface could have a number there,
(if we have a device with multiple parallel accelerometers - unusual, but
not unheard of) but it would be the channel index, not the device index
and hence should be Y not X.

Or as we don't have any of these anyway, just drop the X and leave it as
an un-indexed accelerometer channel.

Jonathan
> ---
> 
> That's really just a question now. If I'm wrong, sorry for the noise.
> 
>  Documentation/ABI/testing/sysfs-bus-iio | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index 3befcb1..efd1334 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -1119,7 +1119,7 @@ Description:
>  		This attribute is used to read the amount of quadrature error
>  		present in the device at a given time.
>  
> -What:		/sys/.../iio:deviceX/in_accelX_power_mode
> +What:		/sys/.../iio:deviceX/in_accel_power_mode
>  KernelVersion:	3.11
>  Contact:	linux-iio@vger.kernel.org
>  Description:
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: doc: fix typo
  2015-05-03 19:14 ` Jonathan Cameron
@ 2015-05-17 16:16   ` Martin Kepplinger
  0 siblings, 0 replies; 3+ messages in thread
From: Martin Kepplinger @ 2015-05-17 16:16 UTC (permalink / raw)
  To: Jonathan Cameron, irina.tirdea; +Cc: linux-api, linux-kernel



Am 3. Mai 2015 21:14:02 MESZ, schrieb Jonathan Cameron <jic23@kernel.org>:
>On 30/04/15 15:36, Martin Kepplinger wrote:
>> Since we have deviceX, we don't need accelX. This has no users as of
>now, so
>> correcting this is no problem.
>> 
>> Signed-off-by: Martin Kepplinger <martink@posteo.de>
>The X is certainly misleading.  The interface could have a number
>there,
>(if we have a device with multiple parallel accelerometers - unusual,
>but
>not unheard of) but it would be the channel index, not the device index
>and hence should be Y not X.
>
>Or as we don't have any of these anyway, just drop the X and leave it
>as
>an un-indexed accelerometer channel.
>
>Jonathan

There actually is a user, without the index, bma180.c and if it's done correctly there I plan to use it aswell.

I think removing this index would be the right thing now and your scenario may be a bigger change.

      martin

>> ---
>> 
>> That's really just a question now. If I'm wrong, sorry for the noise.
>> 
>>  Documentation/ABI/testing/sysfs-bus-iio | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio
>b/Documentation/ABI/testing/sysfs-bus-iio
>> index 3befcb1..efd1334 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>> @@ -1119,7 +1119,7 @@ Description:
>>  		This attribute is used to read the amount of quadrature error
>>  		present in the device at a given time.
>>  
>> -What:		/sys/.../iio:deviceX/in_accelX_power_mode
>> +What:		/sys/.../iio:deviceX/in_accel_power_mode
>>  KernelVersion:	3.11
>>  Contact:	linux-iio@vger.kernel.org
>>  Description:
>> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-17 16:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-30 14:36 [PATCH] iio: doc: fix typo Martin Kepplinger
2015-05-03 19:14 ` Jonathan Cameron
2015-05-17 16:16   ` Martin Kepplinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).