From: Ming Lin <mlin@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Kent Overstreet <kent.overstreet@gmail.com>,
Dongsu Park <dpark@posteo.net>, Ming Lin <mlin@kernel.org>,
Christoph Hellwig <hch@infradead.org>, Neil Brown <neilb@suse.de>,
linux-raid@vger.kernel.org
Subject: [PATCH v3 10/11] md/raid10: make sync_request_write() call bio_copy_data()
Date: Wed, 6 May 2015 23:34:20 -0700 [thread overview]
Message-ID: <1430980461-5235-11-git-send-email-mlin@kernel.org> (raw)
In-Reply-To: <1430980461-5235-1-git-send-email-mlin@kernel.org>
From: Kent Overstreet <kent.overstreet@gmail.com>
Refactor sync_request_write() of md/raid10 to use bio_copy_data()
instead of open coding bio_vec iterations.
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Neil Brown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: NeilBrown <neilb@suse.de>
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park <dpark@posteo.net>
Signed-off-by: Ming Lin <mlin@kernel.org>
---
drivers/md/raid10.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index a46c402..6ea6f5f 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1989,17 +1989,10 @@ static void sync_request_write(struct mddev *mddev, struct r10bio *r10_bio)
tbio->bi_rw = WRITE;
tbio->bi_private = r10_bio;
tbio->bi_iter.bi_sector = r10_bio->devs[i].addr;
-
- for (j=0; j < vcnt ; j++) {
- tbio->bi_io_vec[j].bv_offset = 0;
- tbio->bi_io_vec[j].bv_len = PAGE_SIZE;
-
- memcpy(page_address(tbio->bi_io_vec[j].bv_page),
- page_address(fbio->bi_io_vec[j].bv_page),
- PAGE_SIZE);
- }
tbio->bi_end_io = end_sync_write;
+ bio_copy_data(tbio, fbio);
+
d = r10_bio->devs[i].devnum;
atomic_inc(&conf->mirrors[d].rdev->nr_pending);
atomic_inc(&r10_bio->remaining);
@@ -2014,17 +2007,14 @@ static void sync_request_write(struct mddev *mddev, struct r10bio *r10_bio)
* that are active
*/
for (i = 0; i < conf->copies; i++) {
- int j, d;
+ int d;
tbio = r10_bio->devs[i].repl_bio;
if (!tbio || !tbio->bi_end_io)
continue;
if (r10_bio->devs[i].bio->bi_end_io != end_sync_write
&& r10_bio->devs[i].bio != fbio)
- for (j = 0; j < vcnt; j++)
- memcpy(page_address(tbio->bi_io_vec[j].bv_page),
- page_address(fbio->bi_io_vec[j].bv_page),
- PAGE_SIZE);
+ bio_copy_data(tbio, fbio);
d = r10_bio->devs[i].devnum;
atomic_inc(&r10_bio->remaining);
md_sync_acct(conf->mirrors[d].replacement->bdev,
--
1.9.1
next prev parent reply other threads:[~2015-05-07 6:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 6:34 [PATCH v3 00/11] simplify block layer based on immutable biovecs Ming Lin
2015-05-07 6:34 ` [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-05-18 16:52 ` Jeff Moyer
2015-05-18 17:22 ` Christoph Hellwig
2015-05-22 7:51 ` Ming Lin
2015-05-20 18:30 ` Ming Lin
2015-05-20 18:58 ` Jeff Moyer
2015-05-20 20:18 ` Ming Lin
2015-05-22 17:49 ` Ming Lin
2015-05-20 12:44 ` Christoph Hellwig
2015-05-20 18:16 ` Ming Lin
2015-05-07 6:34 ` [PATCH v3 02/11] block: simplify bio_add_page() Ming Lin
2015-05-07 6:34 ` [PATCH v3 03/11] block: allow __blk_queue_bounce() to handle bios larger than BIO_MAX_PAGES Ming Lin
2015-05-19 8:44 ` Christoph Hellwig
2015-05-20 18:17 ` Ming Lin
2015-05-07 6:34 ` [PATCH v3 04/11] bcache: remove driver private bio splitting code Ming Lin
2015-05-07 6:34 ` [PATCH v3 05/11] btrfs: remove bio splitting and merge_bvec_fn() calls Ming Lin
2015-05-07 6:34 ` [PATCH v3 06/11] md/raid5: get rid of bio_fits_rdev() Ming Lin
2015-05-07 6:34 ` [PATCH v3 07/11] md/raid5: split bio for chunk_aligned_read Ming Lin
2015-05-08 4:14 ` NeilBrown
2015-05-08 5:57 ` Ming Lin
2015-05-07 6:34 ` [PATCH v3 08/11] block: kill merge_bvec_fn() completely Ming Lin
2015-05-07 6:34 ` [PATCH v3 09/11] fs: use helper bio_add_page() instead of open coding on bi_io_vec Ming Lin
2015-05-07 6:34 ` Ming Lin [this message]
2015-05-19 8:45 ` [PATCH v3 10/11] md/raid10: make sync_request_write() call bio_copy_data() Christoph Hellwig
2015-05-20 3:09 ` NeilBrown
2015-05-07 6:34 ` [PATCH v3 11/11] Documentation: update notes in biovecs about arbitrarily sized bios Ming Lin
2015-05-18 16:13 ` [PATCH v3 00/11] simplify block layer based on immutable biovecs Christoph Hellwig
2015-05-20 12:48 ` Christoph Hellwig
2015-05-20 18:10 ` Ming Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430980461-5235-11-git-send-email-mlin@kernel.org \
--to=mlin@kernel.org \
--cc=axboe@kernel.dk \
--cc=dpark@posteo.net \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).