From: Toshi Kani <toshi.kani@hp.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@ml01.01.org, Neil Brown <neilb@suse.de>,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-nvdimm] [PATCH v2 18/20] libnd: infrastructure for btt devices
Date: Tue, 12 May 2015 10:33:20 -0600 [thread overview]
Message-ID: <1431448400.24419.99.camel@misato.fc.hp.com> (raw)
In-Reply-To: <20150428182551.35812.97856.stgit@dwillia2-desk3.amr.corp.intel.com>
On Tue, 2015-04-28 at 14:25 -0400, Dan Williams wrote:
> Block devices from an nd bus, in addition to accepting "struct bio"
> based requests, also have the capability to perform byte-aligned
> accesses. By default only the bio/block interface is used. However, if
> another driver can make effective use of the byte-aligned capability it
> can claim/disable the block interface and use the byte-aligned "nd_io"
> interface.
>
> The BTT driver is the intended first consumer of this mechanism to allow
> layering atomic sector update guarantees on top of nd_io capable
> nd-bus-block-devices.
:
> +static int nd_btt_autodetect(struct nd_bus *nd_bus, struct nd_io *ndio,
> + struct block_device *bdev)
> +{
> + char name[BDEVNAME_SIZE];
> + struct nd_btt *nd_btt;
> + struct btt_sb *btt_sb;
> + u64 offset, checksum;
> + u32 lbasize;
> + u8 *uuid;
> + int rc;
> +
> + btt_sb = kzalloc(sizeof(*btt_sb), GFP_KERNEL);
> + if (!btt_sb)
> + return -ENODEV;
> +
> + offset = nd_partition_offset(bdev);
> + rc = ndio->rw_bytes(ndio, btt_sb, offset + SZ_4K, sizeof(*btt_sb), READ);
> + if (rc)
> + goto out_free_sb;
> +
> + if (get_capacity(bdev->bd_disk) < SZ_16M / 512)
> + goto out_free_sb;
> +
> + if (memcmp(btt_sb->signature, BTT_SIG, BTT_SIG_LEN) != 0)
> + goto out_free_sb;
> +
> + checksum = le64_to_cpu(btt_sb->checksum);
> + btt_sb->checksum = 0;
> + if (checksum != nd_btt_sb_checksum(btt_sb))
> + goto out_free_sb;
> + btt_sb->checksum = cpu_to_le64(checksum);
> +
> + uuid = kmemdup(btt_sb->uuid, 16, GFP_KERNEL);
> + if (!uuid)
> + goto out_free_sb;
> +
> + lbasize = le32_to_cpu(btt_sb->external_lbasize);
> + nd_btt = __nd_btt_create(nd_bus, lbasize, uuid);
When BTT is first set up, user binds a seed "btt0" to a block device,
such as /dev/pmem0. It then creates /dev/nd0 bound to /dev/pmem0.
After a reboot, nd_btt_autodetect() detects the BTT setup and creates a
new "btt1" since it is called after a seed "btt0" is created.
Therefore, it creates /dev/nd1 bound to /dev/pmem0 this time.
Is this how it is intended to work, i.e. "btt0" as the default seed btt?
While user should not rely on the name of /dev/nd%d, I thought this
device name change was confusing...
Thanks,
-Toshi
next prev parent reply other threads:[~2015-05-12 16:52 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 18:24 [PATCH v2 00/20] libnd: non-volatile memory device support Dan Williams
2015-04-28 18:24 ` [PATCH v2 01/20] e820, efi: add ACPI 6.0 persistent memory types Dan Williams
2015-04-28 20:49 ` Andy Lutomirski
2015-04-28 20:57 ` Dan Williams
2015-04-28 21:05 ` Andy Lutomirski
2015-05-15 15:43 ` [Linux-nvdimm] " Jeff Moyer
2015-05-15 15:48 ` Dan Williams
2015-05-18 19:28 ` Andy Lutomirski
2015-04-28 18:24 ` [PATCH v2 02/20] libnd, nd_acpi: initial libnd infrastructure and NFIT support Dan Williams
2015-04-30 23:23 ` Rafael J. Wysocki
2015-05-01 0:39 ` Dan Williams
2015-05-01 1:21 ` Rafael J. Wysocki
2015-05-01 16:23 ` Dan Williams
2015-05-04 23:58 ` Rafael J. Wysocki
2015-05-04 23:46 ` Dan Williams
2015-05-15 19:44 ` [Linux-nvdimm] " Jeff Moyer
2015-05-15 20:41 ` Dan Williams
2015-04-28 18:24 ` [PATCH v2 03/20] nd_acpi, nfit-test: manufactured NFITs for interface development Dan Williams
2015-05-15 20:25 ` [Linux-nvdimm] " Jeff Moyer
2015-05-15 20:50 ` Dan Williams
2015-04-28 18:24 ` [PATCH v2 04/20] libnd: ndctl class device, and nd bus attributes Dan Williams
2015-05-15 21:00 ` [Linux-nvdimm] " Jeff Moyer
2015-04-28 18:24 ` [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices Dan Williams
2015-05-01 17:48 ` [Linux-nvdimm] " Toshi Kani
2015-05-01 18:22 ` Dan Williams
2015-05-01 18:19 ` Toshi Kani
2015-05-01 18:43 ` Dan Williams
2015-05-01 19:15 ` Toshi Kani
2015-05-01 19:38 ` Dan Williams
2015-05-01 20:08 ` Toshi Kani
2015-04-28 18:24 ` [PATCH v2 06/20] libnd: ndctl.h, the nd ioctl abi Dan Williams
2015-04-28 18:24 ` [PATCH v2 07/20] libnd, nd_dimm: dimm driver and base libnd device-driver infrastructure Dan Williams
2015-05-20 16:59 ` [Linux-nvdimm] " Elliott, Robert (Server Storage)
2015-05-20 17:02 ` Dan Williams
2015-04-28 18:24 ` [PATCH v2 08/20] libnd, nd_acpi: regions (block-data-window, persistent memory, volatile memory) Dan Williams
2015-04-29 15:53 ` [Linux-nvdimm] " Elliott, Robert (Server Storage)
2015-04-29 15:59 ` Dan Williams
2015-05-04 20:26 ` Toshi Kani
2015-05-09 23:55 ` Dan Williams
2015-05-28 18:36 ` Toshi Kani
2015-05-28 19:59 ` Dan Williams
2015-05-28 20:51 ` Linda Knippers
2015-05-28 20:58 ` Dan Williams
2015-04-28 18:25 ` [PATCH v2 09/20] libnd: support for legacy (non-aliasing) nvdimms Dan Williams
2015-04-28 18:25 ` [PATCH v2 10/20] pmem: use ida Dan Williams
2015-04-29 18:25 ` [Linux-nvdimm] " Toshi Kani
2015-04-29 18:59 ` Dan Williams
2015-04-29 18:53 ` Toshi Kani
2015-04-29 20:49 ` Linda Knippers
2015-04-29 21:36 ` Dan Williams
2015-04-28 18:25 ` [PATCH v2 11/20] libnd, nd_pmem: add libnd support to the pmem driver Dan Williams
2015-04-28 21:04 ` Andy Lutomirski
2015-04-28 22:21 ` [Linux-nvdimm] " Phil Pokorny
2015-04-28 22:58 ` Andy Lutomirski
2015-04-29 0:17 ` Phil Pokorny
2015-04-29 0:28 ` Andy Lutomirski
2015-04-29 15:55 ` Dan Williams
2015-04-29 18:36 ` Andy Lutomirski
2015-04-28 18:25 ` [PATCH v2 12/20] libnd, nd_acpi: add interleave-set state-tracking infrastructure Dan Williams
2015-04-28 18:25 ` [PATCH v2 13/20] libnd: namespace indices: read and validate Dan Williams
2015-04-28 18:25 ` [PATCH v2 14/20] libnd: pmem label sets and namespace instantiation Dan Williams
2015-04-28 18:25 ` [PATCH v2 15/20] libnd: blk labels " Dan Williams
2015-04-28 18:25 ` [PATCH v2 16/20] libnd: write pmem label set Dan Williams
2015-04-28 18:25 ` [PATCH v2 17/20] libnd: write blk " Dan Williams
2015-04-28 18:25 ` [PATCH v2 18/20] libnd: infrastructure for btt devices Dan Williams
2015-05-12 16:33 ` Toshi Kani [this message]
2015-05-15 0:41 ` [Linux-nvdimm] " Dan Williams
2015-05-15 4:25 ` Elliott, Robert (Server Storage)
2015-04-28 18:25 ` [PATCH v2 19/20] nd_btt: atomic sector updates Dan Williams
2015-05-17 1:19 ` [Linux-nvdimm] " Elliott, Robert (Server Storage)
2015-05-17 3:22 ` Dan Williams
2015-05-20 17:20 ` Elliott, Robert (Server Storage)
2015-05-18 22:38 ` Verma, Vishal L
2015-04-28 18:26 ` [PATCH v2 20/20] libnd, nd_acpi, nd_blk: driver for BLK-mode access persistent memory Dan Williams
2015-04-28 21:10 ` Andy Lutomirski
2015-04-28 22:30 ` Dan Williams
2015-04-28 23:06 ` Andy Lutomirski
2015-04-29 17:10 ` Dan Williams
2015-04-29 19:28 ` Andy Lutomirski
2015-04-28 20:52 ` [PATCH v2 00/20] libnd: non-volatile memory device support Andy Lutomirski
2015-04-28 20:59 ` Dan Williams
2015-04-28 21:06 ` Andy Lutomirski
2015-04-28 22:28 ` Dan Williams
2015-04-28 23:05 ` Andy Lutomirski
2015-04-30 20:56 ` Ross Zwisler
2015-04-28 21:24 ` [Linux-nvdimm] " Elliott, Robert (Server Storage)
2015-04-28 22:15 ` Dan Williams
2015-05-07 7:29 ` Christoph Hellwig
2015-04-29 0:25 ` Rafael J. Wysocki
2015-04-29 1:22 ` Dan Williams
2015-05-05 0:06 ` Rafael J. Wysocki
2015-05-08 6:31 ` Williams, Dan J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431448400.24419.99.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).