From: David Woodhouse <dwmw2@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>,
Quentin Casasnovas <quentin.casasnovas@oracle.com>
Subject: Re: mod_devicetable: Make dmi_strmatch.substr const char *
Date: Tue, 19 May 2015 07:46:58 +0100 [thread overview]
Message-ID: <1432018018.3277.22.camel@infradead.org> (raw)
In-Reply-To: <1431994055.2870.102.camel@perches.com>
On Mon, 2015-05-18 at 17:07 -0700, Joe Perches wrote:
>
> changed dmi_strmatch.substr from char * to char[79];
>
> Changing it back to const char * would shrink an x86-64
> defconfig more than 100KB.
>
> $ size vmlinux.old vmlinux.new
> text data bss dec hex filename
> 11941725 1825624 1085440 14852789 e2a2b5 vmlinux.old
> 11921172 1730648 1085440 14737260 e0df6c vmlinux.new
>
> modpost has changed a bit since 2008, is it's time to change it back?
Does the match table stuff still work if you do that? I thought the
point in changing to an array was to make the table extraction do the
right thing because it can't follow pointers...
--
dwmw2
next prev parent reply other threads:[~2015-05-19 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 0:07 mod_devicetable: Make dmi_strmatch.substr const char * Joe Perches
2015-05-19 6:46 ` David Woodhouse [this message]
2015-05-19 15:56 ` One Thousand Gnomes
2015-05-19 19:19 ` Joe Perches
2015-05-20 5:19 ` Rusty Russell
2015-05-20 7:25 ` Michal Marek
2015-05-20 7:58 ` Joe Perches
2015-05-20 20:31 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432018018.3277.22.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quentin.casasnovas@oracle.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).