* [PATCH] ARM: at91/dt: at91sam9x5: fix usart1 sck pin definition
@ 2015-05-20 12:36 Nicolas Ferre
2015-05-20 12:41 ` Alexandre Belloni
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Ferre @ 2015-05-20 12:36 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-kernel, Alexandre Belloni,
Jean-Christophe PLAGNIOL-VILLARD, Nicolas Ferre
SCK1 pin is pioC 29. Comment was okay.
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
index 9c236c317eeb..dfdbdf43860e 100644
--- a/arch/arm/boot/dts/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
@@ -505,7 +505,7 @@
pinctrl_usart1_sck: usart1_sck-0 {
atmel,pins =
- <AT91_PIOC 28 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC29 periph C */
+ <AT91_PIOC 29 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC29 periph C */
};
};
--
2.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: at91/dt: at91sam9x5: fix usart1 sck pin definition
2015-05-20 12:36 [PATCH] ARM: at91/dt: at91sam9x5: fix usart1 sck pin definition Nicolas Ferre
@ 2015-05-20 12:41 ` Alexandre Belloni
2015-05-20 12:46 ` Nicolas Ferre
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Belloni @ 2015-05-20 12:41 UTC (permalink / raw)
To: Nicolas Ferre
Cc: linux-arm-kernel, linux-kernel, Jean-Christophe PLAGNIOL-VILLARD
On 20/05/2015 at 14:36:10 +0200, Nicolas Ferre wrote :
> SCK1 pin is pioC 29. Comment was okay.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> index 9c236c317eeb..dfdbdf43860e 100644
> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> @@ -505,7 +505,7 @@
>
> pinctrl_usart1_sck: usart1_sck-0 {
> atmel,pins =
> - <AT91_PIOC 28 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC29 periph C */
> + <AT91_PIOC 29 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC29 periph C */
I think you should remove the comment. As you can see, it didn't help ;)
> };
> };
>
> --
> 2.1.3
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: at91/dt: at91sam9x5: fix usart1 sck pin definition
2015-05-20 12:41 ` Alexandre Belloni
@ 2015-05-20 12:46 ` Nicolas Ferre
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2015-05-20 12:46 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-arm-kernel, linux-kernel, Jean-Christophe PLAGNIOL-VILLARD
Le 20/05/2015 14:41, Alexandre Belloni a écrit :
> On 20/05/2015 at 14:36:10 +0200, Nicolas Ferre wrote :
>> SCK1 pin is pioC 29. Comment was okay.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>> arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index 9c236c317eeb..dfdbdf43860e 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -505,7 +505,7 @@
>>
>> pinctrl_usart1_sck: usart1_sck-0 {
>> atmel,pins =
>> - <AT91_PIOC 28 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC29 periph C */
>> + <AT91_PIOC 29 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC29 periph C */
>
> I think you should remove the comment. As you can see, it didn't help ;)
I agree, but didn't do it in this patch because the whole file is
stuffed with these useless comments... We'd better do it in a single
patch or... leave it like this...
Bye,
>> };
>> };
>>
>> --
>> 2.1.3
>>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-20 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-20 12:36 [PATCH] ARM: at91/dt: at91sam9x5: fix usart1 sck pin definition Nicolas Ferre
2015-05-20 12:41 ` Alexandre Belloni
2015-05-20 12:46 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).