linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Parav Pandit <parav.pandit@avagotech.com>
To: linux-nvme@lists.infradead.org, willy@linux.intel.com
Cc: parav.pandit@avagotech.com, axboe@kernel.dk,
	linux-kernel@vger.kernel.org
Subject: [PATCHv1] NVMe: nvme_queue made cache friendly.
Date: Wed, 20 May 2015 16:43:47 -0400	[thread overview]
Message-ID: <1432154627-12336-1-git-send-email-parav.pandit@avagotech.com> (raw)

nvme_queue structure made 64B cache friendly so that majority of the
data elements of the structure during IO and completion path can be
found in typical single 64B cache line size which was previously spanning
beyond single 64B cache line size.

By aligning most of the fields are found at start of the structure.
Elements which are not used in frequent IO path are moved at the
end of structure.

Signed-off-by: Parav Pandit <parav.pandit@avagotech.com>
---
 drivers/block/nvme-core.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index b9ba36f..58041c7 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -98,23 +98,23 @@ struct async_cmd_info {
 struct nvme_queue {
 	struct device *q_dmadev;
 	struct nvme_dev *dev;
-	char irqname[24];	/* nvme4294967295-65535\0 */
-	spinlock_t q_lock;
 	struct nvme_command *sq_cmds;
+	struct blk_mq_hw_ctx *hctx;
 	volatile struct nvme_completion *cqes;
-	dma_addr_t sq_dma_addr;
-	dma_addr_t cq_dma_addr;
 	u32 __iomem *q_db;
+	spinlock_t q_lock;
 	u16 q_depth;
-	s16 cq_vector;
 	u16 sq_head;
 	u16 sq_tail;
 	u16 cq_head;
 	u16 qid;
+	s16 cq_vector;
 	u8 cq_phase;
 	u8 cqe_seen;
 	struct async_cmd_info cmdinfo;
-	struct blk_mq_hw_ctx *hctx;
+	char irqname[24];	/* nvme4294967295-65535\0 */
+	dma_addr_t sq_dma_addr;
+	dma_addr_t cq_dma_addr;
 };
 
 /*
-- 
1.8.3.1


             reply	other threads:[~2015-05-20 15:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 20:43 Parav Pandit [this message]
2015-05-21 20:45 ` [PATCHv1] NVMe: nvme_queue made cache friendly J Freyensee
2015-05-22  4:52   ` Parav Pandit
2015-06-02  7:08     ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432154627-12336-1-git-send-email-parav.pandit@avagotech.com \
    --to=parav.pandit@avagotech.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).