From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>
To: <balbi@ti.com>
Cc: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
"Subbaraya Sundeep Bhatta" <sbhatta@xilinx.com>
Subject: [PATCH v2 1/3] usb: dwc3: gadget: Fix incorrect DEPCMD and DGCMD status macros
Date: Thu, 21 May 2015 15:46:46 +0530 [thread overview]
Message-ID: <1432203408-5482-1-git-send-email-sbhatta@xilinx.com> (raw)
Fixed the incorrect macro definitions correctly as per databook.
Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
Fixes: b09bb64239c8 (usb: dwc3: gadget: implement Global Command support)
Cc: <stable@vger.kernel.org> #v3.5+
---
v2 changes:
Added Fixes and Cc in commit message.
drivers/usb/dwc3/core.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index fdab715..c0eafa6 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -339,7 +339,7 @@
#define DWC3_DGCMD_SET_ENDPOINT_NRDY 0x0c
#define DWC3_DGCMD_RUN_SOC_BUS_LOOPBACK 0x10
-#define DWC3_DGCMD_STATUS(n) (((n) >> 15) & 1)
+#define DWC3_DGCMD_STATUS(n) (((n) >> 12) & 0x0F)
#define DWC3_DGCMD_CMDACT (1 << 10)
#define DWC3_DGCMD_CMDIOC (1 << 8)
@@ -355,7 +355,7 @@
#define DWC3_DEPCMD_PARAM_SHIFT 16
#define DWC3_DEPCMD_PARAM(x) ((x) << DWC3_DEPCMD_PARAM_SHIFT)
#define DWC3_DEPCMD_GET_RSC_IDX(x) (((x) >> DWC3_DEPCMD_PARAM_SHIFT) & 0x7f)
-#define DWC3_DEPCMD_STATUS(x) (((x) >> 15) & 1)
+#define DWC3_DEPCMD_STATUS(x) (((x) >> 12) & 0x0F)
#define DWC3_DEPCMD_HIPRI_FORCERM (1 << 11)
#define DWC3_DEPCMD_CMDACT (1 << 10)
#define DWC3_DEPCMD_CMDIOC (1 << 8)
--
1.7.4
next reply other threads:[~2015-05-21 10:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 10:16 Subbaraya Sundeep Bhatta [this message]
2015-05-21 10:16 ` [PATCH v2 2/3] usb: dwc3: gadget: return error if command sent to DGCMD register fails Subbaraya Sundeep Bhatta
2015-05-21 10:16 ` [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD " Subbaraya Sundeep Bhatta
2015-06-29 21:47 ` Felipe Balbi
2015-06-29 21:48 ` Felipe Balbi
2015-06-29 23:59 ` John Youn
2015-06-30 0:34 ` Felipe Balbi
2015-07-02 2:03 ` John Youn
2015-07-02 3:00 ` Felipe Balbi
2015-07-07 2:10 ` John Youn
2015-07-07 3:24 ` Felipe Balbi
[not found] ` <F1B223389110CE49B4CF055ABA2E5D3D7825118A@XAP-PVEXMBX02.xlnx.xilinx.com>
2015-07-11 19:29 ` Felipe Balbi
2015-07-13 17:50 ` John Youn
2015-07-13 18:58 ` Felipe Balbi
2015-07-15 9:49 ` Subbaraya Sundeep Bhatta
2015-07-20 17:51 ` Felipe Balbi
2015-07-20 18:16 ` John Youn
2015-07-20 18:37 ` Felipe Balbi
2015-07-01 7:29 ` Subbaraya Sundeep Bhatta
2015-07-06 17:07 ` Felipe Balbi
2015-07-07 5:01 ` Subbaraya Sundeep Bhatta
2015-07-08 9:50 ` Subbaraya Sundeep Bhatta
2015-07-08 18:16 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432203408-5482-1-git-send-email-sbhatta@xilinx.com \
--to=subbaraya.sundeep.bhatta@xilinx.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sbhatta@xilinx.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).