From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>
To: "balbi@ti.com" <balbi@ti.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails
Date: Tue, 7 Jul 2015 05:01:43 +0000 [thread overview]
Message-ID: <F1B223389110CE49B4CF055ABA2E5D3D7824DD0E@XAP-PVEXMBX02.xlnx.xilinx.com> (raw)
In-Reply-To: <20150706170746.GA8021@saruman.tx.rr.com>
Hi Felipe,
> -----Original Message-----
> From: Felipe Balbi [mailto:balbi@ti.com]
> Sent: Monday, July 06, 2015 10:38 PM
> To: Subbaraya Sundeep Bhatta
> Cc: balbi@ti.com; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org;
> linux-kernel@vger.kernel.org; stable@vger.kernel.org
> Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command
> sent to DEPCMD register fails
>
> On Wed, Jul 01, 2015 at 07:29:28AM +0000, Subbaraya Sundeep Bhatta
> wrote:
> > Hi Felipe,
> >
> > > -----Original Message-----
> > > From: Felipe Balbi [mailto:balbi@ti.com]
> > > Sent: Tuesday, June 30, 2015 3:17 AM
> > > To: Subbaraya Sundeep Bhatta
> > > Cc: balbi@ti.com; gregkh@linuxfoundation.org;
> > > linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > stable@vger.kernel.org; Subbaraya Sundeep Bhatta
> > > Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if
> > > command sent to DEPCMD register fails
> > >
> > > Hi,
> > >
> > > On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep
> Bhatta
> > > wrote:
> > > > We need to return error to caller if command is not sent to
> > > > controller succesfully.
> > > >
> > > > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
> > > > Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
> > > > Cc: <stable@vger.kernel.org>
> > > > ---
> > > > v2 changes:
> > > > Added Fixes and Cc in commit message.
> > >
> > > I noticed that this breaks at least my AM437x silicon with DWC3
> > > 2.40a when used with g_zero and testusb. As of now, it could be that
> > > silicon is mis-behaving because I got a Transfer Complete before the
> > > failing Set Endpoint Transfer Resource command.
> > >
> > > In any case, can you run on your setup with g_zero and
> > > test.sh/testusb [1]/[2] just to verify that it really works for you ?
> >
> > Ok I will do that.
>
> Did you manage to run the test I asked ? If we don't get down to this, I'll
> have to revert your patch as it regresses my platforms.
Sorry I caught up with some other customer reported issue on Zynq (Chipidea). I will do it by this weekend at any cost. Please wait.
Thanks,
Sundeep.B.S.
>
> --
> balbi
next prev parent reply other threads:[~2015-07-07 5:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 10:16 [PATCH v2 1/3] usb: dwc3: gadget: Fix incorrect DEPCMD and DGCMD status macros Subbaraya Sundeep Bhatta
2015-05-21 10:16 ` [PATCH v2 2/3] usb: dwc3: gadget: return error if command sent to DGCMD register fails Subbaraya Sundeep Bhatta
2015-05-21 10:16 ` [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD " Subbaraya Sundeep Bhatta
2015-06-29 21:47 ` Felipe Balbi
2015-06-29 21:48 ` Felipe Balbi
2015-06-29 23:59 ` John Youn
2015-06-30 0:34 ` Felipe Balbi
2015-07-02 2:03 ` John Youn
2015-07-02 3:00 ` Felipe Balbi
2015-07-07 2:10 ` John Youn
2015-07-07 3:24 ` Felipe Balbi
[not found] ` <F1B223389110CE49B4CF055ABA2E5D3D7825118A@XAP-PVEXMBX02.xlnx.xilinx.com>
2015-07-11 19:29 ` Felipe Balbi
2015-07-13 17:50 ` John Youn
2015-07-13 18:58 ` Felipe Balbi
2015-07-15 9:49 ` Subbaraya Sundeep Bhatta
2015-07-20 17:51 ` Felipe Balbi
2015-07-20 18:16 ` John Youn
2015-07-20 18:37 ` Felipe Balbi
2015-07-01 7:29 ` Subbaraya Sundeep Bhatta
2015-07-06 17:07 ` Felipe Balbi
2015-07-07 5:01 ` Subbaraya Sundeep Bhatta [this message]
2015-07-08 9:50 ` Subbaraya Sundeep Bhatta
2015-07-08 18:16 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F1B223389110CE49B4CF055ABA2E5D3D7824DD0E@XAP-PVEXMBX02.xlnx.xilinx.com \
--to=subbaraya.sundeep.bhatta@xilinx.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).