* [PATCH] drivers:usb:fsl: Introduce FSL_USB2_PHY_UTMI_DUAL macro
@ 2015-05-25 9:27 Nikhil Badola
2015-05-25 16:27 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Nikhil Badola @ 2015-05-25 9:27 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, Nikhil Badola, Ramneek Mehresh
Introduce FSL_USB2_PHY_UTMI_DUAL macro for setting phy mode
in SOCs such has T4240, T1040, T2080 which have utmi dual-phy
Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
---
drivers/usb/host/ehci-fsl.c | 1 +
drivers/usb/host/fsl-mph-dr-of.c | 2 ++
include/linux/fsl_devices.h | 1 +
3 files changed, 4 insertions(+)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index ab4eee3..1f0e4e0 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -226,6 +226,7 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
portsc |= PORT_PTS_PTW;
/* fall through */
case FSL_USB2_PHY_UTMI:
+ case FSL_USB2_PHY_UTMI_DUAL:
if (pdata->have_sysif_regs && pdata->controller_ver) {
/* controller version 1.6 or above */
setbits32(non_ehci + FSL_SOC_USB_CTRL, UTMI_PHY_EN);
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 7e325e9..ed39081 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -69,6 +69,8 @@ static enum fsl_usb2_phy_modes determine_usb_phy(const char *phy_type)
return FSL_USB2_PHY_UTMI;
if (!strcasecmp(phy_type, "utmi_wide"))
return FSL_USB2_PHY_UTMI_WIDE;
+ if (!strcasecmp(phy_type, "utmi_dual"))
+ return FSL_USB2_PHY_UTMI_DUAL;
if (!strcasecmp(phy_type, "serial"))
return FSL_USB2_PHY_SERIAL;
diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h
index a82296a..dd73fad 100644
--- a/include/linux/fsl_devices.h
+++ b/include/linux/fsl_devices.h
@@ -64,6 +64,7 @@ enum fsl_usb2_phy_modes {
FSL_USB2_PHY_UTMI,
FSL_USB2_PHY_UTMI_WIDE,
FSL_USB2_PHY_SERIAL,
+ FSL_USB2_PHY_UTMI_DUAL,
};
struct clk;
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers:usb:fsl: Introduce FSL_USB2_PHY_UTMI_DUAL macro
2015-05-25 9:27 [PATCH] drivers:usb:fsl: Introduce FSL_USB2_PHY_UTMI_DUAL macro Nikhil Badola
@ 2015-05-25 16:27 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-05-25 16:27 UTC (permalink / raw)
To: Nikhil Badola; +Cc: linux-kernel, Ramneek Mehresh
On Mon, May 25, 2015 at 02:57:34PM +0530, Nikhil Badola wrote:
> Introduce FSL_USB2_PHY_UTMI_DUAL macro for setting phy mode
> in SOCs such has T4240, T1040, T2080 which have utmi dual-phy
>
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
> drivers/usb/host/ehci-fsl.c | 1 +
> drivers/usb/host/fsl-mph-dr-of.c | 2 ++
> include/linux/fsl_devices.h | 1 +
> 3 files changed, 4 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index ab4eee3..1f0e4e0 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -226,6 +226,7 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
> portsc |= PORT_PTS_PTW;
> /* fall through */
> case FSL_USB2_PHY_UTMI:
> + case FSL_USB2_PHY_UTMI_DUAL:
> if (pdata->have_sysif_regs && pdata->controller_ver) {
> /* controller version 1.6 or above */
> setbits32(non_ehci + FSL_SOC_USB_CTRL, UTMI_PHY_EN);
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
> index 7e325e9..ed39081 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -69,6 +69,8 @@ static enum fsl_usb2_phy_modes determine_usb_phy(const char *phy_type)
> return FSL_USB2_PHY_UTMI;
> if (!strcasecmp(phy_type, "utmi_wide"))
> return FSL_USB2_PHY_UTMI_WIDE;
> + if (!strcasecmp(phy_type, "utmi_dual"))
> + return FSL_USB2_PHY_UTMI_DUAL;
> if (!strcasecmp(phy_type, "serial"))
> return FSL_USB2_PHY_SERIAL;
>
> diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h
> index a82296a..dd73fad 100644
> --- a/include/linux/fsl_devices.h
> +++ b/include/linux/fsl_devices.h
> @@ -64,6 +64,7 @@ enum fsl_usb2_phy_modes {
> FSL_USB2_PHY_UTMI,
> FSL_USB2_PHY_UTMI_WIDE,
> FSL_USB2_PHY_SERIAL,
> + FSL_USB2_PHY_UTMI_DUAL,
> };
>
Don't you need to order these patches properly so that they are applied
in the correct way? Please send these as a numbered series.
Also, please cc: the linux-usb mailing list, use
scripts/get_maintainer.pl for getting the correct people and mailing
lists.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-25 16:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-25 9:27 [PATCH] drivers:usb:fsl: Introduce FSL_USB2_PHY_UTMI_DUAL macro Nikhil Badola
2015-05-25 16:27 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).