* [PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings
@ 2015-05-26 21:47 Gaston Gonzalez
2015-05-31 1:45 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Gaston Gonzalez @ 2015-05-26 21:47 UTC (permalink / raw)
To: gregkh, cristina.opriceana, hamohammed.sa, gdonald,
mahfouz.saif.elyazal, paul.gortmaker
Cc: devel, linux-kernel, gascoar
Fix the following sparse warnings:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: expected restricted __le16 [usertype] frame_ctl
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: got int
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50: warning: invalid assignment: |=
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50: left side has type restricted __le16
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50: right side has type int
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d2e8b12..0477ba1 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -660,2 +660,2 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *be
auth = (struct ieee80211_authentication *)
skb_put(skb, sizeof(struct ieee80211_authentication));
- auth->header.frame_ctl = IEEE80211_STYPE_AUTH;
- if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP;
+ auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH);
+ if (challengelen)
+ auth->header.frame_ctl |= cpu_to_le16(IEEE80211_FCTL_WEP);
auth->header.duration_id = 0x013a; //FIXME
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings
2015-05-26 21:47 [PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings Gaston Gonzalez
@ 2015-05-31 1:45 ` Greg KH
2015-05-31 15:29 ` Gaston Gonzalez
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2015-05-31 1:45 UTC (permalink / raw)
To: Gaston Gonzalez
Cc: cristina.opriceana, hamohammed.sa, gdonald, mahfouz.saif.elyazal,
paul.gortmaker, devel, linux-kernel
On Tue, May 26, 2015 at 06:47:14PM -0300, Gaston Gonzalez wrote:
> Fix the following sparse warnings:
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning: incorrect type in assignment (different base types)
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: expected restricted __le16 [usertype] frame_ctl
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: got int
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50: warning: invalid assignment: |=
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50: left side has type restricted __le16
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50: right side has type int
>
>
> Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> index d2e8b12..0477ba1 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> @@ -660,2 +660,2 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *be
> auth = (struct ieee80211_authentication *)
> skb_put(skb, sizeof(struct ieee80211_authentication));
>
> - auth->header.frame_ctl = IEEE80211_STYPE_AUTH;
> - if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP;
> + auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH);
> + if (challengelen)
> + auth->header.frame_ctl |= cpu_to_le16(IEEE80211_FCTL_WEP);
>
> auth->header.duration_id = 0x013a; //FIXME
>
This patch doesn't apply properly for some reason, can you fix it up and
resend?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings
2015-05-31 1:45 ` Greg KH
@ 2015-05-31 15:29 ` Gaston Gonzalez
0 siblings, 0 replies; 3+ messages in thread
From: Gaston Gonzalez @ 2015-05-31 15:29 UTC (permalink / raw)
To: Greg KH
Cc: cristina.opriceana, hamohammed.sa, gdonald, mahfouz.saif.elyazal,
paul.gortmaker, devel, linux-kernel
On Sun, May 31, 2015 at 10:45:27AM +0900, Greg KH wrote:
> On Tue, May 26, 2015 at 06:47:14PM -0300, Gaston Gonzalez wrote:
> > Fix the following sparse warnings:
> >
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning: incorrect type in assignment (different base types)
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: expected restricted __le16 [usertype] frame_ctl
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: got int
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50: warning: invalid assignment: |=
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50: left side has type restricted __le16
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50: right side has type int
> >
> >
> > Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
> > ---
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> > index d2e8b12..0477ba1 100644
> > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> > @@ -660,2 +660,2 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *be
> > auth = (struct ieee80211_authentication *)
> > skb_put(skb, sizeof(struct ieee80211_authentication));
> >
> > - auth->header.frame_ctl = IEEE80211_STYPE_AUTH;
> > - if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP;
> > + auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH);
> > + if (challengelen)
> > + auth->header.frame_ctl |= cpu_to_le16(IEEE80211_FCTL_WEP);
> >
> > auth->header.duration_id = 0x013a; //FIXME
> >
>
> This patch doesn't apply properly for some reason, can you fix it up and
> resend?
>
> thanks,
>
> greg k-h
Hi Greg,
I couldn't find the problem with this patch. Just in case I redo the patch
against the updated staging-testing and resent it. To test it I did:
- run checkpatch
- git apply --check
- email it to myself and then 'git am' from mutt
- git log
I've just sent the patch. Please let me know if I missed something.
Thanks,
Gaston
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-31 15:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-26 21:47 [PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings Gaston Gonzalez
2015-05-31 1:45 ` Greg KH
2015-05-31 15:29 ` Gaston Gonzalez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).