[PATCH] netevent: remove automatic variable in register_netevent_notifier()

[PATCH] netevent: remove automatic variable in register_netevent_notifier()

[Wang Long]

Remove automatic variable 'err' in register_netevent_notifier() and
return the return value of atomic_notifier_chain_register() directly.

Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
 net/core/netevent.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/core/netevent.c b/net/core/netevent.c
index f17ccd2..8b3bc4f 100644
--- a/net/core/netevent.c
+++ b/net/core/netevent.c
@@ -31,10 +31,7 @@ static ATOMIC_NOTIFIER_HEAD(netevent_notif_chain);
  */
 int register_netevent_notifier(struct notifier_block *nb)
 {
-	int err;
-
-	err = atomic_notifier_chain_register(&netevent_notif_chain, nb);
-	return err;
+	return atomic_notifier_chain_register(&netevent_notif_chain, nb);
 }
 EXPORT_SYMBOL_GPL(register_netevent_notifier);
 
-- 
1.8.3.4

Re: [PATCH] netevent: remove automatic variable in register_netevent_notifier()

[Sergei Shtylyov]

Hello.

On 5/28/2015 1:00 PM, Wang Long wrote:

> Remove automatic variable 'err' in register_netevent_notifier() and
> return the return value of atomic_notifier_chain_register() directly.

    s/return value/result/, in order to avoid tautology.

> Signed-off-by: Wang Long <long.wanglong@huawei.com>
[...]

WBR, Sergei

Re: [PATCH] netevent: remove automatic variable in register_netevent_notifier()

[long.wanglong]

On 2015/5/28 22:07, Sergei Shtylyov wrote:
> Hello.
> 
> On 5/28/2015 1:00 PM, Wang Long wrote:
> 
>> Remove automatic variable 'err' in register_netevent_notifier() and
>> return the return value of atomic_notifier_chain_register() directly.
> 
>    s/return value/result/, in order to avoid tautology.
> 
>> Signed-off-by: Wang Long <long.wanglong@huawei.com>
> [...]
> 
> WBR, Sergei
> 
> 
> 

Thanks, I will fix that.

Best Regards
Wang Long