linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel@vger.kernel.org, adrian.hunter@intel.com,
	x86@kernel.org, hpa@zytor.com, acme@infradead.org,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [PATCH 0/2] perf/x86/intel: Fixes for PT and BTS
Date: Thu, 11 Jun 2015 15:13:55 +0300	[thread overview]
Message-ID: <1434024837-9916-1-git-send-email-alexander.shishkin@linux.intel.com> (raw)

Hi Peter and Ingo,

I have here two fixes for 4.1, both of which are basically results
of not testing code properly with the NMI watchdog disabled, so one
lesson learned here.

One bug results in trace data loss and unknown NMI warnings and the
other one is a NULL pointer dereference. The latter might need to be
revisited in the future as we're now handling PT PMIs from
intel_pmu_handle_irq() and we might want to change that. On the other
hand, PT and x86_pmu share the PMI status register, so from that angle
it kind of makes sense. But until such time as we decide to sort it
out, the proposed fix should do nicely.

Alexander Shishkin (2):
  perf/x86/intel/bts: Fix DS area sharing with x86_pmu events
  perf/x86/intel: Fix PMI handling for Intel PT

 arch/x86/kernel/cpu/perf_event.c           | 70 +++++++++++++++++++++---------
 arch/x86/kernel/cpu/perf_event.h           |  4 ++
 arch/x86/kernel/cpu/perf_event_intel_bts.c |  9 ++++
 3 files changed, 63 insertions(+), 20 deletions(-)

-- 
2.1.4


             reply	other threads:[~2015-06-11 12:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 12:13 Alexander Shishkin [this message]
2015-06-11 12:13 ` [PATCH 1/2] perf/x86/intel/bts: Fix DS area sharing with x86_pmu events Alexander Shishkin
2015-06-19 17:58   ` [tip:perf/urgent] " tip-bot for Alexander Shishkin
2015-06-11 12:13 ` [PATCH 2/2] perf/x86/intel: Fix PMI handling for Intel PT Alexander Shishkin
2015-06-11 14:00   ` Peter Zijlstra
2015-06-12  9:08     ` Alexander Shishkin
2015-06-12 13:09       ` Peter Zijlstra
2015-06-19 17:58       ` [tip:perf/urgent] " tip-bot for Alexander Shishkin
2015-06-24 12:21         ` Peter Zijlstra
2015-06-24 13:16         ` Peter Zijlstra
2015-06-24 14:47           ` Peter Zijlstra
2015-07-01  6:57             ` [tip:perf/urgent] perf/x86: Fix 'active_events' imbalance tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434024837-9916-1-git-send-email-alexander.shishkin@linux.intel.com \
    --to=alexander.shishkin@linux.intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=adrian.hunter@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).