[PATCH] ftrace: add tracing_thresh to function profile

[PATCH] ftrace: add tracing_thresh to function profile

[Umesh Tiwari]

From: Himanshu Maithani <himanshu.m@samsung.com>

This patch extends tracing_thresh functionality to function profile tracer.
If tracing_thresh is set, print those entries only,
whose average is > tracing thresh.

Signed-off-by: Umesh Tiwari <umesh.t@samsung.com>
---
 kernel/trace/ftrace.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 4f22802..7a48a67 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -600,13 +600,19 @@ static int function_stat_show(struct seq_file *m, void *v)
 		goto out;
 	}
 
+	/* moved above to avoid printing values < thresh */
+#ifdef CONFIG_FUNCTION_GRAPH_TRACER
+	avg = rec->time;
+	do_div(avg, rec->counter);
+	if (tracing_thresh && (avg < tracing_thresh))
+		goto out;
+#endif
+
 	kallsyms_lookup(rec->ip, NULL, NULL, NULL, str);
 	seq_printf(m, "  %-30.30s  %10lu", str, rec->counter);
 
 #ifdef CONFIG_FUNCTION_GRAPH_TRACER
 	seq_puts(m, "    ");
-	avg = rec->time;
-	do_div(avg, rec->counter);
 
 	/* Sample standard deviation (s^2) */
 	if (rec->counter <= 1)
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ftrace: add tracing_thresh to function profile

[Steven Rostedt]

On Mon, 22 Jun 2015 16:58:08 +0530
Umesh Tiwari <umesh.t@samsung.com> wrote:

> From: Himanshu Maithani <himanshu.m@samsung.com>
> 
> This patch extends tracing_thresh functionality to function profile tracer.
> If tracing_thresh is set, print those entries only,
> whose average is > tracing thresh.
> 

This should also have a Signed-off-by from Himanshu Miathani. If
possible.

-- Steve

> Signed-off-by: Umesh Tiwari <umesh.t@samsung.com>
> ---
>  kernel/trace/ftrace.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 4f22802..7a48a67 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -600,13 +600,19 @@ static int function_stat_show(struct seq_file *m, void *v)
>  		goto out;
>  	}
>  
> +	/* moved above to avoid printing values < thresh */
> +#ifdef CONFIG_FUNCTION_GRAPH_TRACER
> +	avg = rec->time;
> +	do_div(avg, rec->counter);
> +	if (tracing_thresh && (avg < tracing_thresh))
> +		goto out;
> +#endif
> +
>  	kallsyms_lookup(rec->ip, NULL, NULL, NULL, str);
>  	seq_printf(m, "  %-30.30s  %10lu", str, rec->counter);
>  
>  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
>  	seq_puts(m, "    ");
> -	avg = rec->time;
> -	do_div(avg, rec->counter);
>  
>  	/* Sample standard deviation (s^2) */
>  	if (rec->counter <= 1)

Re: [PATCH] ftrace: add tracing_thresh to function profile

[Steven Rostedt]

On Mon, 22 Jun 2015 16:58:08 +0530
Umesh Tiwari <umesh.t@samsung.com> wrote:

> From: Himanshu Maithani <himanshu.m@samsung.com>
> 
> This patch extends tracing_thresh functionality to function profile tracer.
> If tracing_thresh is set, print those entries only,
> whose average is > tracing thresh.
> 
> Signed-off-by: Umesh Tiwari <umesh.t@samsung.com>
> ---
>  kernel/trace/ftrace.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 4f22802..7a48a67 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -600,13 +600,19 @@ static int function_stat_show(struct seq_file *m, void *v)
>  		goto out;
>  	}
>  
> +	/* moved above to avoid printing values < thresh */

This comment isn't needed. People looking at this code wont know that
it use to be below.

-- Steve

> +#ifdef CONFIG_FUNCTION_GRAPH_TRACER
> +	avg = rec->time;
> +	do_div(avg, rec->counter);
> +	if (tracing_thresh && (avg < tracing_thresh))
> +		goto out;
> +#endif
> +
>  	kallsyms_lookup(rec->ip, NULL, NULL, NULL, str);
>  	seq_printf(m, "  %-30.30s  %10lu", str, rec->counter);
>  
>  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
>  	seq_puts(m, "    ");
> -	avg = rec->time;
> -	do_div(avg, rec->counter);
>  
>  	/* Sample standard deviation (s^2) */
>  	if (rec->counter <= 1)