From: Heiko Stuebner <heiko@sntech.de>
To: 温暖 <leo.wen@rock-chips.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
David Wu <david.wu@rock-chips.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Greg KH <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
"jacob2.chen@rock-chips.com" <jacob2.chen@rock-chips.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Eddie Cai <eddie.cai@rock-chips.com>
Subject: Re: [PATCH V2 1/2] [media] Add Rockchip RK1608 driver
Date: Tue, 27 Feb 2018 16:12:04 +0100 [thread overview]
Message-ID: <14366388.KYv6Y7EbEA@phil> (raw)
In-Reply-To: <06296C1C-0ACB-4BB2-86DF-EBDBE3265DA4@rock-chips.com>
Hi Leo,
Am Dienstag, 27. Februar 2018, 04:15:46 CET schrieb 温暖:
> Thank you for your advice! I will revise it according to your suggestion.
please also keep an eye on my reply to Linus' mail pointing out some
other issues where the driver should not tie into soc-specific areas
like the clock controller etc.
Thanks
Heiko
Am Dienstag, 27. Februar 2018, 04:15:46 CET schrieb 温暖:
> On 2/26/2018 18:12,Linus Walleij<linus.walleij@linaro.org> wrote:
> On Mon, Feb 26, 2018 at 9:16 AM, Wen Nuan <leo.wen@rock-chips.com> wrote:
> + pdata->grf_gpio2b_iomux = ioremap((resource_size_t)
> + (GRF_BASE_ADDR +
> + GRF_GPIO2B_IOMUX), 4);
> + grf_val = __raw_readl(pdata->grf_gpio2b_iomux);
> + __raw_writel(((grf_val) | (1 << 6) | (1 << (6 + 16))),
> + pdata->grf_gpio2b_iomux);
> +
> + pdata->grf_io_vsel = ioremap((resource_size_t)
> + (GRF_BASE_ADDR + GRF_IO_VSEL), 4);
> + grf_val = __raw_readl(pdata->grf_io_vsel);
> + __raw_writel(((grf_val) | (1 << 1) | (1 << (1 + 16))),
> + pdata->grf_io_vsel);
>
> You are doing pin control on the side of the pin control subsystem
> it looks like?
>
> I think David Wu and Heiko Stubner needs to have a look at what you
> are doing here to suggest other solutions.
>
> Apart from that, why use __raw_writel instead of just writel()?
>
> This pin is iomux, default GPIO, need to be changed to CLK.
> This CLK is provided to external sensor for use.
> I'll use writel().
As stated, please don't directly access soc blocks like the clock
controller or iomuxes, there are standard APIs like the general
clock API and also assigned-clock* devicetree properties.
Similarly for pinctrl access.
So there should not be any writel (or ioremap) at all in this spi driver
I'd think.
Thanks
Heiko
next prev parent reply other threads:[~2018-02-27 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 8:16 [PATCH V2 0/2] Rockchip: Add RK1608 driver and DT-bindings Wen Nuan
2018-02-26 8:16 ` [PATCH V2 1/2] [media] Add Rockchip RK1608 driver Wen Nuan
2018-02-26 9:50 ` Hans Verkuil
2018-02-26 10:12 ` Linus Walleij
2018-02-26 15:15 ` Heiko Stuebner
2018-02-27 3:15 ` 温暖
2018-02-27 15:12 ` Heiko Stuebner [this message]
2018-02-28 1:23 ` 回复: " 温暖
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14366388.KYv6Y7EbEA@phil \
--to=heiko@sntech.de \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=eddie.cai@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacob2.chen@rock-chips.com \
--cc=leo.wen@rock-chips.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).