* [PATCH V2 0/2] Rockchip: Add RK1608 driver and DT-bindings @ 2018-02-26 8:16 Wen Nuan 2018-02-26 8:16 ` [PATCH V2 1/2] [media] Add Rockchip RK1608 driver Wen Nuan 0 siblings, 1 reply; 8+ messages in thread From: Wen Nuan @ 2018-02-26 8:16 UTC (permalink / raw) To: mchehab, davem, gregkh, linus.walleij, rdunlap, jacob2.chen Cc: linux-kernel, linux-media, eddie.cai, Leo Wen From: Leo Wen <leo.wen@rock-chips.com> You can use the v4l2-ctl command to capture frames for RK1608. Add DT-bindings documentation for Rockchip RK1608. Add the information of the MAINTAINERS. Leo Wen (2): [media] Add Rockchip RK1608 driver dt-bindings: Document the Rockchip RK1608 bindings Documentation/devicetree/bindings/media/rk1608.txt | 97 ++ MAINTAINERS | 7 + drivers/media/spi/Makefile | 1 + drivers/media/spi/rk1608.c | 1664 ++++++++++++++++++++ drivers/media/spi/rk1608.h | 471 ++++++ 5 files changed, 2240 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/rk1608.txt create mode 100644 drivers/media/spi/rk1608.c create mode 100644 drivers/media/spi/rk1608.h -- 2.7.4 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2 1/2] [media] Add Rockchip RK1608 driver 2018-02-26 8:16 [PATCH V2 0/2] Rockchip: Add RK1608 driver and DT-bindings Wen Nuan @ 2018-02-26 8:16 ` Wen Nuan 2018-02-26 9:50 ` Hans Verkuil 2018-02-26 10:12 ` Linus Walleij 0 siblings, 2 replies; 8+ messages in thread From: Wen Nuan @ 2018-02-26 8:16 UTC (permalink / raw) To: mchehab, davem, gregkh, linus.walleij, rdunlap, jacob2.chen Cc: linux-kernel, linux-media, eddie.cai, Leo Wen From: Leo Wen <leo.wen@rock-chips.com> Rk1608 is used as a PreISP to link on Soc, which mainly has two functions. One is to download the firmware of RK1608, and the other is to match the extra sensor such as camera and enable sensor by calling sensor's s_power. use below v4l2-ctl command to capture frames. v4l2-ctl --verbose -d /dev/video1 --stream-mmap=2 --stream-to=/tmp/stream.out --stream-count=60 --stream-poll use below command to playback the video on your PC. mplayer ./stream.out -loop 0 -demuxer rawvideo -rawvideo w=640:h=480:size=$((640*480*3/2)):format=NV12 Changes V2: - Delete long legalese. - Add the new SPDX tags. - Dual cameras can be captured at the same time. - Add some pins and clock control for external sensors. - Add a function, the Soc can send control MSG to RK1608. Signed-off-by: Leo Wen <leo.wen@rock-chips.com> --- MAINTAINERS | 6 + drivers/media/spi/Makefile | 1 + drivers/media/spi/rk1608.c | 1664 ++++++++++++++++++++++++++++++++++++++++++++ drivers/media/spi/rk1608.h | 471 +++++++++++++ 4 files changed, 2142 insertions(+) create mode 100644 drivers/media/spi/rk1608.c create mode 100644 drivers/media/spi/rk1608.h diff --git a/MAINTAINERS b/MAINTAINERS index 93a12af..b2a98e3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -136,6 +136,12 @@ Maintainers List (try to look for most precise areas first) ----------------------------------- +ROCKCHIP RK1608 DRIVER +M: Leo Wen <leo.wen@rock-chips.com> +S: Maintained +F: drivers/media/spi/rk1608.c +F: drivers/media/spi/rk1608.h + 3C59X NETWORK DRIVER M: Steffen Klassert <klassert@mathematik.tu-chemnitz.de> L: netdev@vger.kernel.org diff --git a/drivers/media/spi/Makefile b/drivers/media/spi/Makefile index ea64013..9d9d9ec 100644 --- a/drivers/media/spi/Makefile +++ b/drivers/media/spi/Makefile @@ -1 +1,2 @@ obj-$(CONFIG_VIDEO_GS1662) += gs1662.o +obj-$(CONFIG_ROCKCHIP_RK1608) += rk1608.o diff --git a/drivers/media/spi/rk1608.c b/drivers/media/spi/rk1608.c new file mode 100644 index 0000000..c229b30 --- /dev/null +++ b/drivers/media/spi/rk1608.c @@ -0,0 +1,1664 @@ +// SPDX-License-Identifier: GPL-2.0 +/** + * Rockchip rk1608 driver + * + * Copyright (C) 2017 Rockchip Electronics Co., Ltd. + * + */ + +#include <linux/delay.h> +#include <linux/firmware.h> +#include <linux/interrupt.h> +#include <linux/of_platform.h> +#include <linux/of_gpio.h> +#include <media/v4l2-ctrls.h> +#include <media/v4l2-subdev.h> +#include <media/v4l2-device.h> +#include <media/v4l2-fwnode.h> +#include <media/v4l2-image-sizes.h> +#include <media/v4l2-mediabus.h> +#include <media/v4l2-of.h> +#include "rk1608.h" + +/** + * Rk1608 is used as the Pre-ISP to link on Soc, which mainly has two + * functions. One is to download the firmware of RK1608, and the other + * is to match the extra sensor such as camera and enable sensor by + * calling sensor's s_power. + * |-----------------------| + * | Sensor Camera | + * |-----------------------| + * |-----------||----------| + * |-----------||----------| + * |-----------\/----------| + * | Pre-ISP RK1608 | + * |-----------------------| + * |-----------||----------| + * |-----------||----------| + * |-----------\/----------| + * | Rockchip Soc | + * |-----------------------| + * Data Transfer As shown above. In RK1608, the data received from the + * extra sensor,and it is passed to the Soc through ISP. + */ + +static inline struct rk1608_state *to_state(struct v4l2_subdev *sd) +{ + return container_of(sd, struct rk1608_state, sd); +} + +/** + * rk1608_operation_query - RK1608 last operation state query + * + * @spi: device from which data will be read + * @state: last operation state [out] + * Context: can sleep + * + * It returns zero on success, else a negative error code. + */ +int rk1608_operation_query(struct spi_device *spi, s32 *state) +{ + s32 query_cmd = RK1608_CMD_QUERY; + struct spi_transfer query_cmd_packet = { + .tx_buf = &query_cmd, + .len = sizeof(query_cmd), + }; + struct spi_transfer state_packet = { + .rx_buf = state, + .len = sizeof(*state), + }; + struct spi_message m; + + spi_message_init(&m); + spi_message_add_tail(&query_cmd_packet, &m); + spi_message_add_tail(&state_packet, &m); + spi_sync(spi, &m); + + return ((*state & RK1608_STATE_ID_MASK) == RK1608_STATE_ID) ? 0 : -1; +} + +int rk1608_write(struct spi_device *spi, + s32 addr, const s32 *data, size_t data_len) +{ + s32 write_cmd = RK1608_CMD_WRITE; + struct spi_transfer write_cmd_packet = { + .tx_buf = &write_cmd, + .len = sizeof(write_cmd), + }; + struct spi_transfer addr_packet = { + .tx_buf = &addr, + .len = sizeof(addr), + }; + struct spi_transfer data_packet = { + .tx_buf = data, + .len = data_len, + }; + struct spi_message m; + + spi_message_init(&m); + spi_message_add_tail(&write_cmd_packet, &m); + spi_message_add_tail(&addr_packet, &m); + spi_message_add_tail(&data_packet, &m); + return spi_sync(spi, &m); +} + +/** + * rk1608_safe_write - RK1608 synchronous write with state check + * + * @spi: spi device + * @addr: resource address + * @data: data buffer + * @data_len: data buffer size, in bytes + * Context: can sleep + * + * It returns zero on success, else operation state code. + */ +int rk1608_safe_write(struct spi_device *spi, + s32 addr, const s32 *data, size_t data_len) +{ + int ret = 0; + s32 state, retry = 0; + + while (data_len > 0) { + size_t slen = MIN(data_len, RK1608_MAX_OP_BYTES); + + do { + rk1608_write(spi, addr, data, data_len); + if (rk1608_operation_query(spi, &state) != 0) + return -1; + if ((state & RK1608_STATE_MASK) == 0) + break; + + udelay(RK1608_OP_TRY_DELAY); + } while (retry++ != RK1608_OP_TRY_MAX); + + data_len = data_len - slen; + data = (s32 *)((s8 *)data + slen); + addr += slen; + } + return ret; +} + +void rk1608_hw_init(struct spi_device *spi) +{ + s32 write_data = SPI0_PLL_SEL_APLL; + + /* modify rk1608 spi slave clk to 300M */ + rk1608_safe_write(spi, CRUPMU_CLKSEL14_CON, &write_data, 4); + + /* modify rk1608 spi io driver strength to 8mA */ + write_data = BIT7_6_SEL_8MA; + rk1608_safe_write(spi, PMUGRF_GPIO1A_E, &write_data, 4); + write_data = BIT1_0_SEL_8MA; + rk1608_safe_write(spi, PMUGRF_GPIO1B_E, &write_data, 4); +} + +/** + * rk1608_read - RK1608 synchronous read + * + * @spi: spi device + * @addr: resource address + * @data: data buffer [out] + * @data_len: data buffer size, in bytes + * Context: can sleep + * + * It returns zero on success, else a negative error code. + */ +int rk1608_read(struct spi_device *spi, + s32 addr, s32 *data, size_t data_len) +{ + s32 real_len = MIN(data_len, RK1608_MAX_OP_BYTES); + s32 read_cmd = RK1608_CMD_READ | (real_len << 14 & + RK1608_STATE_ID_MASK); + s32 read_begin_cmd = RK1608_CMD_READ_BEGIN; + s32 dummy = 0; + struct spi_transfer read_cmd_packet = { + .tx_buf = &read_cmd, + .len = sizeof(read_cmd), + }; + struct spi_transfer addr_packet = { + .tx_buf = &addr, + .len = sizeof(addr), + }; + struct spi_transfer read_dummy_packet = { + .tx_buf = &dummy, + .len = sizeof(dummy), + }; + struct spi_transfer read_begin_cmd_packet = { + .tx_buf = &read_begin_cmd, + .len = sizeof(read_begin_cmd), + }; + struct spi_transfer data_packet = { + .rx_buf = data, + .len = data_len, + }; + struct spi_message m; + + spi_message_init(&m); + spi_message_add_tail(&read_cmd_packet, &m); + spi_message_add_tail(&addr_packet, &m); + spi_message_add_tail(&read_dummy_packet, &m); + spi_message_add_tail(&read_begin_cmd_packet, &m); + spi_message_add_tail(&data_packet, &m); + return spi_sync(spi, &m); +} + +/** + * rk1608_safe_read - RK1608 synchronous read with state check + * + * @spi: spi device + * @addr: resource address + * @data: data buffer [out] + * @data_len: data buffer size, in bytes + * Context: can sleep + * + * It returns zero on success, else operation state code. + */ +int rk1608_safe_read(struct spi_device *spi, + s32 addr, s32 *data, size_t data_len) +{ + s32 state = 0; + s32 retry = 0; + + do { + rk1608_read(spi, addr, data, data_len); + if (rk1608_operation_query(spi, &state) != 0) + return -1; + if ((state & RK1608_STATE_MASK) == 0) + break; + udelay(RK1608_OP_TRY_DELAY); + } while (retry++ != RK1608_OP_TRY_MAX); + + return (state & RK1608_STATE_MASK); +} + +static int rk1608_read_wait(struct spi_device *spi, + const struct rk1608_section *sec) +{ + s32 value = 0; + int retry = 0; + int ret = 0; + + do { + ret = rk1608_safe_read(spi, sec->wait_addr, &value, 4); + if (!ret && value == sec->wait_value) + break; + + if (retry++ == sec->timeout) { + ret = -1; + dev_err(&spi->dev, "read 0x%x is %x != %x timeout\n", + sec->wait_addr, value, sec->wait_value); + break; + } + mdelay(sec->wait_time); + } while (1); + + return ret; +} + +static int rk1608_boot_request(struct spi_device *spi, + const struct rk1608_section *sec) +{ + struct rk1608_boot_req boot_req; + int retry = 0; + int ret = 0; + + /*send boot request to rk1608 for ddr init*/ + boot_req.flag = sec->flag; + boot_req.load_addr = sec->load_addr; + boot_req.boot_len = sec->size; + boot_req.status = 1; + boot_req.cmd = 2; + + ret = rk1608_safe_write(spi, BOOT_REQUEST_ADDR, + (s32 *)&boot_req, sizeof(boot_req)); + if (ret) + return ret; + + if (sec->flag & BOOT_FLAG_READ_WAIT) { + /*waitting for rk1608 init ddr done*/ + do { + ret = rk1608_safe_read(spi, BOOT_REQUEST_ADDR, + (s32 *)&boot_req, + sizeof(boot_req)); + + if (!ret && boot_req.status == 0) + break; + + if (retry++ == sec->timeout) { + ret = -1; + dev_err(&spi->dev, "boot_request timeout\n"); + break; + } + mdelay(sec->wait_time); + } while (1); + } + + return ret; +} + +static int rk1608_download_section(struct spi_device *spi, const u8 *data, + const struct rk1608_section *sec) +{ + int ret = 0; + + dev_info(&spi->dev, "offset:%x,size:%x,addr:%x,wait_time:%x", + sec->offset, sec->size, sec->load_addr, sec->wait_time); + dev_info(&spi->dev, "timeout:%x,crc:%x,flag:%x,type:%x", + sec->timeout, sec->crc_16, sec->flag, sec->type); + + if (sec->size > 0) { + ret = rk1608_safe_write(spi, sec->load_addr, + (s32 *)(data + sec->offset), + sec->size); + if (ret) { + dev_err(&spi->dev, "rk1608_safe_write err =%d\n", ret); + return ret; + } + } + + if (sec->flag & BOOT_FLAG_BOOT_REQUEST) + ret = rk1608_boot_request(spi, sec); + else if (sec->flag & BOOT_FLAG_READ_WAIT) + ret = rk1608_read_wait(spi, sec); + + return ret; +} + +/** + * rk1608_download_fw: - rk1608 firmware download through spi + * + * @spi: spi device + * @fw_name: name of firmware file, NULL for default firmware name + * Context: can sleep + * + * It returns zero on success, else a negative error code. + **/ +int rk1608_download_fw(struct spi_device *spi, const char *fw_name) +{ + const struct rk1608_header *head; + const struct firmware *fw; + int i = 0; + int ret = 0; + + if (!fw_name) + fw_name = RK1608_FW_NAME; + + dev_info(&spi->dev, "before request firmware"); + ret = request_firmware(&fw, fw_name, &spi->dev); + if (ret) { + dev_err(&spi->dev, "request firmware %s failed!", fw_name); + return ret; + } + + head = (const struct rk1608_header *)fw->data; + + dev_info(&spi->dev, "request firmware %s (version:%s) success!", + fw_name, head->version); + + for (i = 0; i < head->section_count; i++) { + ret = rk1608_download_section(spi, fw->data, + &head->sections[i]); + if (ret) + break; + } + + release_firmware(fw); + return ret; +} + +int rk1608_lsb_w32(struct spi_device *spi, s32 addr, s32 data) +{ + s32 write_cmd = RK1608_CMD_WRITE; + struct spi_transfer write_cmd_packet = { + .tx_buf = &write_cmd, + .len = sizeof(write_cmd), + }; + struct spi_transfer addr_packet = { + .tx_buf = &addr, + .len = sizeof(addr), + }; + struct spi_transfer data_packet = { + .tx_buf = &data, + .len = sizeof(data), + }; + struct spi_message m; + + write_cmd = MSB2LSB32(write_cmd); + addr = MSB2LSB32(addr); + data = MSB2LSB32(data); + spi_message_init(&m); + spi_message_add_tail(&write_cmd_packet, &m); + spi_message_add_tail(&addr_packet, &m); + spi_message_add_tail(&data_packet, &m); + return spi_sync(spi, &m); +} + +int rk1608_msg_init_sensor(struct rk1608_state *pdata, int id) +{ + struct msg_init *msg; + + msg = (struct msg_init *)devm_kzalloc(pdata->dev, + sizeof(struct msg_init), + GFP_KERNEL); + if (!msg) + return -ENOMEM; + msg->size = sizeof(struct msg_init); + msg->type = id_msg_init_sensor_t; + msg->camera_id = pdata->cd[id]->ci.cam_id; + msg->sync = 1; + msg->in_mipi_phy = pdata->cd[id]->ci.in_mipi; + msg->out_mipi_phy = pdata->cd[id]->ci.out_mipi; + msg->mipi_lane = pdata->cd[id]->ci.mipi_lane; + msg->bayer = 0; + memcpy((void *)msg->sensor_name, pdata->cd[id]->sd.name, 32); + + msg->i2c_slave_addr = (pdata->cd[id]->client->addr) << 1; + msg->i2c_bus = pdata->cd[id]->ci.i2c_bus; + + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); +} + +int rk1608_msg_set_input_size(struct rk1608_state *pdata, int id) +{ + struct msg_in_size *msg; + + msg = (struct msg_in_size *)devm_kzalloc(pdata->dev, + sizeof(struct msg_in_size), + GFP_KERNEL); + if (!msg) + return -ENOMEM; + msg->msg_head.size = sizeof(struct msg_in_size) / sizeof(int); + msg->msg_head.type = id_msg_set_input_size_t; + msg->msg_head.id.camera_id = pdata->cd[id]->ci.cam_id; + msg->msg_head.mux.sync = 1; + msg->channel.data_type = pdata->cd[id]->ci.data_type; + msg->channel.decode_format = pdata->cd[id]->ci.data_type; + msg->channel.width = pdata->cd[id]->ci.width; + msg->channel.height = pdata->cd[id]->ci.height; + msg->channel.flag = 1; + + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); +} + +int rk1608_msg_set_output_size(struct rk1608_state *pdata, int id) +{ + struct msg_out_size *msg; + + msg = (struct msg_out_size *)devm_kzalloc(pdata->dev, + sizeof(struct msg_out_size), + GFP_KERNEL); + if (!msg) + return -ENOMEM; + msg->size = sizeof(struct msg_out_size); + msg->type = id_msg_set_output_size_t; + msg->camera_id = pdata->cd[id]->ci.cam_id; + msg->sync = 1; + msg->width = pdata->cd[id]->ci.width; + msg->height = pdata->cd[id]->ci.height; + msg->mipi_clk = pdata->cd[id]->ci.mipi_clock; + msg->line_length_pclk = pdata->cd[id]->ci.htotal; + msg->frame_length_lines = pdata->cd[id]->ci.vtotal; + + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); +} + +int rk1608_msg_set_stream_in_on(struct rk1608_state *pdata, int id) +{ + struct msg_t *msg; + + msg = (struct msg_t *)devm_kzalloc(pdata->dev, sizeof(struct msg_t), + GFP_KERNEL); + if (!msg) + return -ENOMEM; + msg->size = sizeof(struct msg_t); + msg->type = id_msg_set_stream_in_on_t; + msg->id.camera_id = pdata->cd[id]->ci.cam_id; + msg->mux.sync = 1; + + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); +} + +int rk1608_msg_set_stream_in_off(struct rk1608_state *pdata, int id) +{ + struct msg_t *msg; + + msg = (struct msg_t *)devm_kzalloc(pdata->dev, sizeof(struct msg_t), + GFP_KERNEL); + if (!msg) + return -ENOMEM; + msg->size = sizeof(struct msg_t); + msg->type = id_msg_set_stream_in_off_t; + msg->id.camera_id = pdata->cd[id]->ci.cam_id; + msg->mux.sync = 1; + + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); +} + +int rk1608_msg_set_stream_out_on(struct rk1608_state *pdata, int id) +{ + struct msg_t *msg; + + msg = (struct msg_t *)devm_kzalloc(pdata->dev, sizeof(struct msg_t), + GFP_KERNEL); + if (!msg) + return -ENOMEM; + msg->size = sizeof(struct msg_t); + msg->type = id_msg_set_stream_out_on_t; + msg->id.camera_id = pdata->cd[id]->ci.cam_id; + msg->mux.sync = 1; + + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); +} + +int rk1608_msg_set_stream_out_off(struct rk1608_state *pdata, int id) +{ + struct msg_t *msg; + + msg = (struct msg_t *)devm_kzalloc(pdata->dev, sizeof(struct msg_t), + GFP_KERNEL); + if (!msg) + return -ENOMEM; + msg->size = sizeof(struct msg_t); + msg->type = id_msg_set_stream_out_off_t; + msg->id.camera_id = pdata->cd[id]->ci.cam_id; + msg->mux.sync = 1; + + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); +} + +int rk1608_set_log_level(struct rk1608_state *pdata, int level) +{ + struct msg_t *msg; + + msg = (struct msg_t *)devm_kzalloc(pdata->dev, sizeof(struct msg_t), + GFP_KERNEL); + if (!msg) + return -ENOMEM; + msg->size = sizeof(struct msg_t); + msg->type = id_msg_set_log_level_t; + msg->mux.log_level = level; + + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); +} + +int rk1608_init_sensor(struct rk1608_state *pdata, int id) +{ + int ret; + + if (!pdata->cd) { + dev_err(pdata->dev, "No find camera device!\n"); + return -1; + } + + ret = rk1608_msg_init_sensor(pdata, id); + mdelay(20); + ret |= rk1608_msg_set_input_size(pdata, id); + ret |= rk1608_msg_set_output_size(pdata, id); + ret |= rk1608_msg_set_stream_in_on(pdata, id); + mdelay(30); + ret |= rk1608_msg_set_stream_out_on(pdata, id); + + return ret; +} + +int rk1608_deinit(struct rk1608_state *pdata, int id) +{ + int ret; + + ret = rk1608_msg_set_stream_out_off(pdata, id); + mdelay(30); + ret |= rk1608_msg_set_stream_in_off(pdata, id); + + return ret; +} + +void rk1608_cs_set_value(struct rk1608_state *pdata, int value) +{ + s8 null_cmd = 0; + struct spi_transfer null_cmd_packet = { + .tx_buf = &null_cmd, + .len = sizeof(null_cmd), + .cs_change = !value, + }; + struct spi_message m; + + spi_message_init(&m); + spi_message_add_tail(&null_cmd_packet, &m); + spi_sync(pdata->spi, &m); +} + +void rk1608_set_spi_speed(struct rk1608_state *pdata, u32 hz) +{ + pdata->spi->max_speed_hz = hz; +} + +static int rk1608_pin_power(struct rk1608_state *pdata, int on) +{ + unsigned int grf_val = 0; + + if (on) { + clk_prepare_enable(pdata->pd_cif); + clk_prepare_enable(pdata->aclk_cif); + clk_prepare_enable(pdata->hclk_cif); + clk_prepare_enable(pdata->cif_clk_in); + clk_prepare_enable(pdata->cif_clk_out); + clk_prepare_enable(pdata->clk_mipi_24m); + clk_prepare_enable(pdata->hclk_mipiphy); + clk_set_rate(pdata->cif_clk_out, RK1608_MCLK_RATE); + + clk_prepare_enable(pdata->mipi_clk); + clk_set_rate(pdata->mipi_clk, RK1608_MCLK_RATE); + + gpio_direction_output(pdata->rst1, 0); + mdelay(3); + gpio_direction_output(pdata->rst1, 1); + mdelay(5); + gpio_direction_output(pdata->powerdown1, 1); + + gpio_direction_output(pdata->rst0, 0); + mdelay(3); + gpio_direction_output(pdata->rst0, 1); + mdelay(5); + gpio_direction_output(pdata->powerdown0, 1); + + pdata->grf_gpio2b_iomux = ioremap((resource_size_t) + (GRF_BASE_ADDR + + GRF_GPIO2B_IOMUX), 4); + grf_val = __raw_readl(pdata->grf_gpio2b_iomux); + __raw_writel(((grf_val) | (1 << 6) | (1 << (6 + 16))), + pdata->grf_gpio2b_iomux); + + pdata->grf_io_vsel = ioremap((resource_size_t) + (GRF_BASE_ADDR + GRF_IO_VSEL), 4); + grf_val = __raw_readl(pdata->grf_io_vsel); + __raw_writel(((grf_val) | (1 << 1) | (1 << (1 + 16))), + pdata->grf_io_vsel); + } else if (!on) { + grf_val = __raw_readl(pdata->grf_gpio2b_iomux); + grf_val |= (1 << (6 + 16)); + grf_val &= (~(1 << 6)); + __raw_writel(grf_val, pdata->grf_gpio2b_iomux); + iounmap(pdata->grf_gpio2b_iomux); + + grf_val = 0; + grf_val = __raw_readl(pdata->grf_io_vsel); + grf_val |= (1 << (1 + 16)); + grf_val &= (~(1 << 1)); + __raw_writel(grf_val, pdata->grf_io_vsel); + iounmap(pdata->grf_io_vsel); + + gpio_direction_input(pdata->rst1); + mdelay(3); + gpio_direction_input(pdata->powerdown1); + gpio_direction_input(pdata->rst0); + mdelay(5); + gpio_direction_input(pdata->powerdown0); + + clk_disable_unprepare(pdata->pd_cif); + clk_disable_unprepare(pdata->aclk_cif); + clk_disable_unprepare(pdata->hclk_cif); + clk_disable_unprepare(pdata->cif_clk_in); + clk_disable_unprepare(pdata->cif_clk_out); + clk_disable_unprepare(pdata->clk_mipi_24m); + clk_disable_unprepare(pdata->hclk_mipiphy); + clk_disable_unprepare(pdata->mipi_clk); + } + return 0; +} + +static int rk1608_sensor_power(struct v4l2_subdev *sd, int on) +{ + int ret = 0; + struct rk1608_state *pdata = to_state(sd); + struct spi_device *spi = pdata->spi; + + mutex_lock(&pdata->lock); + rk1608_pin_power(pdata, on); + /*start Sensor power on/off*/ + if (pdata->cd[0]) + pdata->cd[0]->sd.ops->core->s_power(&pdata->cd[0]->sd, on); + if (pdata->cd[1]) + pdata->cd[1]->sd.ops->core->s_power(&pdata->cd[1]->sd, on); + + if (on && !pdata->power_count) { + clk_prepare_enable(pdata->mclk); + clk_set_rate(pdata->mclk, RK1608_MCLK_RATE); + /*request rk1608 enter slave mode*/ + rk1608_cs_set_value(pdata, 0); + if (pdata->powerdown_gpio > 0) { + gpio_set_value(pdata->powerdown_gpio, + pdata->powerdown_active); + } + if (pdata->wakeup_gpio > 0) { + gpio_set_value(pdata->wakeup_gpio, + pdata->wakeup_active); + } + mdelay(3); + if (pdata->reset_gpio > 0) + gpio_set_value(pdata->reset_gpio, pdata->reset_active); + mdelay(5); + rk1608_cs_set_value(pdata, 1); + rk1608_lsb_w32(spi, SPI_ENR, 0); + rk1608_lsb_w32(spi, SPI_CTRL0, + OPM_SLAVE_MODE | RSD_SEL_2CYC | DFS_SEL_16BIT); + rk1608_hw_init(pdata->spi); + rk1608_set_spi_speed(pdata, pdata->max_speed_hz); + + /*download system firmware*/ + ret = rk1608_download_fw(pdata->spi, NULL); + + if (ret) + dev_err(pdata->dev, "Download firmware failed!"); + else + dev_info(pdata->dev, "Download firmware success!"); + + enable_irq(pdata->irq); + if (pdata->sleepst_irq > 0) + enable_irq(pdata->sleepst_irq); + + ret = rk1608_set_log_level(pdata, 2); + } else if (!on && pdata->power_count == 1) { + disable_irq(pdata->irq); + if (pdata->sleepst_irq > 0) + disable_irq(pdata->sleepst_irq); + if (pdata->powerdown_gpio > 0) + gpio_set_value(pdata->powerdown_gpio, + !pdata->powerdown_active); + + if (pdata->wakeup_gpio > 0) + gpio_set_value(pdata->wakeup_gpio, + !pdata->wakeup_active); + + if (pdata->reset_gpio > 0) + gpio_set_value(pdata->reset_gpio, !pdata->reset_active); + + rk1608_cs_set_value(pdata, 0); + clk_disable_unprepare(pdata->mclk); + } + /* Update the power count. */ + pdata->power_count += on ? 1 : -1; + WARN_ON(pdata->power_count < 0); + mutex_unlock(&pdata->lock); + + return ret; +} + +static int rk1608_stream_on(struct rk1608_state *pdata) +{ + int id, cnt, ret = 0; + + for (id = 0; id < pdata->sensor_nums; id++) { + ret = rk1608_init_sensor(pdata, id); + if (ret) + dev_err(pdata->dev, "init sensor[%d] is failed!", id); + } + /*Waiting for the sensor to be ready*/ + while (pdata->sensor_cnt < pdata->sensor_nums) { + /* TIMEOUT 10s break*/ + if (cnt++ > SENSOR_TIMEOUT) { + dev_err(pdata->dev, "Sensor%d is ready to timeout!", + pdata->sensor_cnt); + break; + } + mdelay(10); + } + + if (pdata->sensor_nums) { + if (pdata->sensor_cnt == pdata->sensor_nums) + dev_info(pdata->dev, "Sensor(num %d) is ready!", + pdata->sensor_cnt); + } else { + dev_warn(pdata->dev, "No sensor is found!"); + } + + return 0; +} + +static int rk1608_stream_off(struct rk1608_state *pdata) +{ + mutex_lock(&pdata->sensor_lock); + pdata->sensor_cnt = 0; + mutex_unlock(&pdata->sensor_lock); + if (pdata->cd[0]) + rk1608_deinit(pdata, 0); + if (pdata->cd[1]) + rk1608_deinit(pdata, 1); + return 0; +} + +static int rk1608_s_stream(struct v4l2_subdev *sd, int enable) +{ + int ret; + struct rk1608_state *pdata = to_state(sd); + + if (enable) + ret = rk1608_stream_on(pdata); + else + ret = rk1608_stream_off(pdata); + + if (pdata->cd[0]) + ret |= pdata->cd[0]->sd.ops->video->s_stream(&pdata->cd[0]->sd, + enable); + if (pdata->cd[1]) + ret |= pdata->cd[1]->sd.ops->video->s_stream(&pdata->cd[1]->sd, + enable); + return ret; +} + +static int rk1608_enum_mbus_code(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_mbus_code_enum *code) +{ + struct rk1608_state *pdata = to_state(sd); + struct camera_dev *cd = pdata->cd[0]; + + if (code->index > 0) + return -EINVAL; + + code->code = cd->ci.code; + + return 0; +} + +static int rk1608_get_fmt(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_format *fmt) +{ + struct v4l2_mbus_framefmt *mf = &fmt->format; + struct rk1608_state *pdata = to_state(sd); + struct camera_dev *cd = pdata->cd[0]; + + if (cd) { + mf->code = cd->ci.code; + mf->width = cd->ci.width; + mf->height = cd->ci.height; + mf->field = cd->ci.field; + mf->colorspace = cd->ci.colorspace; + } + + return 0; +} + +static const struct v4l2_subdev_internal_ops rk1608_subdev_internal_ops = { + .open = NULL, +}; + +static const struct v4l2_subdev_video_ops rk1608_subdev_video_ops = { + .s_stream = rk1608_s_stream, +}; + +static const struct v4l2_subdev_pad_ops rk1608_subdev_pad_ops = { + .enum_mbus_code = rk1608_enum_mbus_code, + .get_fmt = rk1608_get_fmt, +}; + +static const struct v4l2_subdev_core_ops rk1608_core_ops = { + .s_power = rk1608_sensor_power, +}; + +static const struct v4l2_subdev_ops rk1608_subdev_ops = { + .core = &rk1608_core_ops, + .video = &rk1608_subdev_video_ops, + .pad = &rk1608_subdev_pad_ops, +}; + +/** + * rk1608_msq_read_head - read rk1608 msg queue head + * + * @spi: spi device + * @addr: msg queue head addr + * @m: msg queue pointer + * + * It returns zero on success, else a negative error code. + */ +int rk1608_msq_read_head(struct spi_device *spi, + u32 addr, struct rk1608_msg_queue *q) +{ + int err = 0; + s32 reg; + + err = rk1608_safe_read(spi, RK1608_PMU_SYS_REG0, ®, 4); + + if (err || ((reg & RK1608_MSG_QUEUE_OK_MASK) != + RK1608_MSG_QUEUE_OK_TAG)) + return -1; + + err = rk1608_safe_read(spi, addr, (s32 *)q, sizeof(*q)); + + return err; +} + +/** + * rk1608_msq_recv_msg - receive a msg from RK1608 -> AP msg queue + * + * @q: msg queue + * @m: a msg pointer buf [out] + * + * need call rk1608_msq_recv_msg_free to free msg after msg use done + * + * It returns zero on success, else a negative error code. + */ +int rk1608_msq_recv_msg(struct spi_device *spi, struct msg **m) +{ + struct rk1608_msg_queue queue; + struct rk1608_msg_queue *q = &queue; + u32 size = 0, msg_size = 0; + u32 recv_addr = 0; + u32 next_recv_addr = 0; + int err = 0; + + *m = NULL; + err = rk1608_msq_read_head(spi, RK1608_S_MSG_QUEUE_ADDR, q); + if (err) + return err; + + if (q->cur_send == q->cur_recv) + return -1; + /*skip to head when size is 0*/ + err = rk1608_safe_read(spi, (s32)q->cur_recv, (s32 *)&size, 4); + if (err) + return err; + if (size == 0) { + err = rk1608_safe_read(spi, (s32)q->buf_head, (s32 *)&size, 4); + if (err) + return err; + + msg_size = size * sizeof(u32); + recv_addr = q->buf_head; + next_recv_addr = q->buf_head + msg_size; + } else { + msg_size = size * sizeof(u32); + recv_addr = q->cur_recv; + next_recv_addr = q->cur_recv + msg_size; + if (next_recv_addr == q->buf_tail) + next_recv_addr = q->buf_head; + } + + if (msg_size > (q->buf_tail - q->buf_head)) + return -2; + + *m = kmalloc(msg_size, GFP_KERNEL); + err = rk1608_safe_read(spi, recv_addr, (s32 *)*m, msg_size); + if (err == 0) { + err = rk1608_safe_write(spi, RK1608_S_MSG_QUEUE_ADDR + + (u8 *)&q->cur_recv - (u8 *)q, + &next_recv_addr, 4); + } + if (err) + kfree(*m); + + return err; +} + +/** + * rk1608_msq_tail_free_size - get msg queue tail unused buf size + * + * @q: msg queue + * + * It returns size of msg queue tail unused buf size, unit byte + */ +u32 rk1608_msq_tail_free_size(const struct rk1608_msg_queue *q) +{ + if (q->cur_send >= q->cur_recv) + return (q->buf_tail - q->cur_send); + + return q->cur_recv - q->cur_send; +} + +/** + * spi2apb_interrupt_request - SPI2APB request a dsp interrupt + * + * @spi: spi device + * @interrupt_num: interrupt identification + * Context: can sleep + * + * It returns zero on success, else a negative error code. + */ +int spi2apb_interrupt_request(struct spi_device *spi, + s32 interrupt_num) +{ + s32 write_reg1_cmd = APB_CMD_WRITE_REG1; + struct spi_transfer write_reg1_cmd_packet = { + .tx_buf = &write_reg1_cmd, + .len = sizeof(write_reg1_cmd), + }; + struct spi_transfer reg1_packet = { + .tx_buf = &interrupt_num, + .len = sizeof(interrupt_num), + }; + struct spi_message m; + + spi_message_init(&m); + spi_message_add_tail(&write_reg1_cmd_packet, &m); + spi_message_add_tail(®1_packet, &m); + return spi_sync(spi, &m); +} + +/** + * dsp_msq_head_free_size - get msg queue head unused buf size + * + * @q: msg queue + * + * It returns size of msg queue head unused buf size, unit byte + */ +u32 rk1608_msq_head_free_size(const struct rk1608_msg_queue *q) +{ + if (q->cur_send >= q->cur_recv) + return (q->cur_recv - q->buf_head); + + return 0; +} + +/** + * rk1608_msq_send_msg - send a msg to Soc -> DSP msg queue + * + * @spi: spi device + * @m: a msg to send + * + * It returns zero on success, else a negative error code. + */ +int rk1608_msq_send_msg(struct spi_device *spi, const struct msg *m) +{ + int err = 0; + struct rk1608_msg_queue queue; + struct rk1608_msg_queue *q = &queue; + u32 msg_size = m->size * sizeof(u32); + + err = rk1608_msq_read_head(spi, RK1608_R_MSG_QUEUE_ADDR, q); + if (err) + return err; + + if (rk1608_msq_tail_free_size(q) > msg_size) { + u32 next_send; + + err = rk1608_safe_write(spi, q->cur_send, (s32 *)m, msg_size); + next_send = q->cur_send + msg_size; + if (next_send == q->buf_tail) + next_send = q->buf_head; + q->cur_send = next_send; + } else if (rk1608_msq_head_free_size(q) > msg_size) { + /* set size to 0 for skip to head mark */ + err = rk1608_safe_write(spi, q->cur_send, + (s32 *)NULL, 4); + if (err) + return err; + err = rk1608_safe_write(spi, q->buf_head, + (s32 *)m, msg_size); + q->cur_send = q->buf_head + msg_size; + } else { + return -1; + } + + if (err) + return err; + + err = rk1608_safe_write(spi, RK1608_R_MSG_QUEUE_ADDR + + (u8 *)&q->cur_send - (u8 *)q, &q->cur_send, 4); + spi2apb_interrupt_request(spi, RK1608_IRQ_TYPE_MSG); + return err; +} + +int rk1608_send_msg_to_dsp(struct rk1608_state *pdata, const struct msg *m) +{ + int ret = 0; + int msg_num; + int timeout; + int readval; + + /* for msg sync */ + if (pdata->msg_num >= 8) { + dev_err(pdata->dev, "msg sync queue full\n!"); + ret = -EINVAL; + } else if (m->sync == 1) { + mutex_lock(&pdata->send_msg_lock); + msg_num = pdata->msg_num; + atomic_set(&pdata->msg_done[pdata->msg_num++], 0); + mutex_unlock(&pdata->send_msg_lock); + } + + mutex_lock(&pdata->send_msg_lock); + ret = rk1608_msq_send_msg(pdata->spi, m); + mutex_unlock(&pdata->send_msg_lock); + + /* for msg sync */ + if (m->sync == 1) { + readval = atomic_read(&pdata->msg_done[msg_num]); + timeout = wait_event_timeout(pdata->msg_wait, readval, + MSG_SYNC_TIMEOUT); + if (unlikely(timeout <= 0)) { + dev_info(pdata->dev, "msg_wait timeout %d msg_num:%d\n", + timeout, pdata->msg_num); + mutex_lock(&pdata->send_msg_lock); + atomic_set(&pdata->msg_done[msg_num], 0); + mutex_unlock(&pdata->send_msg_lock); + } + } + + return ret; +} + +static void print_rk1608_log(struct rk1608_state *pdata, + struct msg_rk1608_log_t *log) +{ + char *str = (char *)(log); + + str[log->size * sizeof(s32) - 1] = 0; + str += sizeof(struct msg_rk1608_log_t); + dev_info(pdata->dev, "RK1608(%d): %s", log->core_id, str); +} + +void int32_hexdump(const char *prefix, s32 *data, int len) +{ + pr_err("%s\n", prefix); + print_hex_dump(KERN_ERR, "offset ", DUMP_PREFIX_OFFSET, + 16, 4, data, len, false); + pr_err("\n"); +} + +static void dispatch_received_msg(struct rk1608_state *pdata, + struct msg *msg) +{ + #if DEBUG_DUMP_ALL_SEND_RECV_MSG == 1 + int32_hexdump("recv msg:", (s32 *)msg, msg->size * 4); + #endif + if (msg->type == id_msg_set_stream_out_on_ret_t) { + mutex_lock(&pdata->sensor_lock); + pdata->sensor_cnt++; + mutex_unlock(&pdata->sensor_lock); + } + + if (msg->type == id_msg_rk1608_log_t) + print_rk1608_log(pdata, (struct msg_rk1608_log_t *)msg); +} + +static irqreturn_t rk1608_threaded_isr(int irq, void *dev_id) +{ + struct rk1608_state *pdata = dev_id; + struct msg *msg; + + WARN_ON(irq != pdata->irq); + while (!rk1608_msq_recv_msg(pdata->spi, &msg) && NULL != msg) { + dispatch_received_msg(pdata, msg); + /* for kernel msg sync */ + if (pdata->msg_num != 0 && msg->sync) { + dev_info(pdata->dev, "rk1608 kernel sync\n"); + mutex_lock(&pdata->send_msg_lock); + pdata->msg_num--; + atomic_set(&pdata->msg_done[pdata->msg_num], 1); + mutex_unlock(&pdata->send_msg_lock); + wake_up(&pdata->msg_wait); + } + kfree(msg); + } + + return IRQ_HANDLED; +} + +static irqreturn_t rk1608_sleep_isr(int irq, void *dev_id) +{ + struct rk1608_state *pdata = dev_id; + + WARN_ON(irq != pdata->sleepst_irq); + if (pdata->powerdown_gpio > 0) + gpio_set_value(pdata->powerdown_gpio, !pdata->powerdown_active); + + return IRQ_HANDLED; +} + +static int rk1608_parse_dt_property(struct rk1608_state *pdata) +{ + int ret = 0; + int i; + struct device *dev = pdata->dev; + struct device_node *node = dev->of_node; + enum of_gpio_flags flags; + + if (!node) + return 1; + + ret = of_property_read_u32(node, "spi-max-frequency", + &pdata->max_speed_hz); + if (ret) { + dev_warn(dev, "can not get spi-max-frequency!"); + pdata->max_speed_hz = RK1608_MCLK_RATE; + } + ret = of_property_read_u64(node, "link-freqs", + &pdata->link_freqs); + if (ret) + dev_warn(dev, "can not get link_freqs!"); + pdata->mipi_clk = devm_clk_get(dev, "mipi_clk"); + if (IS_ERR(pdata->mipi_clk)) { + dev_err(dev, "can not get mipi_clk, error %ld\n", + PTR_ERR(pdata->mipi_clk)); + pdata->mipi_clk = NULL; + } + pdata->pd_cif = devm_clk_get(dev, "pd_cif"); + if (IS_ERR(pdata->pd_cif)) { + dev_err(dev, "can not get pd_cif, error %ld\n", + PTR_ERR(pdata->pd_cif)); + pdata->pd_cif = NULL; + } + pdata->aclk_cif = devm_clk_get(dev, "aclk_cif"); + if (IS_ERR(pdata->aclk_cif)) { + dev_err(dev, "can not get aclk_cif, error %ld\n", + PTR_ERR(pdata->aclk_cif)); + pdata->aclk_cif = NULL; + } + pdata->hclk_cif = devm_clk_get(dev, "hclk_cif"); + if (IS_ERR(pdata->hclk_cif)) { + dev_warn(dev, "can not get hclk_cif, error %ld\n", + PTR_ERR(pdata->hclk_cif)); + pdata->hclk_cif = NULL; + } + pdata->cif_clk_in = devm_clk_get(dev, "cif0_in"); + if (IS_ERR(pdata->cif_clk_in)) { + dev_err(dev, "can not get cif_clk_in, error %ld\n", + PTR_ERR(pdata->cif_clk_in)); + pdata->cif_clk_in = NULL; + } + pdata->cif_clk_out = devm_clk_get(dev, "cif0_out"); + if (IS_ERR(pdata->cif_clk_out)) { + dev_err(dev, "can not get cif_clk_out, error %ld\n", + PTR_ERR(pdata->cif_clk_out)); + pdata->cif_clk_out = NULL; + } + pdata->clk_mipi_24m = devm_clk_get(dev, "clk_mipi_24m"); + if (IS_ERR(pdata->clk_mipi_24m)) { + dev_err(dev, "can not get clk_mipi_24m, error %ld\n", + PTR_ERR(pdata->clk_mipi_24m)); + pdata->clk_mipi_24m = NULL; + } + pdata->hclk_mipiphy = devm_clk_get(dev, "hclk_mipiphy"); + if (IS_ERR(pdata->hclk_mipiphy)) { + dev_err(dev, "can not get hclk_mipiphy, error %ld\n", + PTR_ERR(pdata->hclk_mipiphy)); + pdata->hclk_mipiphy = NULL; + } + pdata->mclk = devm_clk_get(dev, "mclk"); + if (IS_ERR(pdata->mclk)) { + dev_err(dev, "can not get mclk, error %ld\n", + PTR_ERR(pdata->mclk)); + pdata->mclk = NULL; + } + ret = of_get_named_gpio_flags(node, "rockchip,reset1", 0, &flags); + if (ret <= 0) + dev_err(dev, "can not find reset1 error %d\n", ret); + pdata->rst1 = ret; + + ret = devm_gpio_request(dev, pdata->rst1, "rockchip-reset1"); + if (ret) { + dev_err(dev, "gpio pdata->rst1 %d request error %d\n", + pdata->rst1, ret); + return ret; + } + gpio_set_value(pdata->rst1, 0); + ret = gpio_direction_output(pdata->rst1, 0); + if (ret) { + dev_err(dev, "gpio %d direction output error %d\n", + pdata->rst1, ret); + return ret; + } + + ret = of_get_named_gpio_flags(node, "rockchip,powerdown1", 0, &flags); + if (ret <= 0) + dev_warn(dev, "can not find powerdown1, error %d\n", ret); + + pdata->powerdown1 = ret; + ret = devm_gpio_request(dev, pdata->powerdown1, "rockchip-powerdown1"); + if (ret) { + dev_err(dev, "gpio pdata->powerdown1 %d request error %d\n", + pdata->powerdown1, ret); + return ret; + } + + ret = gpio_direction_output(pdata->powerdown1, 0); + if (ret) { + dev_err(dev, "gpio %d direction output error %d\n", + pdata->powerdown1, ret); + return ret; + } + + ret = of_get_named_gpio_flags(node, "rockchip,reset0", 0, &flags); + if (ret <= 0) + dev_warn(dev, + "can not find property rockchip,reset0, error %d\n", + ret); + pdata->rst0 = ret; + ret = devm_gpio_request(dev, pdata->rst0, "rockchip-reset0"); + if (ret) { + dev_err(dev, "gpio pdata->rst0 %d request error %d\n", + pdata->rst0, ret); + return ret; + } + gpio_set_value(pdata->rst0, 0); + ret = gpio_direction_output(pdata->rst0, 0); + if (ret) { + dev_err(dev, "gpio0 %d direction output error %d\n", + pdata->rst0, ret); + return ret; + } + + ret = of_get_named_gpio_flags(node, "rockchip,powerdown0", 0, &flags); + if (ret <= 0) + dev_warn(dev, "can not find powerdown0,error %d\n", ret); + + pdata->powerdown0 = ret; + + ret = devm_gpio_request(dev, pdata->powerdown0, "rockchip-powerdown0"); + if (ret) { + dev_err(dev, "gpio pdata->powerdown0 %d request error %d\n", + pdata->powerdown0, ret); + return ret; + } + + ret = gpio_direction_output(pdata->powerdown0, 0); + if (ret) { + dev_err(dev, "gpio0 %d direction output error %d\n", + pdata->powerdown0, ret); + return ret; + } + pdata->mclk = devm_clk_get(dev, "mclk"); + if (IS_ERR(pdata->mclk)) { + dev_err(dev, "can not get mclk, error %ld\n", + PTR_ERR(pdata->mclk)); + pdata->mclk = NULL; + return -1; + } + + ret = of_get_named_gpio_flags(node, "reset-gpio", 0, &flags); + if (ret <= 0) { + dev_warn(dev, "can not find reset-gpio, error %d\n", ret); + return ret; + } + pdata->reset_gpio = ret; + pdata->reset_active = 1; + if (flags == OF_GPIO_ACTIVE_LOW) + pdata->reset_active = 0; + + if (pdata->reset_gpio > 0) { + ret = devm_gpio_request(dev, pdata->reset_gpio, "rk1608-reset"); + if (ret) { + dev_err(dev, "gpio %d request error %d\n", + pdata->reset_gpio, ret); + return ret; + } + + ret = gpio_direction_output(pdata->reset_gpio, + !pdata->reset_active); + if (ret) { + dev_err(dev, "gpio %d direction output error %d\n", + pdata->reset_gpio, ret); + return ret; + } + } + + ret = of_get_named_gpio_flags(node, "irq-gpio", 0, NULL); + if (ret <= 0) { + dev_warn(dev, "can not find irq-gpio, error %d\n", ret); + return ret; + } + + pdata->irq_gpio = ret; + + ret = devm_gpio_request(dev, pdata->irq_gpio, "rk1608-irq"); + if (ret) { + dev_err(dev, "gpio %d request error %d\n", pdata->irq_gpio, + ret); + return ret; + } + + ret = gpio_direction_input(pdata->irq_gpio); + if (ret) { + dev_err(dev, "gpio %d direction input error %d\n", + pdata->irq_gpio, ret); + return ret; + } + + ret = gpio_to_irq(pdata->irq_gpio); + if (ret < 0) { + dev_err(dev, "Unable to get irq number for GPIO %d, error %d\n", + pdata->irq_gpio, ret); + return ret; + } + pdata->irq = ret; + ret = request_threaded_irq(pdata->irq, NULL, rk1608_threaded_isr, + IRQF_TRIGGER_RISING | IRQF_ONESHOT, + "rk1608-irq", pdata); + if (ret) { + dev_err(dev, "cannot request thread irq: %d\n", ret); + return ret; + } + + disable_irq(pdata->irq); + + ret = of_get_named_gpio_flags(node, "powerdown-gpio", 0, &flags); + if (ret <= 0) + dev_warn(dev, "can not find powerdown-gpio, error %d\n", ret); + + pdata->powerdown_gpio = ret; + pdata->powerdown_active = 1; + if (flags == OF_GPIO_ACTIVE_LOW) + pdata->powerdown_active = 0; + + if (pdata->powerdown_gpio > 0) { + ret = devm_gpio_request(dev, pdata->powerdown_gpio, + "rk1608-powerdown"); + if (ret) { + dev_err(dev, "gpio %d request error %d\n", + pdata->powerdown_gpio, ret); + return ret; + } + + ret = gpio_direction_output(pdata->powerdown_gpio, + !pdata->powerdown_active); + if (ret) { + dev_err(dev, "gpio %d direction output error %d\n", + pdata->powerdown_gpio, ret); + return ret; + } + } + + pdata->sleepst_gpio = -1; + pdata->sleepst_irq = -1; + pdata->wakeup_gpio = -1; + + ret = of_get_named_gpio_flags(node, "sleepst-gpio", 0, NULL); + if (ret <= 0) { + dev_warn(dev, "can not find property sleepst-gpio, error %d\n", + ret); + return ret; + } + + pdata->sleepst_gpio = ret; + + ret = devm_gpio_request(dev, pdata->sleepst_gpio, "rk1608-sleep-irq"); + if (ret) { + dev_err(dev, "gpio %d request error %d\n", + pdata->sleepst_gpio, ret); + return ret; + } + + ret = gpio_direction_input(pdata->sleepst_gpio); + if (ret) { + dev_err(dev, "gpio %d direction input error %d\n", + pdata->sleepst_gpio, ret); + return ret; + } + + ret = gpio_to_irq(pdata->sleepst_gpio); + if (ret < 0) { + dev_err(dev, "Unable to get irq number for GPIO %d, error %d\n", + pdata->sleepst_gpio, ret); + return ret; + } + pdata->sleepst_irq = ret; + ret = request_any_context_irq(pdata->sleepst_irq, + rk1608_sleep_isr, + IRQF_TRIGGER_RISING, + "rk1608-sleepst", pdata); + disable_irq(pdata->sleepst_irq); + + ret = of_get_named_gpio_flags(node, "wakeup-gpio", 0, &flags); + if (ret <= 0) + dev_warn(dev, "can not find wakeup-gpio error %d\n", ret); + + pdata->wakeup_gpio = ret; + pdata->wakeup_active = 1; + if (flags == OF_GPIO_ACTIVE_LOW) + pdata->wakeup_active = 0; + + if (pdata->wakeup_gpio > 0) { + ret = devm_gpio_request(dev, pdata->wakeup_gpio, + "rk1608-wakeup"); + if (ret) { + dev_err(dev, "gpio %d request error %d\n", + pdata->wakeup_gpio, ret); + return ret; + } + + ret = gpio_direction_output(pdata->wakeup_gpio, + !pdata->wakeup_active); + if (ret) { + dev_err(dev, "gpio %d direction output error %d\n", + pdata->wakeup_gpio, ret); + return ret; + } + } + pdata->msg_num = 0; + init_waitqueue_head(&pdata->msg_wait); + for (i = 0; i < 8; i++) + atomic_set(&pdata->msg_done[i], 0); + + return ret; +} + +static int get_remote_node_dev(struct rk1608_state *pdev) +{ + struct i2c_client *sensor_pdev = NULL; + struct device *dev = pdev->dev; + struct device_node *parent = dev->of_node; + struct device_node *node, *pre_node = NULL; + struct device_node *remote = NULL; + int ret, sensor_nums = 0; + + node = of_graph_get_next_endpoint(parent, pre_node); + if (node) { + of_node_put(pre_node); + pre_node = node; + } else { + dev_err(dev, "fieled to get endpoint\n"); + return -EINVAL; + } + while ((node = of_graph_get_next_endpoint(parent, pre_node)) != NULL) { + of_node_put(pre_node); + pre_node = node; + remote = of_graph_get_remote_port_parent(node); + if (!remote) { + dev_err(dev, "%s: no valid device\n", __func__); + of_node_put(remote); + ret = -EINVAL; + } + + sensor_pdev = of_find_i2c_device_by_node(remote); + of_node_put(remote); + + if (!sensor_pdev) { + dev_err(dev, "fieled to get Sensor device\n"); + ret = -EINVAL; + } else { + pdev->cd[sensor_nums] = i2c_get_clientdata(sensor_pdev); + if (pdev->cd[sensor_nums]) + sensor_nums++; + else + dev_err(dev, "fieled to get Sensor drvdata\n"); + ret = 0; + } + } + pdev->sensor_nums = sensor_nums; + if (pdev->sensor_nums) + dev_info(dev, "get Sensor (nums=%d) dev is OK!\n", + pdev->sensor_nums); + + return ret; +} + +static int rk1608_probe(struct spi_device *spi) +{ + struct rk1608_state *rk1608; + struct v4l2_subdev *sd; + struct v4l2_ctrl_handler *handler; + + int ret; + + rk1608 = devm_kzalloc(&spi->dev, sizeof(*rk1608), GFP_KERNEL); + if (!rk1608) + return -ENOMEM; + rk1608->dev = &spi->dev; + rk1608->spi = spi; + spi_set_drvdata(spi, rk1608); + ret = rk1608_parse_dt_property(rk1608); + if (ret) { + dev_err(rk1608->dev, "rk1608 parse dt property err(%x)\n", ret); + goto parse_err; + } + ret = get_remote_node_dev(rk1608); + if (ret) + dev_warn(rk1608->dev, "get remote node dev err(%x)\n", ret); + rk1608->sensor_cnt = 0; + mutex_init(&rk1608->sensor_lock); + mutex_init(&rk1608->send_msg_lock); + mutex_init(&rk1608->lock); + sd = &rk1608->sd; + v4l2_spi_subdev_init(sd, spi, &rk1608_subdev_ops); + + handler = &rk1608->ctrl_handler; + ret = v4l2_ctrl_handler_init(handler, 1); + if (ret) + goto handler_init_err; + + rk1608->link_freq = v4l2_ctrl_new_int_menu(handler, NULL, + V4L2_CID_LINK_FREQ, + 0, 0, &rk1608->link_freqs); + if (rk1608->link_freq) + rk1608->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY; + + if (handler->error) + goto handler_err; + + sd->ctrl_handler = handler; + sd->internal_ops = &rk1608_subdev_internal_ops; + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; + + rk1608->pad.flags = MEDIA_PAD_FL_SOURCE; + sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; + + ret = media_entity_init(&sd->entity, 1, &rk1608->pad, 0); + if (ret < 0) + goto handler_err; + + ret = v4l2_async_register_subdev(sd); + if (ret < 0) + goto register_err; + dev_info(rk1608->dev, "DSP rk1608 Driver probe is OK!\n"); + + return 0; +register_err: + media_entity_cleanup(&sd->entity); +handler_err: + v4l2_ctrl_handler_free(handler); +handler_init_err: + v4l2_device_unregister_subdev(&rk1608->sd); + mutex_destroy(&rk1608->lock); + mutex_destroy(&rk1608->send_msg_lock); + mutex_destroy(&rk1608->sensor_lock); +parse_err: + kfree(rk1608); + return ret; +} + +static int rk1608_remove(struct spi_device *spi) +{ + struct rk1608_state *rk1608 = spi_get_drvdata(spi); + + v4l2_async_unregister_subdev(&rk1608->sd); + media_entity_cleanup(&rk1608->sd.entity); + v4l2_ctrl_handler_free(&rk1608->ctrl_handler); + v4l2_device_unregister_subdev(&rk1608->sd); + mutex_destroy(&rk1608->lock); + mutex_destroy(&rk1608->send_msg_lock); + mutex_destroy(&rk1608->sensor_lock); + kfree(rk1608); + + return 0; +} + +static const struct spi_device_id rk1608_id[] = { + { "RK1608", 0 }, + { } +}; +MODULE_DEVICE_TABLE(spi, rk1608_id); + +#if IS_ENABLED(CONFIG_OF) +static const struct of_device_id rk1608_of_match[] = { + { .compatible = "rockchip,rk1608" }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, rk1608_of_match); +#endif + +static struct spi_driver rk1608_driver = { + .driver = { + .of_match_table = of_match_ptr(rk1608_of_match), + .name = "RK1608", + }, + .probe = rk1608_probe, + .remove = rk1608_remove, + .id_table = rk1608_id, +}; + +module_spi_driver(rk1608_driver); + +MODULE_AUTHOR("Rockchip Camera/ISP team"); +MODULE_DESCRIPTION("A DSP driver for rk1608 chip"); +MODULE_LICENSE("Dual BSD/GPL"); diff --git a/drivers/media/spi/rk1608.h b/drivers/media/spi/rk1608.h new file mode 100644 index 0000000..bbfa9ad --- /dev/null +++ b/drivers/media/spi/rk1608.h @@ -0,0 +1,471 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/** + * Rockchip rk1608 driver + * + * Copyright (C) 2017 Rockchip Electronics Co., Ltd. + * + */ + +#ifndef __RK1608_H__ +#define __RK1608_H__ + +#include <linux/i2c.h> +#include <linux/string.h> +#include <linux/spi/spi.h> +#include <linux/types.h> + +#define RK1608_OP_TRY_MAX 3 +#define RK1608_OP_TRY_DELAY 10 +#define RK1608_CMD_WRITE 0x00000011 +#define RK1608_CMD_WRITE_REG0 0X00010011 +#define RK1608_CMD_WRITE_REG1 0X00020011 +#define RK1608_CMD_READ 0x00000077 +#define RK1608_CMD_READ_BEGIN 0x000000aa +#define RK1608_CMD_QUERY 0x000000ff +#define RK1608_CMD_QUERY_REG2 0x000001ff +#define RK1608_STATE_ID_MASK 0xffff0000 +#define RK1608_STATE_ID 0X16080000 +#define RK1608_STATE_MASK 0x0000ffff +#define APB_CMD_WRITE_REG1 0X00020011 +#define RK1608_R_MSG_QUEUE_ADDR 0x60050000 + +#define RK1608_IRQ_TYPE_MSG 0x12345678 +#define BOOT_REQUEST_ADDR 0x18000010 +#define RK1608_HEAD_ADDR 0x60000000 +#define RK1608_FW_NAME "rk1608.rkl" +#define RK1608_S_MSG_QUEUE_ADDR 0x60050010 +#define RK1608_PMU_SYS_REG0 0x120000f0 +#define RK1608_MSG_QUEUE_OK_MASK 0xffff0001 +#define RK1608_MSG_QUEUE_OK_TAG 0x16080001 +#define RK1608_MAX_OP_BYTES 60000 +#define MSG_SYNC_TIMEOUT 50 + +#define BOOT_FLAG_CRC (0x01 << 0) +#define BOOT_FLAG_EXE (0x01 << 1) +#define BOOT_FLAG_LOAD_PMEM (0x01 << 2) +#define BOOT_FLAG_ACK (0x01 << 3) +#define BOOT_FLAG_READ_WAIT (0x01 << 4) +#define BOOT_FLAG_BOOT_REQUEST (0x01 << 5) + +#define DEBUG_DUMP_ALL_SEND_RECV_MSG 0 +#define RK1608_MCLK_RATE (24 * 1000 * 1000ul) +#define SENSOR_TIMEOUT 1000 +#define GRF_BASE_ADDR 0xff770000 +#define GRF_GPIO2B_IOMUX 0x0014 +#define GRF_IO_VSEL 0x0380 + +#define OPM_SLAVE_MODE 0X100000 +#define RSD_SEL_2CYC 0X008000 +#define DFS_SEL_16BIT 0X000002 +#define SPI_CTRL0 0x11060000 +#define SPI_ENR 0x11060008 +#define CRUPMU_CLKSEL14_CON 0x12008098 +#define PMUGRF_GPIO1A_E 0x12030040 +#define PMUGRF_GPIO1B_E 0x12030044 +#define BIT7_6_SEL_8MA 0xf000a000 +#define BIT1_0_SEL_8MA 0x000f000a +#define SPI0_PLL_SEL_APLL 0xff004000 +#define INVALID_ID -1 +#define RK1608_MAX_SEC_NUM 10 + +#ifndef MIN +#define MIN(a, b) ((a) < (b) ? (a) : (b)) +#endif + +#ifndef MSB2LSB32 +#define MSB2LSB32(x) ((((u32)x & 0x80808080) >> 7) | \ + (((u32)x & 0x40404040) >> 5) | \ + (((u32)x & 0x20202020) >> 3) | \ + (((u32)x & 0x10101010) >> 1) | \ + (((u32)x & 0x08080808) << 1) | \ + (((u32)x & 0x04040404) << 3) | \ + (((u32)x & 0x02020202) << 5) | \ + (((u32)x & 0x01010101) << 7)) +#endif + +struct camera_info { + s8 cam_id; + s8 in_mipi; + s8 out_mipi; + s8 mipi_lane; + u8 i2c_bus; + u8 data_type; + u8 field; + u8 colorspace; + u16 code; + u16 width; + u16 height; + u16 htotal; + u16 vtotal; + u32 mipi_clock; +}; + +struct camera_dev { + struct v4l2_subdev sd; + struct i2c_client *client; + struct mutex lock; /*lock resource*/ + struct camera_info ci; +}; + +struct rk1608_state { + struct v4l2_subdev sd; + struct media_pad pad; + struct mutex lock; /* protect resource */ + struct mutex sensor_lock; /* protect sensor */ + struct mutex send_msg_lock; /* protect msg */ + struct camera_dev *cd[2]; + struct device *dev; + struct spi_device *spi; + struct clk *mclk; + struct clk *mipi_clk; + struct clk *pd_cif; + struct clk *aclk_cif; + struct clk *hclk_cif; + struct clk *cif_clk_in; + struct clk *cif_clk_out; + struct clk *clk_mipi_24m; + struct clk *hclk_mipiphy; + void __iomem *grf_gpio2b_iomux; + void __iomem *grf_io_vsel; + int powerdown1; + int rst1; + int powerdown0; + int rst0; + int power_count; + int reset_gpio; + int reset_active; + int irq_gpio; + int irq; + int sleepst_gpio; + int sleepst_irq; + int wakeup_gpio; + int wakeup_active; + int powerdown_gpio; + int powerdown_active; + int msg_num; + u32 sensor_cnt; + u32 sensor_nums; + u32 max_speed_hz; + atomic_t msg_done[8]; + wait_queue_head_t msg_wait; + struct v4l2_ctrl *link_freq; + struct v4l2_ctrl_handler ctrl_handler; + s64 link_freqs; +}; + +struct rk1608_section { + union { + u32 offset; + u32 wait_value; + }; + u32 size; + union { + u32 load_addr; + u32 wait_addr; + }; + u16 wait_time; + u16 timeout; + u16 crc_16; + u8 flag; + u8 type; +}; + +struct rk1608_header { + char version[32]; + u32 header_size; + u32 section_count; + struct rk1608_section sections[RK1608_MAX_SEC_NUM]; +}; + +struct rk1608_boot_req { + u32 flag; + u32 load_addr; + u32 boot_len; + u8 status; + u8 dummy[2]; + u8 cmd; +}; + +struct rk1608_msg_queue { + u32 buf_head; /* msg buffer head */ + u32 buf_tail; /* msg buffer tail */ + u32 cur_send; /* current msg send postition */ + u32 cur_recv; /* current msg receive position */ +}; + +struct msg { + u32 size; /* unit 4 bytes */ + u16 type; /* msg identification */ + s8 camera_id; + s8 sync; +}; + +struct msg_init { + u32 size; /* unit 4 bytes */ + u16 type; + u8 camera_id; + u8 sync; + + u32 i2c_bus; + u32 i2c_clk; + s8 in_mipi_phy; + s8 out_mipi_phy; + s8 mipi_lane; + s8 bayer; + u8 sensor_name[32]; + u8 i2c_slave_addr; +}; + +struct msg_t { + u32 size; /* unit 4 bytes */ + u16 type; + union { + u8 camera_id; + u8 core_id; + } id; + union { + u8 sync; + u8 log_level; + s8 err; + } mux; +}; + +struct preisp_vc_cfg { + s8 data_type; + s8 decode_format; + s8 flag; + s8 unused; + u16 width; + u16 height; +}; + +struct msg_in_size { + struct msg_t msg_head; + struct preisp_vc_cfg channel; +}; + +struct msg_out_size { + u32 size; /* unit 4 bytes */ + u16 type; + u8 camera_id; + u8 sync; + + u16 width; + u16 height; + u32 mipi_clk; + u16 line_length_pclk; + u16 frame_length_lines; +}; + +enum { + /* AP -> RK1608 + * 1 msg of sensor + */ + id_msg_init_sensor_t = 0x0001, + id_msg_set_input_size_t, + id_msg_set_output_size_t, + id_msg_set_stream_in_on_t, + id_msg_set_stream_in_off_t, + id_msg_set_stream_out_on_t, + id_msg_set_stream_out_off_t, + + /* AP -> RK1608 + * 2 msg of take picture + */ + id_msg_take_picture_t = 0x0021, + id_msg_take_picture_done_t, + + /* AP -> RK1608 + * 3 msg of realtime parameter + */ + id_msg_rt_args_t = 0x0031, + + /* AP -> RK1608 + * 4 msg of power manager + */ + id_msg_set_sys_mode_bypass_t = 0x0200, + id_msg_set_sys_mode_standby_t, + id_msg_set_sys_mode_idle_enable_t, + id_msg_set_sys_mode_idle_disable_t, + id_msg_set_sys_mode_slave_rk1608_on_t, + id_msg_set_sys_mode_slave_rk1608_off_t, + + /* AP -> RK1608 + * 5 msg of debug config + */ + id_msg_set_log_level_t = 0x0250, + + /* RK1608 -> AP + * 6 response of sensor msg + */ + id_msg_init_sensor_ret_t = 0x0301, + id_msg_set_input_size_ret_t, + id_msg_set_output_size_ret_t, + id_msg_set_stream_in_on_ret_t, + id_msg_set_stream_in_off_ret_t, + id_msg_set_stream_out_on_ret_t, + id_msg_set_stream_out_off_ret_t, + + /* RK1608 -> AP + * 7 response of take picture msg + */ + id_msg_take_picture_ret_t = 0x0320, + id_msg_take_picture_done_ret_t, + + /* RK1608 -> AP + * 8 response of realtime parameter msg + */ + id_msg_rt_args_ret_t = 0x0330, + + /* rk1608 -> AP */ + id_msg_do_i2c_t = 0x0390, + /* AP -> rk1608 */ + id_msg_do_i2c_ret_t, + + /* RK1608 -> AP + * 9 msg of print log + */ + id_msg_rk1608_log_t = 0x0400, + + /* dsi2csi dump */ + id_msg_dsi2sci_rgb_dump_t = 0x6000, + id_msg_dsi2sci_nv12_dump_t = 0x6001, + + /* RK1608 -> AP + * 10 msg of xfile + */ + id_msg_xfile_import_t = 0x8000 + 0x0600, + id_msg_xfile_export_t, + id_msg_xfile_mkdir_t +}; + +struct msg_rk1608_log_t { + u32 size; + u16 type; + s8 core_id; + s8 log_level; +}; + +int rk1608_send_msg_to_dsp(struct rk1608_state *pdata, const struct msg *m); +/** + * rk1608_write - RK1608 synchronous write + * + * @spi: spi device + * @addr: resource address + * @data: data buffer + * @data_len: data buffer size, in bytes + * Context: can sleep + * + * It returns zero on success, else a negative error code. + */ +int rk1608_write(struct spi_device *spi, s32 addr, + const s32 *data, size_t data_len); + +/** + * rk1608_safe_write - RK1608 synchronous write with state check + * + * @spi: spi device + * @addr: resource address + * @data: data buffer + * @data_len: data buffer size, in bytes + * Context: can sleep + * + * It returns zero on success, else operation state code. + */ +int rk1608_safe_write(struct spi_device *spi, + s32 addr, const s32 *data, size_t data_len); + +/** + * rk1608_read - RK1608 synchronous read + * + * @spi: spi device + * @addr: resource address + * @data: data buffer [out] + * @data_len: data buffer size, in bytes + * Context: can sleep + * + * It returns zero on success, else a negative error code. + */ +int rk1608_read(struct spi_device *spi, s32 addr, + s32 *data, size_t data_len); + +/** + * rk1608_safe_read - RK1608 synchronous read with state check + * + * @spi: spi device + * @addr: resource address + * @data: data buffer [out] + * @data_len: data buffer size, in bytes + * Context: can sleep + * + * It returns zero on success, else operation state code. + */ +int rk1608_safe_read(struct spi_device *spi, + s32 addr, s32 *data, size_t data_len); + +/** + * rk1608_operation_query - RK1608 last operation state query + * + * @spi: spi device + * @state: last operation state [out] + * Context: can sleep + * + * It returns zero on success, else a negative error code. + */ +int rk1608_operation_query(struct spi_device *spi, s32 *state); + +/** + * rk1608_interrupt_request - RK1608 request a rk1608 interrupt + * + * @spi: spi device + * @interrupt_num: interrupt identification + * Context: can sleep + * + * It returns zero on success, else a negative error code. + */ +int rk1608_interrupt_request(struct spi_device *spi, + s32 interrupt_num); + +static int rk1608_read_wait(struct spi_device *spi, + const struct rk1608_section *sec); + +static int rk1608_boot_request(struct spi_device *spi, + const struct rk1608_section *sec); + +static int rk1608_download_section(struct spi_device *spi, const u8 *data, + const struct rk1608_section *sec); +/** + * rk1608_download_fw: - rk1608 firmware download through spi + * + * @spi: spi device + * @fw_name: name of firmware file, NULL for default firmware name + * Context: can sleep + * + * It returns zero on success, else a negative error code. + **/ +int rk1608_download_fw(struct spi_device *spi, const char *fw_name); + +/** + * rk1608_msq_read_head - read rk1608 msg queue head + * + * @spi: spi device + * @addr: msg queue head addr + * @m: msg queue pointer + * + * It returns zero on success, else a negative error code. + */ +int rk1608_msq_read_head(struct spi_device *spi, + u32 addr, struct rk1608_msg_queue *q); + +/** + * rk1608_msq_recv_msg - receive a msg from RK1608 -> AP msg queue + * + * @q: msg queue + * @m: a msg pointer buf [out] + * + * need call rk1608_msq_free_received_msg to free msg after msg use done + * + * It returns zero on success, else a negative error code. + */ +int rk1608_msq_recv_msg(struct spi_device *spi, struct msg **m); +#endif -- 2.7.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] [media] Add Rockchip RK1608 driver 2018-02-26 8:16 ` [PATCH V2 1/2] [media] Add Rockchip RK1608 driver Wen Nuan @ 2018-02-26 9:50 ` Hans Verkuil 2018-02-26 10:12 ` Linus Walleij 1 sibling, 0 replies; 8+ messages in thread From: Hans Verkuil @ 2018-02-26 9:50 UTC (permalink / raw) To: Wen Nuan, mchehab, davem, gregkh, linus.walleij, rdunlap, jacob2.chen Cc: linux-kernel, linux-media, eddie.cai Hi Leo, Thank you for this patch series! Here is a quick review of this driver: On 02/26/2018 09:16 AM, Wen Nuan wrote: > From: Leo Wen <leo.wen@rock-chips.com> > > Rk1608 is used as a PreISP to link on Soc, which mainly has two functions. > One is to download the firmware of RK1608, and the other is to match the > extra sensor such as camera and enable sensor by calling sensor's s_power. > > use below v4l2-ctl command to capture frames. > > v4l2-ctl --verbose -d /dev/video1 --stream-mmap=2 > --stream-to=/tmp/stream.out --stream-count=60 --stream-poll > > use below command to playback the video on your PC. > > mplayer ./stream.out -loop 0 -demuxer rawvideo -rawvideo > w=640:h=480:size=$((640*480*3/2)):format=NV12 > > Changes V2: > - Delete long legalese. > - Add the new SPDX tags. > - Dual cameras can be captured at the same time. > - Add some pins and clock control for external sensors. > - Add a function, the Soc can send control MSG to RK1608. > > Signed-off-by: Leo Wen <leo.wen@rock-chips.com> > --- > MAINTAINERS | 6 + > drivers/media/spi/Makefile | 1 + > drivers/media/spi/rk1608.c | 1664 ++++++++++++++++++++++++++++++++++++++++++++ > drivers/media/spi/rk1608.h | 471 +++++++++++++ > 4 files changed, 2142 insertions(+) > create mode 100644 drivers/media/spi/rk1608.c > create mode 100644 drivers/media/spi/rk1608.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 93a12af..b2a98e3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -136,6 +136,12 @@ Maintainers List (try to look for most precise areas first) > > ----------------------------------- > > +ROCKCHIP RK1608 DRIVER > +M: Leo Wen <leo.wen@rock-chips.com> > +S: Maintained > +F: drivers/media/spi/rk1608.c > +F: drivers/media/spi/rk1608.h > + > 3C59X NETWORK DRIVER > M: Steffen Klassert <klassert@mathematik.tu-chemnitz.de> > L: netdev@vger.kernel.org > diff --git a/drivers/media/spi/Makefile b/drivers/media/spi/Makefile > index ea64013..9d9d9ec 100644 > --- a/drivers/media/spi/Makefile > +++ b/drivers/media/spi/Makefile > @@ -1 +1,2 @@ > obj-$(CONFIG_VIDEO_GS1662) += gs1662.o > +obj-$(CONFIG_ROCKCHIP_RK1608) += rk1608.o > diff --git a/drivers/media/spi/rk1608.c b/drivers/media/spi/rk1608.c > new file mode 100644 > index 0000000..c229b30 > --- /dev/null > +++ b/drivers/media/spi/rk1608.c > @@ -0,0 +1,1664 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/** > + * Rockchip rk1608 driver > + * > + * Copyright (C) 2017 Rockchip Electronics Co., Ltd. > + * > + */ > + > +#include <linux/delay.h> > +#include <linux/firmware.h> > +#include <linux/interrupt.h> > +#include <linux/of_platform.h> > +#include <linux/of_gpio.h> > +#include <media/v4l2-ctrls.h> > +#include <media/v4l2-subdev.h> > +#include <media/v4l2-device.h> > +#include <media/v4l2-fwnode.h> > +#include <media/v4l2-image-sizes.h> > +#include <media/v4l2-mediabus.h> > +#include <media/v4l2-of.h> > +#include "rk1608.h" > + > +/** > + * Rk1608 is used as the Pre-ISP to link on Soc, which mainly has two > + * functions. One is to download the firmware of RK1608, and the other > + * is to match the extra sensor such as camera and enable sensor by "to match the extra sensor": I'm not sure what is meant by that. Can you elaborate? > + * calling sensor's s_power. > + * |-----------------------| > + * | Sensor Camera | > + * |-----------------------| > + * |-----------||----------| > + * |-----------||----------| > + * |-----------\/----------| > + * | Pre-ISP RK1608 | > + * |-----------------------| > + * |-----------||----------| > + * |-----------||----------| > + * |-----------\/----------| > + * | Rockchip Soc | > + * |-----------------------| > + * Data Transfer As shown above. In RK1608, the data received from the > + * extra sensor,and it is passed to the Soc through ISP. > + */ > + > +static inline struct rk1608_state *to_state(struct v4l2_subdev *sd) > +{ > + return container_of(sd, struct rk1608_state, sd); > +} > + > +/** > + * rk1608_operation_query - RK1608 last operation state query > + * > + * @spi: device from which data will be read > + * @state: last operation state [out] > + * Context: can sleep > + * > + * It returns zero on success, else a negative error code. > + */ > +int rk1608_operation_query(struct spi_device *spi, s32 *state) Why isn't this static? Ditto for all the other non-static functions below. > +{ > + s32 query_cmd = RK1608_CMD_QUERY; > + struct spi_transfer query_cmd_packet = { > + .tx_buf = &query_cmd, > + .len = sizeof(query_cmd), > + }; > + struct spi_transfer state_packet = { > + .rx_buf = state, > + .len = sizeof(*state), > + }; > + struct spi_message m; > + > + spi_message_init(&m); > + spi_message_add_tail(&query_cmd_packet, &m); > + spi_message_add_tail(&state_packet, &m); > + spi_sync(spi, &m); > + > + return ((*state & RK1608_STATE_ID_MASK) == RK1608_STATE_ID) ? 0 : -1; > +} > + > +int rk1608_write(struct spi_device *spi, > + s32 addr, const s32 *data, size_t data_len) > +{ > + s32 write_cmd = RK1608_CMD_WRITE; > + struct spi_transfer write_cmd_packet = { > + .tx_buf = &write_cmd, > + .len = sizeof(write_cmd), > + }; > + struct spi_transfer addr_packet = { > + .tx_buf = &addr, > + .len = sizeof(addr), > + }; > + struct spi_transfer data_packet = { > + .tx_buf = data, > + .len = data_len, > + }; > + struct spi_message m; > + > + spi_message_init(&m); > + spi_message_add_tail(&write_cmd_packet, &m); > + spi_message_add_tail(&addr_packet, &m); > + spi_message_add_tail(&data_packet, &m); > + return spi_sync(spi, &m); > +} > + > +/** > + * rk1608_safe_write - RK1608 synchronous write with state check > + * > + * @spi: spi device > + * @addr: resource address > + * @data: data buffer > + * @data_len: data buffer size, in bytes > + * Context: can sleep > + * > + * It returns zero on success, else operation state code. That's not a good idea. It's better to return -EIO or something if it didn't work. It looks like the return code is just passed on to the higher levels so you end up with a bogus error code. > + */ > +int rk1608_safe_write(struct spi_device *spi, > + s32 addr, const s32 *data, size_t data_len) > +{ > + int ret = 0; > + s32 state, retry = 0; > + > + while (data_len > 0) { > + size_t slen = MIN(data_len, RK1608_MAX_OP_BYTES); > + > + do { > + rk1608_write(spi, addr, data, data_len); > + if (rk1608_operation_query(spi, &state) != 0) > + return -1; Same here: return a proper error code. > + if ((state & RK1608_STATE_MASK) == 0) > + break; > + > + udelay(RK1608_OP_TRY_DELAY); > + } while (retry++ != RK1608_OP_TRY_MAX); > + > + data_len = data_len - slen; > + data = (s32 *)((s8 *)data + slen); > + addr += slen; > + } > + return ret; > +} > + > +void rk1608_hw_init(struct spi_device *spi) > +{ > + s32 write_data = SPI0_PLL_SEL_APLL; > + > + /* modify rk1608 spi slave clk to 300M */ > + rk1608_safe_write(spi, CRUPMU_CLKSEL14_CON, &write_data, 4); > + > + /* modify rk1608 spi io driver strength to 8mA */ > + write_data = BIT7_6_SEL_8MA; > + rk1608_safe_write(spi, PMUGRF_GPIO1A_E, &write_data, 4); > + write_data = BIT1_0_SEL_8MA; > + rk1608_safe_write(spi, PMUGRF_GPIO1B_E, &write_data, 4); > +} > + > +/** > + * rk1608_read - RK1608 synchronous read > + * > + * @spi: spi device > + * @addr: resource address > + * @data: data buffer [out] > + * @data_len: data buffer size, in bytes > + * Context: can sleep > + * > + * It returns zero on success, else a negative error code. > + */ > +int rk1608_read(struct spi_device *spi, > + s32 addr, s32 *data, size_t data_len) > +{ > + s32 real_len = MIN(data_len, RK1608_MAX_OP_BYTES); > + s32 read_cmd = RK1608_CMD_READ | (real_len << 14 & > + RK1608_STATE_ID_MASK); > + s32 read_begin_cmd = RK1608_CMD_READ_BEGIN; > + s32 dummy = 0; > + struct spi_transfer read_cmd_packet = { > + .tx_buf = &read_cmd, > + .len = sizeof(read_cmd), > + }; > + struct spi_transfer addr_packet = { > + .tx_buf = &addr, > + .len = sizeof(addr), > + }; > + struct spi_transfer read_dummy_packet = { > + .tx_buf = &dummy, > + .len = sizeof(dummy), > + }; > + struct spi_transfer read_begin_cmd_packet = { > + .tx_buf = &read_begin_cmd, > + .len = sizeof(read_begin_cmd), > + }; > + struct spi_transfer data_packet = { > + .rx_buf = data, > + .len = data_len, > + }; > + struct spi_message m; > + > + spi_message_init(&m); > + spi_message_add_tail(&read_cmd_packet, &m); > + spi_message_add_tail(&addr_packet, &m); > + spi_message_add_tail(&read_dummy_packet, &m); > + spi_message_add_tail(&read_begin_cmd_packet, &m); > + spi_message_add_tail(&data_packet, &m); > + return spi_sync(spi, &m); > +} > + > +/** > + * rk1608_safe_read - RK1608 synchronous read with state check > + * > + * @spi: spi device > + * @addr: resource address > + * @data: data buffer [out] > + * @data_len: data buffer size, in bytes > + * Context: can sleep > + * > + * It returns zero on success, else operation state code. > + */ > +int rk1608_safe_read(struct spi_device *spi, > + s32 addr, s32 *data, size_t data_len) > +{ > + s32 state = 0; > + s32 retry = 0; > + > + do { > + rk1608_read(spi, addr, data, data_len); > + if (rk1608_operation_query(spi, &state) != 0) > + return -1; > + if ((state & RK1608_STATE_MASK) == 0) > + break; > + udelay(RK1608_OP_TRY_DELAY); > + } while (retry++ != RK1608_OP_TRY_MAX); > + > + return (state & RK1608_STATE_MASK); Same comments as for safe_write. > +} > + > +static int rk1608_read_wait(struct spi_device *spi, > + const struct rk1608_section *sec) > +{ > + s32 value = 0; > + int retry = 0; > + int ret = 0; > + > + do { > + ret = rk1608_safe_read(spi, sec->wait_addr, &value, 4); > + if (!ret && value == sec->wait_value) > + break; > + > + if (retry++ == sec->timeout) { > + ret = -1; Use a proper error code. > + dev_err(&spi->dev, "read 0x%x is %x != %x timeout\n", > + sec->wait_addr, value, sec->wait_value); > + break; > + } > + mdelay(sec->wait_time); > + } while (1); > + > + return ret; > +} > + > +static int rk1608_boot_request(struct spi_device *spi, > + const struct rk1608_section *sec) > +{ > + struct rk1608_boot_req boot_req; > + int retry = 0; > + int ret = 0; > + > + /*send boot request to rk1608 for ddr init*/ > + boot_req.flag = sec->flag; > + boot_req.load_addr = sec->load_addr; > + boot_req.boot_len = sec->size; > + boot_req.status = 1; > + boot_req.cmd = 2; > + > + ret = rk1608_safe_write(spi, BOOT_REQUEST_ADDR, > + (s32 *)&boot_req, sizeof(boot_req)); > + if (ret) > + return ret; > + > + if (sec->flag & BOOT_FLAG_READ_WAIT) { > + /*waitting for rk1608 init ddr done*/ > + do { > + ret = rk1608_safe_read(spi, BOOT_REQUEST_ADDR, > + (s32 *)&boot_req, > + sizeof(boot_req)); > + > + if (!ret && boot_req.status == 0) > + break; > + > + if (retry++ == sec->timeout) { > + ret = -1; Use a proper error code. > + dev_err(&spi->dev, "boot_request timeout\n"); > + break; > + } > + mdelay(sec->wait_time); > + } while (1); > + } > + > + return ret; > +} > + > +static int rk1608_download_section(struct spi_device *spi, const u8 *data, > + const struct rk1608_section *sec) > +{ > + int ret = 0; > + > + dev_info(&spi->dev, "offset:%x,size:%x,addr:%x,wait_time:%x", > + sec->offset, sec->size, sec->load_addr, sec->wait_time); > + dev_info(&spi->dev, "timeout:%x,crc:%x,flag:%x,type:%x", > + sec->timeout, sec->crc_16, sec->flag, sec->type); > + > + if (sec->size > 0) { > + ret = rk1608_safe_write(spi, sec->load_addr, > + (s32 *)(data + sec->offset), > + sec->size); > + if (ret) { > + dev_err(&spi->dev, "rk1608_safe_write err =%d\n", ret); > + return ret; > + } > + } > + > + if (sec->flag & BOOT_FLAG_BOOT_REQUEST) > + ret = rk1608_boot_request(spi, sec); > + else if (sec->flag & BOOT_FLAG_READ_WAIT) > + ret = rk1608_read_wait(spi, sec); > + > + return ret; > +} > + > +/** > + * rk1608_download_fw: - rk1608 firmware download through spi > + * > + * @spi: spi device > + * @fw_name: name of firmware file, NULL for default firmware name > + * Context: can sleep > + * > + * It returns zero on success, else a negative error code. > + **/ > +int rk1608_download_fw(struct spi_device *spi, const char *fw_name) > +{ > + const struct rk1608_header *head; > + const struct firmware *fw; > + int i = 0; > + int ret = 0; > + > + if (!fw_name) > + fw_name = RK1608_FW_NAME; > + > + dev_info(&spi->dev, "before request firmware"); > + ret = request_firmware(&fw, fw_name, &spi->dev); > + if (ret) { > + dev_err(&spi->dev, "request firmware %s failed!", fw_name); > + return ret; > + } > + > + head = (const struct rk1608_header *)fw->data; > + > + dev_info(&spi->dev, "request firmware %s (version:%s) success!", > + fw_name, head->version); > + > + for (i = 0; i < head->section_count; i++) { > + ret = rk1608_download_section(spi, fw->data, > + &head->sections[i]); > + if (ret) > + break; > + } > + > + release_firmware(fw); > + return ret; > +} > + > +int rk1608_lsb_w32(struct spi_device *spi, s32 addr, s32 data) > +{ > + s32 write_cmd = RK1608_CMD_WRITE; > + struct spi_transfer write_cmd_packet = { > + .tx_buf = &write_cmd, > + .len = sizeof(write_cmd), > + }; > + struct spi_transfer addr_packet = { > + .tx_buf = &addr, > + .len = sizeof(addr), > + }; > + struct spi_transfer data_packet = { > + .tx_buf = &data, > + .len = sizeof(data), > + }; > + struct spi_message m; > + > + write_cmd = MSB2LSB32(write_cmd); > + addr = MSB2LSB32(addr); > + data = MSB2LSB32(data); > + spi_message_init(&m); > + spi_message_add_tail(&write_cmd_packet, &m); > + spi_message_add_tail(&addr_packet, &m); > + spi_message_add_tail(&data_packet, &m); > + return spi_sync(spi, &m); > +} > + > +int rk1608_msg_init_sensor(struct rk1608_state *pdata, int id) > +{ > + struct msg_init *msg; > + > + msg = (struct msg_init *)devm_kzalloc(pdata->dev, > + sizeof(struct msg_init), > + GFP_KERNEL); No need for the cast. > + if (!msg) > + return -ENOMEM; > + msg->size = sizeof(struct msg_init); > + msg->type = id_msg_init_sensor_t; > + msg->camera_id = pdata->cd[id]->ci.cam_id; > + msg->sync = 1; > + msg->in_mipi_phy = pdata->cd[id]->ci.in_mipi; > + msg->out_mipi_phy = pdata->cd[id]->ci.out_mipi; > + msg->mipi_lane = pdata->cd[id]->ci.mipi_lane; > + msg->bayer = 0; > + memcpy((void *)msg->sensor_name, pdata->cd[id]->sd.name, 32); Use sizeof() instead of hardcoding to 32. No need for the void cast. > + > + msg->i2c_slave_addr = (pdata->cd[id]->client->addr) << 1; > + msg->i2c_bus = pdata->cd[id]->ci.i2c_bus; > + > + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); Two spaces after 'return': should be just one space. Doesn't this leak memory like a sieve? For every message you send you allocate a struct msg_init which won't be freed until the driver is unloaded. That looks seriously wrong. The same applied to all the other msg functions below. > +} > + > +int rk1608_msg_set_input_size(struct rk1608_state *pdata, int id) > +{ > + struct msg_in_size *msg; > + > + msg = (struct msg_in_size *)devm_kzalloc(pdata->dev, > + sizeof(struct msg_in_size), > + GFP_KERNEL); > + if (!msg) > + return -ENOMEM; > + msg->msg_head.size = sizeof(struct msg_in_size) / sizeof(int); > + msg->msg_head.type = id_msg_set_input_size_t; > + msg->msg_head.id.camera_id = pdata->cd[id]->ci.cam_id; > + msg->msg_head.mux.sync = 1; > + msg->channel.data_type = pdata->cd[id]->ci.data_type; > + msg->channel.decode_format = pdata->cd[id]->ci.data_type; > + msg->channel.width = pdata->cd[id]->ci.width; > + msg->channel.height = pdata->cd[id]->ci.height; > + msg->channel.flag = 1; > + > + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); > +} > + > +int rk1608_msg_set_output_size(struct rk1608_state *pdata, int id) > +{ > + struct msg_out_size *msg; > + > + msg = (struct msg_out_size *)devm_kzalloc(pdata->dev, > + sizeof(struct msg_out_size), > + GFP_KERNEL); > + if (!msg) > + return -ENOMEM; > + msg->size = sizeof(struct msg_out_size); > + msg->type = id_msg_set_output_size_t; > + msg->camera_id = pdata->cd[id]->ci.cam_id; > + msg->sync = 1; > + msg->width = pdata->cd[id]->ci.width; > + msg->height = pdata->cd[id]->ci.height; > + msg->mipi_clk = pdata->cd[id]->ci.mipi_clock; > + msg->line_length_pclk = pdata->cd[id]->ci.htotal; > + msg->frame_length_lines = pdata->cd[id]->ci.vtotal; > + > + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); > +} > + > +int rk1608_msg_set_stream_in_on(struct rk1608_state *pdata, int id) > +{ > + struct msg_t *msg; > + > + msg = (struct msg_t *)devm_kzalloc(pdata->dev, sizeof(struct msg_t), > + GFP_KERNEL); > + if (!msg) > + return -ENOMEM; > + msg->size = sizeof(struct msg_t); > + msg->type = id_msg_set_stream_in_on_t; > + msg->id.camera_id = pdata->cd[id]->ci.cam_id; > + msg->mux.sync = 1; > + > + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); > +} > + > +int rk1608_msg_set_stream_in_off(struct rk1608_state *pdata, int id) > +{ > + struct msg_t *msg; > + > + msg = (struct msg_t *)devm_kzalloc(pdata->dev, sizeof(struct msg_t), > + GFP_KERNEL); > + if (!msg) > + return -ENOMEM; > + msg->size = sizeof(struct msg_t); > + msg->type = id_msg_set_stream_in_off_t; > + msg->id.camera_id = pdata->cd[id]->ci.cam_id; > + msg->mux.sync = 1; > + > + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); > +} > + > +int rk1608_msg_set_stream_out_on(struct rk1608_state *pdata, int id) > +{ > + struct msg_t *msg; > + > + msg = (struct msg_t *)devm_kzalloc(pdata->dev, sizeof(struct msg_t), > + GFP_KERNEL); > + if (!msg) > + return -ENOMEM; > + msg->size = sizeof(struct msg_t); > + msg->type = id_msg_set_stream_out_on_t; > + msg->id.camera_id = pdata->cd[id]->ci.cam_id; > + msg->mux.sync = 1; > + > + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); > +} > + > +int rk1608_msg_set_stream_out_off(struct rk1608_state *pdata, int id) > +{ > + struct msg_t *msg; > + > + msg = (struct msg_t *)devm_kzalloc(pdata->dev, sizeof(struct msg_t), > + GFP_KERNEL); > + if (!msg) > + return -ENOMEM; > + msg->size = sizeof(struct msg_t); > + msg->type = id_msg_set_stream_out_off_t; > + msg->id.camera_id = pdata->cd[id]->ci.cam_id; > + msg->mux.sync = 1; > + > + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); > +} > + > +int rk1608_set_log_level(struct rk1608_state *pdata, int level) > +{ > + struct msg_t *msg; > + > + msg = (struct msg_t *)devm_kzalloc(pdata->dev, sizeof(struct msg_t), > + GFP_KERNEL); > + if (!msg) > + return -ENOMEM; > + msg->size = sizeof(struct msg_t); > + msg->type = id_msg_set_log_level_t; > + msg->mux.log_level = level; > + > + return rk1608_send_msg_to_dsp(pdata, (struct msg *)msg); > +} > + > +int rk1608_init_sensor(struct rk1608_state *pdata, int id) > +{ > + int ret; > + > + if (!pdata->cd) { > + dev_err(pdata->dev, "No find camera device!\n"); "No find camera" -> "Did not find a sensor" > + return -1; > + } > + > + ret = rk1608_msg_init_sensor(pdata, id); > + mdelay(20); > + ret |= rk1608_msg_set_input_size(pdata, id); > + ret |= rk1608_msg_set_output_size(pdata, id); > + ret |= rk1608_msg_set_stream_in_on(pdata, id); > + mdelay(30); These delays could do with a comment. Are these values determined by testing or are they derived from values from the datasheet? > + ret |= rk1608_msg_set_stream_out_on(pdata, id); > + > + return ret; > +} > + > +int rk1608_deinit(struct rk1608_state *pdata, int id) > +{ > + int ret; > + > + ret = rk1608_msg_set_stream_out_off(pdata, id); > + mdelay(30); > + ret |= rk1608_msg_set_stream_in_off(pdata, id); > + > + return ret; > +} > + > +void rk1608_cs_set_value(struct rk1608_state *pdata, int value) > +{ > + s8 null_cmd = 0; > + struct spi_transfer null_cmd_packet = { > + .tx_buf = &null_cmd, > + .len = sizeof(null_cmd), > + .cs_change = !value, > + }; > + struct spi_message m; > + > + spi_message_init(&m); > + spi_message_add_tail(&null_cmd_packet, &m); > + spi_sync(pdata->spi, &m); > +} > + > +void rk1608_set_spi_speed(struct rk1608_state *pdata, u32 hz) > +{ > + pdata->spi->max_speed_hz = hz; > +} > + > +static int rk1608_pin_power(struct rk1608_state *pdata, int on) > +{ > + unsigned int grf_val = 0; > + > + if (on) { > + clk_prepare_enable(pdata->pd_cif); > + clk_prepare_enable(pdata->aclk_cif); > + clk_prepare_enable(pdata->hclk_cif); > + clk_prepare_enable(pdata->cif_clk_in); > + clk_prepare_enable(pdata->cif_clk_out); > + clk_prepare_enable(pdata->clk_mipi_24m); > + clk_prepare_enable(pdata->hclk_mipiphy); > + clk_set_rate(pdata->cif_clk_out, RK1608_MCLK_RATE); > + > + clk_prepare_enable(pdata->mipi_clk); > + clk_set_rate(pdata->mipi_clk, RK1608_MCLK_RATE); > + > + gpio_direction_output(pdata->rst1, 0); > + mdelay(3); > + gpio_direction_output(pdata->rst1, 1); > + mdelay(5); > + gpio_direction_output(pdata->powerdown1, 1); > + > + gpio_direction_output(pdata->rst0, 0); > + mdelay(3); > + gpio_direction_output(pdata->rst0, 1); > + mdelay(5); > + gpio_direction_output(pdata->powerdown0, 1); > + > + pdata->grf_gpio2b_iomux = ioremap((resource_size_t) > + (GRF_BASE_ADDR + > + GRF_GPIO2B_IOMUX), 4); > + grf_val = __raw_readl(pdata->grf_gpio2b_iomux); > + __raw_writel(((grf_val) | (1 << 6) | (1 << (6 + 16))), > + pdata->grf_gpio2b_iomux); > + > + pdata->grf_io_vsel = ioremap((resource_size_t) > + (GRF_BASE_ADDR + GRF_IO_VSEL), 4); > + grf_val = __raw_readl(pdata->grf_io_vsel); > + __raw_writel(((grf_val) | (1 << 1) | (1 << (1 + 16))), > + pdata->grf_io_vsel); > + } else if (!on) { This is just 'else' of course. I would recommend making two functions rk1608_pin_power_on and rk1608_pin_power_off and call those from here. These 'if'/'else' parts are a bit too long for one function. > + grf_val = __raw_readl(pdata->grf_gpio2b_iomux); > + grf_val |= (1 << (6 + 16)); > + grf_val &= (~(1 << 6)); > + __raw_writel(grf_val, pdata->grf_gpio2b_iomux); > + iounmap(pdata->grf_gpio2b_iomux); > + > + grf_val = 0; > + grf_val = __raw_readl(pdata->grf_io_vsel); > + grf_val |= (1 << (1 + 16)); > + grf_val &= (~(1 << 1)); > + __raw_writel(grf_val, pdata->grf_io_vsel); > + iounmap(pdata->grf_io_vsel); > + > + gpio_direction_input(pdata->rst1); > + mdelay(3); > + gpio_direction_input(pdata->powerdown1); > + gpio_direction_input(pdata->rst0); > + mdelay(5); > + gpio_direction_input(pdata->powerdown0); > + > + clk_disable_unprepare(pdata->pd_cif); > + clk_disable_unprepare(pdata->aclk_cif); > + clk_disable_unprepare(pdata->hclk_cif); > + clk_disable_unprepare(pdata->cif_clk_in); > + clk_disable_unprepare(pdata->cif_clk_out); > + clk_disable_unprepare(pdata->clk_mipi_24m); > + clk_disable_unprepare(pdata->hclk_mipiphy); > + clk_disable_unprepare(pdata->mipi_clk); > + } > + return 0; > +} > + > +static int rk1608_sensor_power(struct v4l2_subdev *sd, int on) > +{ > + int ret = 0; > + struct rk1608_state *pdata = to_state(sd); > + struct spi_device *spi = pdata->spi; > + > + mutex_lock(&pdata->lock); > + rk1608_pin_power(pdata, on); > + /*start Sensor power on/off*/ > + if (pdata->cd[0]) > + pdata->cd[0]->sd.ops->core->s_power(&pdata->cd[0]->sd, on); > + if (pdata->cd[1]) > + pdata->cd[1]->sd.ops->core->s_power(&pdata->cd[1]->sd, on); Never call the ops directly. Instead use the v4l2_subdev_call() macro. > + > + if (on && !pdata->power_count) { > + clk_prepare_enable(pdata->mclk); > + clk_set_rate(pdata->mclk, RK1608_MCLK_RATE); > + /*request rk1608 enter slave mode*/ > + rk1608_cs_set_value(pdata, 0); > + if (pdata->powerdown_gpio > 0) { > + gpio_set_value(pdata->powerdown_gpio, > + pdata->powerdown_active); > + } > + if (pdata->wakeup_gpio > 0) { > + gpio_set_value(pdata->wakeup_gpio, > + pdata->wakeup_active); > + } No need for '{' and '}'. I think checkpatch.pl --strict will warn about that. Did you run that? > + mdelay(3); > + if (pdata->reset_gpio > 0) > + gpio_set_value(pdata->reset_gpio, pdata->reset_active); > + mdelay(5); Where do these delay values come from? > + rk1608_cs_set_value(pdata, 1); > + rk1608_lsb_w32(spi, SPI_ENR, 0); > + rk1608_lsb_w32(spi, SPI_CTRL0, > + OPM_SLAVE_MODE | RSD_SEL_2CYC | DFS_SEL_16BIT); > + rk1608_hw_init(pdata->spi); > + rk1608_set_spi_speed(pdata, pdata->max_speed_hz); > + > + /*download system firmware*/ > + ret = rk1608_download_fw(pdata->spi, NULL); > + > + if (ret) > + dev_err(pdata->dev, "Download firmware failed!"); > + else > + dev_info(pdata->dev, "Download firmware success!"); > + > + enable_irq(pdata->irq); > + if (pdata->sleepst_irq > 0) > + enable_irq(pdata->sleepst_irq); > + > + ret = rk1608_set_log_level(pdata, 2); > + } else if (!on && pdata->power_count == 1) { > + disable_irq(pdata->irq); > + if (pdata->sleepst_irq > 0) > + disable_irq(pdata->sleepst_irq); > + if (pdata->powerdown_gpio > 0) > + gpio_set_value(pdata->powerdown_gpio, > + !pdata->powerdown_active); > + > + if (pdata->wakeup_gpio > 0) > + gpio_set_value(pdata->wakeup_gpio, > + !pdata->wakeup_active); > + > + if (pdata->reset_gpio > 0) > + gpio_set_value(pdata->reset_gpio, !pdata->reset_active); > + > + rk1608_cs_set_value(pdata, 0); > + clk_disable_unprepare(pdata->mclk); > + } > + /* Update the power count. */ > + pdata->power_count += on ? 1 : -1; > + WARN_ON(pdata->power_count < 0); > + mutex_unlock(&pdata->lock); > + > + return ret; > +} > + > +static int rk1608_stream_on(struct rk1608_state *pdata) > +{ > + int id, cnt, ret = 0; > + > + for (id = 0; id < pdata->sensor_nums; id++) { > + ret = rk1608_init_sensor(pdata, id); > + if (ret) > + dev_err(pdata->dev, "init sensor[%d] is failed!", id); > + } > + /*Waiting for the sensor to be ready*/ > + while (pdata->sensor_cnt < pdata->sensor_nums) { > + /* TIMEOUT 10s break*/ > + if (cnt++ > SENSOR_TIMEOUT) { > + dev_err(pdata->dev, "Sensor%d is ready to timeout!", > + pdata->sensor_cnt); > + break; > + } > + mdelay(10); > + } > + > + if (pdata->sensor_nums) { > + if (pdata->sensor_cnt == pdata->sensor_nums) > + dev_info(pdata->dev, "Sensor(num %d) is ready!", > + pdata->sensor_cnt); > + } else { > + dev_warn(pdata->dev, "No sensor is found!"); > + } > + > + return 0; > +} > + > +static int rk1608_stream_off(struct rk1608_state *pdata) > +{ > + mutex_lock(&pdata->sensor_lock); > + pdata->sensor_cnt = 0; > + mutex_unlock(&pdata->sensor_lock); > + if (pdata->cd[0]) > + rk1608_deinit(pdata, 0); > + if (pdata->cd[1]) > + rk1608_deinit(pdata, 1); > + return 0; > +} > + > +static int rk1608_s_stream(struct v4l2_subdev *sd, int enable) > +{ > + int ret; > + struct rk1608_state *pdata = to_state(sd); > + > + if (enable) > + ret = rk1608_stream_on(pdata); > + else > + ret = rk1608_stream_off(pdata); > + > + if (pdata->cd[0]) > + ret |= pdata->cd[0]->sd.ops->video->s_stream(&pdata->cd[0]->sd, > + enable); > + if (pdata->cd[1]) > + ret |= pdata->cd[1]->sd.ops->video->s_stream(&pdata->cd[1]->sd, > + enable); > + return ret; > +} > + > +static int rk1608_enum_mbus_code(struct v4l2_subdev *sd, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_mbus_code_enum *code) > +{ > + struct rk1608_state *pdata = to_state(sd); > + struct camera_dev *cd = pdata->cd[0]; > + > + if (code->index > 0) > + return -EINVAL; > + > + code->code = cd->ci.code; > + > + return 0; > +} > + > +static int rk1608_get_fmt(struct v4l2_subdev *sd, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_format *fmt) > +{ > + struct v4l2_mbus_framefmt *mf = &fmt->format; > + struct rk1608_state *pdata = to_state(sd); > + struct camera_dev *cd = pdata->cd[0]; > + > + if (cd) { > + mf->code = cd->ci.code; > + mf->width = cd->ci.width; > + mf->height = cd->ci.height; > + mf->field = cd->ci.field; > + mf->colorspace = cd->ci.colorspace; > + } > + > + return 0; > +} > + > +static const struct v4l2_subdev_internal_ops rk1608_subdev_internal_ops = { > + .open = NULL, > +}; > + > +static const struct v4l2_subdev_video_ops rk1608_subdev_video_ops = { > + .s_stream = rk1608_s_stream, > +}; > + > +static const struct v4l2_subdev_pad_ops rk1608_subdev_pad_ops = { > + .enum_mbus_code = rk1608_enum_mbus_code, > + .get_fmt = rk1608_get_fmt, > +}; > + > +static const struct v4l2_subdev_core_ops rk1608_core_ops = { > + .s_power = rk1608_sensor_power, > +}; > + > +static const struct v4l2_subdev_ops rk1608_subdev_ops = { > + .core = &rk1608_core_ops, > + .video = &rk1608_subdev_video_ops, > + .pad = &rk1608_subdev_pad_ops, > +}; > + > +/** > + * rk1608_msq_read_head - read rk1608 msg queue head > + * > + * @spi: spi device > + * @addr: msg queue head addr > + * @m: msg queue pointer > + * > + * It returns zero on success, else a negative error code. > + */ > +int rk1608_msq_read_head(struct spi_device *spi, > + u32 addr, struct rk1608_msg_queue *q) > +{ > + int err = 0; > + s32 reg; > + > + err = rk1608_safe_read(spi, RK1608_PMU_SYS_REG0, ®, 4); > + > + if (err || ((reg & RK1608_MSG_QUEUE_OK_MASK) != > + RK1608_MSG_QUEUE_OK_TAG)) > + return -1; > + > + err = rk1608_safe_read(spi, addr, (s32 *)q, sizeof(*q)); > + > + return err; > +} > + > +/** > + * rk1608_msq_recv_msg - receive a msg from RK1608 -> AP msg queue > + * > + * @q: msg queue > + * @m: a msg pointer buf [out] > + * > + * need call rk1608_msq_recv_msg_free to free msg after msg use done > + * > + * It returns zero on success, else a negative error code. > + */ > +int rk1608_msq_recv_msg(struct spi_device *spi, struct msg **m) > +{ > + struct rk1608_msg_queue queue; > + struct rk1608_msg_queue *q = &queue; > + u32 size = 0, msg_size = 0; > + u32 recv_addr = 0; > + u32 next_recv_addr = 0; > + int err = 0; > + > + *m = NULL; > + err = rk1608_msq_read_head(spi, RK1608_S_MSG_QUEUE_ADDR, q); > + if (err) > + return err; > + > + if (q->cur_send == q->cur_recv) > + return -1; > + /*skip to head when size is 0*/ > + err = rk1608_safe_read(spi, (s32)q->cur_recv, (s32 *)&size, 4); > + if (err) > + return err; > + if (size == 0) { > + err = rk1608_safe_read(spi, (s32)q->buf_head, (s32 *)&size, 4); > + if (err) > + return err; > + > + msg_size = size * sizeof(u32); > + recv_addr = q->buf_head; > + next_recv_addr = q->buf_head + msg_size; > + } else { > + msg_size = size * sizeof(u32); > + recv_addr = q->cur_recv; > + next_recv_addr = q->cur_recv + msg_size; > + if (next_recv_addr == q->buf_tail) > + next_recv_addr = q->buf_head; > + } > + > + if (msg_size > (q->buf_tail - q->buf_head)) > + return -2; Return a proper error code. > + > + *m = kmalloc(msg_size, GFP_KERNEL); > + err = rk1608_safe_read(spi, recv_addr, (s32 *)*m, msg_size); > + if (err == 0) { > + err = rk1608_safe_write(spi, RK1608_S_MSG_QUEUE_ADDR + > + (u8 *)&q->cur_recv - (u8 *)q, > + &next_recv_addr, 4); > + } > + if (err) > + kfree(*m); > + > + return err; > +} > + > +/** > + * rk1608_msq_tail_free_size - get msg queue tail unused buf size > + * > + * @q: msg queue > + * > + * It returns size of msg queue tail unused buf size, unit byte > + */ > +u32 rk1608_msq_tail_free_size(const struct rk1608_msg_queue *q) > +{ > + if (q->cur_send >= q->cur_recv) > + return (q->buf_tail - q->cur_send); > + > + return q->cur_recv - q->cur_send; > +} > + > +/** > + * spi2apb_interrupt_request - SPI2APB request a dsp interrupt > + * > + * @spi: spi device > + * @interrupt_num: interrupt identification > + * Context: can sleep > + * > + * It returns zero on success, else a negative error code. > + */ > +int spi2apb_interrupt_request(struct spi_device *spi, > + s32 interrupt_num) > +{ > + s32 write_reg1_cmd = APB_CMD_WRITE_REG1; > + struct spi_transfer write_reg1_cmd_packet = { > + .tx_buf = &write_reg1_cmd, > + .len = sizeof(write_reg1_cmd), > + }; > + struct spi_transfer reg1_packet = { > + .tx_buf = &interrupt_num, > + .len = sizeof(interrupt_num), > + }; > + struct spi_message m; > + > + spi_message_init(&m); > + spi_message_add_tail(&write_reg1_cmd_packet, &m); > + spi_message_add_tail(®1_packet, &m); > + return spi_sync(spi, &m); > +} > + > +/** > + * dsp_msq_head_free_size - get msg queue head unused buf size > + * > + * @q: msg queue > + * > + * It returns size of msg queue head unused buf size, unit byte > + */ > +u32 rk1608_msq_head_free_size(const struct rk1608_msg_queue *q) > +{ > + if (q->cur_send >= q->cur_recv) > + return (q->cur_recv - q->buf_head); > + > + return 0; > +} > + > +/** > + * rk1608_msq_send_msg - send a msg to Soc -> DSP msg queue > + * > + * @spi: spi device > + * @m: a msg to send > + * > + * It returns zero on success, else a negative error code. > + */ > +int rk1608_msq_send_msg(struct spi_device *spi, const struct msg *m) > +{ > + int err = 0; > + struct rk1608_msg_queue queue; > + struct rk1608_msg_queue *q = &queue; > + u32 msg_size = m->size * sizeof(u32); > + > + err = rk1608_msq_read_head(spi, RK1608_R_MSG_QUEUE_ADDR, q); > + if (err) > + return err; > + > + if (rk1608_msq_tail_free_size(q) > msg_size) { > + u32 next_send; > + > + err = rk1608_safe_write(spi, q->cur_send, (s32 *)m, msg_size); > + next_send = q->cur_send + msg_size; > + if (next_send == q->buf_tail) > + next_send = q->buf_head; > + q->cur_send = next_send; > + } else if (rk1608_msq_head_free_size(q) > msg_size) { > + /* set size to 0 for skip to head mark */ > + err = rk1608_safe_write(spi, q->cur_send, > + (s32 *)NULL, 4); > + if (err) > + return err; > + err = rk1608_safe_write(spi, q->buf_head, > + (s32 *)m, msg_size); > + q->cur_send = q->buf_head + msg_size; > + } else { > + return -1; > + } > + > + if (err) > + return err; > + > + err = rk1608_safe_write(spi, RK1608_R_MSG_QUEUE_ADDR + > + (u8 *)&q->cur_send - (u8 *)q, &q->cur_send, 4); > + spi2apb_interrupt_request(spi, RK1608_IRQ_TYPE_MSG); > + return err; > +} > + > +int rk1608_send_msg_to_dsp(struct rk1608_state *pdata, const struct msg *m) > +{ > + int ret = 0; > + int msg_num; > + int timeout; > + int readval; > + > + /* for msg sync */ > + if (pdata->msg_num >= 8) { > + dev_err(pdata->dev, "msg sync queue full\n!"); > + ret = -EINVAL; > + } else if (m->sync == 1) { > + mutex_lock(&pdata->send_msg_lock); > + msg_num = pdata->msg_num; > + atomic_set(&pdata->msg_done[pdata->msg_num++], 0); > + mutex_unlock(&pdata->send_msg_lock); > + } > + > + mutex_lock(&pdata->send_msg_lock); > + ret = rk1608_msq_send_msg(pdata->spi, m); > + mutex_unlock(&pdata->send_msg_lock); > + > + /* for msg sync */ > + if (m->sync == 1) { > + readval = atomic_read(&pdata->msg_done[msg_num]); > + timeout = wait_event_timeout(pdata->msg_wait, readval, > + MSG_SYNC_TIMEOUT); > + if (unlikely(timeout <= 0)) { > + dev_info(pdata->dev, "msg_wait timeout %d msg_num:%d\n", > + timeout, pdata->msg_num); > + mutex_lock(&pdata->send_msg_lock); > + atomic_set(&pdata->msg_done[msg_num], 0); > + mutex_unlock(&pdata->send_msg_lock); > + } > + } > + > + return ret; > +} > + > +static void print_rk1608_log(struct rk1608_state *pdata, > + struct msg_rk1608_log_t *log) > +{ > + char *str = (char *)(log); > + > + str[log->size * sizeof(s32) - 1] = 0; > + str += sizeof(struct msg_rk1608_log_t); > + dev_info(pdata->dev, "RK1608(%d): %s", log->core_id, str); > +} > + > +void int32_hexdump(const char *prefix, s32 *data, int len) > +{ > + pr_err("%s\n", prefix); > + print_hex_dump(KERN_ERR, "offset ", DUMP_PREFIX_OFFSET, > + 16, 4, data, len, false); > + pr_err("\n"); > +} > + > +static void dispatch_received_msg(struct rk1608_state *pdata, > + struct msg *msg) > +{ > + #if DEBUG_DUMP_ALL_SEND_RECV_MSG == 1 > + int32_hexdump("recv msg:", (s32 *)msg, msg->size * 4); > + #endif > + if (msg->type == id_msg_set_stream_out_on_ret_t) { > + mutex_lock(&pdata->sensor_lock); > + pdata->sensor_cnt++; > + mutex_unlock(&pdata->sensor_lock); > + } > + > + if (msg->type == id_msg_rk1608_log_t) > + print_rk1608_log(pdata, (struct msg_rk1608_log_t *)msg); > +} > + > +static irqreturn_t rk1608_threaded_isr(int irq, void *dev_id) > +{ > + struct rk1608_state *pdata = dev_id; > + struct msg *msg; > + > + WARN_ON(irq != pdata->irq); > + while (!rk1608_msq_recv_msg(pdata->spi, &msg) && NULL != msg) { > + dispatch_received_msg(pdata, msg); > + /* for kernel msg sync */ > + if (pdata->msg_num != 0 && msg->sync) { > + dev_info(pdata->dev, "rk1608 kernel sync\n"); > + mutex_lock(&pdata->send_msg_lock); > + pdata->msg_num--; > + atomic_set(&pdata->msg_done[pdata->msg_num], 1); > + mutex_unlock(&pdata->send_msg_lock); > + wake_up(&pdata->msg_wait); > + } > + kfree(msg); > + } > + > + return IRQ_HANDLED; > +} > + > +static irqreturn_t rk1608_sleep_isr(int irq, void *dev_id) > +{ > + struct rk1608_state *pdata = dev_id; > + > + WARN_ON(irq != pdata->sleepst_irq); > + if (pdata->powerdown_gpio > 0) > + gpio_set_value(pdata->powerdown_gpio, !pdata->powerdown_active); > + > + return IRQ_HANDLED; > +} > + > +static int rk1608_parse_dt_property(struct rk1608_state *pdata) > +{ > + int ret = 0; > + int i; > + struct device *dev = pdata->dev; > + struct device_node *node = dev->of_node; > + enum of_gpio_flags flags; > + > + if (!node) > + return 1; > + > + ret = of_property_read_u32(node, "spi-max-frequency", > + &pdata->max_speed_hz); > + if (ret) { > + dev_warn(dev, "can not get spi-max-frequency!"); > + pdata->max_speed_hz = RK1608_MCLK_RATE; > + } > + ret = of_property_read_u64(node, "link-freqs", > + &pdata->link_freqs); > + if (ret) > + dev_warn(dev, "can not get link_freqs!"); > + pdata->mipi_clk = devm_clk_get(dev, "mipi_clk"); > + if (IS_ERR(pdata->mipi_clk)) { > + dev_err(dev, "can not get mipi_clk, error %ld\n", > + PTR_ERR(pdata->mipi_clk)); > + pdata->mipi_clk = NULL; > + } > + pdata->pd_cif = devm_clk_get(dev, "pd_cif"); > + if (IS_ERR(pdata->pd_cif)) { > + dev_err(dev, "can not get pd_cif, error %ld\n", > + PTR_ERR(pdata->pd_cif)); > + pdata->pd_cif = NULL; > + } > + pdata->aclk_cif = devm_clk_get(dev, "aclk_cif"); > + if (IS_ERR(pdata->aclk_cif)) { > + dev_err(dev, "can not get aclk_cif, error %ld\n", > + PTR_ERR(pdata->aclk_cif)); > + pdata->aclk_cif = NULL; > + } > + pdata->hclk_cif = devm_clk_get(dev, "hclk_cif"); > + if (IS_ERR(pdata->hclk_cif)) { > + dev_warn(dev, "can not get hclk_cif, error %ld\n", > + PTR_ERR(pdata->hclk_cif)); > + pdata->hclk_cif = NULL; > + } > + pdata->cif_clk_in = devm_clk_get(dev, "cif0_in"); > + if (IS_ERR(pdata->cif_clk_in)) { > + dev_err(dev, "can not get cif_clk_in, error %ld\n", > + PTR_ERR(pdata->cif_clk_in)); > + pdata->cif_clk_in = NULL; > + } > + pdata->cif_clk_out = devm_clk_get(dev, "cif0_out"); > + if (IS_ERR(pdata->cif_clk_out)) { > + dev_err(dev, "can not get cif_clk_out, error %ld\n", > + PTR_ERR(pdata->cif_clk_out)); > + pdata->cif_clk_out = NULL; > + } > + pdata->clk_mipi_24m = devm_clk_get(dev, "clk_mipi_24m"); > + if (IS_ERR(pdata->clk_mipi_24m)) { > + dev_err(dev, "can not get clk_mipi_24m, error %ld\n", > + PTR_ERR(pdata->clk_mipi_24m)); > + pdata->clk_mipi_24m = NULL; > + } > + pdata->hclk_mipiphy = devm_clk_get(dev, "hclk_mipiphy"); > + if (IS_ERR(pdata->hclk_mipiphy)) { > + dev_err(dev, "can not get hclk_mipiphy, error %ld\n", > + PTR_ERR(pdata->hclk_mipiphy)); > + pdata->hclk_mipiphy = NULL; > + } > + pdata->mclk = devm_clk_get(dev, "mclk"); > + if (IS_ERR(pdata->mclk)) { > + dev_err(dev, "can not get mclk, error %ld\n", > + PTR_ERR(pdata->mclk)); > + pdata->mclk = NULL; > + } > + ret = of_get_named_gpio_flags(node, "rockchip,reset1", 0, &flags); > + if (ret <= 0) > + dev_err(dev, "can not find reset1 error %d\n", ret); > + pdata->rst1 = ret; > + > + ret = devm_gpio_request(dev, pdata->rst1, "rockchip-reset1"); > + if (ret) { > + dev_err(dev, "gpio pdata->rst1 %d request error %d\n", > + pdata->rst1, ret); > + return ret; > + } > + gpio_set_value(pdata->rst1, 0); > + ret = gpio_direction_output(pdata->rst1, 0); > + if (ret) { > + dev_err(dev, "gpio %d direction output error %d\n", > + pdata->rst1, ret); > + return ret; > + } > + > + ret = of_get_named_gpio_flags(node, "rockchip,powerdown1", 0, &flags); > + if (ret <= 0) > + dev_warn(dev, "can not find powerdown1, error %d\n", ret); > + > + pdata->powerdown1 = ret; > + ret = devm_gpio_request(dev, pdata->powerdown1, "rockchip-powerdown1"); > + if (ret) { > + dev_err(dev, "gpio pdata->powerdown1 %d request error %d\n", > + pdata->powerdown1, ret); > + return ret; > + } > + > + ret = gpio_direction_output(pdata->powerdown1, 0); > + if (ret) { > + dev_err(dev, "gpio %d direction output error %d\n", > + pdata->powerdown1, ret); > + return ret; > + } > + > + ret = of_get_named_gpio_flags(node, "rockchip,reset0", 0, &flags); > + if (ret <= 0) > + dev_warn(dev, > + "can not find property rockchip,reset0, error %d\n", > + ret); > + pdata->rst0 = ret; > + ret = devm_gpio_request(dev, pdata->rst0, "rockchip-reset0"); > + if (ret) { > + dev_err(dev, "gpio pdata->rst0 %d request error %d\n", > + pdata->rst0, ret); > + return ret; > + } > + gpio_set_value(pdata->rst0, 0); > + ret = gpio_direction_output(pdata->rst0, 0); > + if (ret) { > + dev_err(dev, "gpio0 %d direction output error %d\n", > + pdata->rst0, ret); > + return ret; > + } > + > + ret = of_get_named_gpio_flags(node, "rockchip,powerdown0", 0, &flags); > + if (ret <= 0) > + dev_warn(dev, "can not find powerdown0,error %d\n", ret); > + > + pdata->powerdown0 = ret; > + > + ret = devm_gpio_request(dev, pdata->powerdown0, "rockchip-powerdown0"); > + if (ret) { > + dev_err(dev, "gpio pdata->powerdown0 %d request error %d\n", > + pdata->powerdown0, ret); > + return ret; > + } > + > + ret = gpio_direction_output(pdata->powerdown0, 0); > + if (ret) { > + dev_err(dev, "gpio0 %d direction output error %d\n", > + pdata->powerdown0, ret); > + return ret; > + } > + pdata->mclk = devm_clk_get(dev, "mclk"); > + if (IS_ERR(pdata->mclk)) { > + dev_err(dev, "can not get mclk, error %ld\n", > + PTR_ERR(pdata->mclk)); > + pdata->mclk = NULL; > + return -1; > + } > + > + ret = of_get_named_gpio_flags(node, "reset-gpio", 0, &flags); > + if (ret <= 0) { > + dev_warn(dev, "can not find reset-gpio, error %d\n", ret); > + return ret; > + } > + pdata->reset_gpio = ret; > + pdata->reset_active = 1; > + if (flags == OF_GPIO_ACTIVE_LOW) > + pdata->reset_active = 0; > + > + if (pdata->reset_gpio > 0) { > + ret = devm_gpio_request(dev, pdata->reset_gpio, "rk1608-reset"); > + if (ret) { > + dev_err(dev, "gpio %d request error %d\n", > + pdata->reset_gpio, ret); > + return ret; > + } > + > + ret = gpio_direction_output(pdata->reset_gpio, > + !pdata->reset_active); > + if (ret) { > + dev_err(dev, "gpio %d direction output error %d\n", > + pdata->reset_gpio, ret); > + return ret; > + } > + } > + > + ret = of_get_named_gpio_flags(node, "irq-gpio", 0, NULL); > + if (ret <= 0) { > + dev_warn(dev, "can not find irq-gpio, error %d\n", ret); > + return ret; > + } > + > + pdata->irq_gpio = ret; > + > + ret = devm_gpio_request(dev, pdata->irq_gpio, "rk1608-irq"); > + if (ret) { > + dev_err(dev, "gpio %d request error %d\n", pdata->irq_gpio, > + ret); > + return ret; > + } > + > + ret = gpio_direction_input(pdata->irq_gpio); > + if (ret) { > + dev_err(dev, "gpio %d direction input error %d\n", > + pdata->irq_gpio, ret); > + return ret; > + } > + > + ret = gpio_to_irq(pdata->irq_gpio); > + if (ret < 0) { > + dev_err(dev, "Unable to get irq number for GPIO %d, error %d\n", > + pdata->irq_gpio, ret); > + return ret; > + } > + pdata->irq = ret; > + ret = request_threaded_irq(pdata->irq, NULL, rk1608_threaded_isr, > + IRQF_TRIGGER_RISING | IRQF_ONESHOT, > + "rk1608-irq", pdata); > + if (ret) { > + dev_err(dev, "cannot request thread irq: %d\n", ret); > + return ret; > + } > + > + disable_irq(pdata->irq); > + > + ret = of_get_named_gpio_flags(node, "powerdown-gpio", 0, &flags); > + if (ret <= 0) > + dev_warn(dev, "can not find powerdown-gpio, error %d\n", ret); > + > + pdata->powerdown_gpio = ret; > + pdata->powerdown_active = 1; > + if (flags == OF_GPIO_ACTIVE_LOW) > + pdata->powerdown_active = 0; > + > + if (pdata->powerdown_gpio > 0) { > + ret = devm_gpio_request(dev, pdata->powerdown_gpio, > + "rk1608-powerdown"); > + if (ret) { > + dev_err(dev, "gpio %d request error %d\n", > + pdata->powerdown_gpio, ret); > + return ret; > + } > + > + ret = gpio_direction_output(pdata->powerdown_gpio, > + !pdata->powerdown_active); > + if (ret) { > + dev_err(dev, "gpio %d direction output error %d\n", > + pdata->powerdown_gpio, ret); > + return ret; > + } > + } > + > + pdata->sleepst_gpio = -1; > + pdata->sleepst_irq = -1; > + pdata->wakeup_gpio = -1; > + > + ret = of_get_named_gpio_flags(node, "sleepst-gpio", 0, NULL); > + if (ret <= 0) { > + dev_warn(dev, "can not find property sleepst-gpio, error %d\n", > + ret); > + return ret; > + } > + > + pdata->sleepst_gpio = ret; > + > + ret = devm_gpio_request(dev, pdata->sleepst_gpio, "rk1608-sleep-irq"); > + if (ret) { > + dev_err(dev, "gpio %d request error %d\n", > + pdata->sleepst_gpio, ret); > + return ret; > + } > + > + ret = gpio_direction_input(pdata->sleepst_gpio); > + if (ret) { > + dev_err(dev, "gpio %d direction input error %d\n", > + pdata->sleepst_gpio, ret); > + return ret; > + } > + > + ret = gpio_to_irq(pdata->sleepst_gpio); > + if (ret < 0) { > + dev_err(dev, "Unable to get irq number for GPIO %d, error %d\n", > + pdata->sleepst_gpio, ret); > + return ret; > + } > + pdata->sleepst_irq = ret; > + ret = request_any_context_irq(pdata->sleepst_irq, > + rk1608_sleep_isr, > + IRQF_TRIGGER_RISING, > + "rk1608-sleepst", pdata); > + disable_irq(pdata->sleepst_irq); > + > + ret = of_get_named_gpio_flags(node, "wakeup-gpio", 0, &flags); > + if (ret <= 0) > + dev_warn(dev, "can not find wakeup-gpio error %d\n", ret); > + > + pdata->wakeup_gpio = ret; > + pdata->wakeup_active = 1; > + if (flags == OF_GPIO_ACTIVE_LOW) > + pdata->wakeup_active = 0; > + > + if (pdata->wakeup_gpio > 0) { > + ret = devm_gpio_request(dev, pdata->wakeup_gpio, > + "rk1608-wakeup"); > + if (ret) { > + dev_err(dev, "gpio %d request error %d\n", > + pdata->wakeup_gpio, ret); > + return ret; > + } > + > + ret = gpio_direction_output(pdata->wakeup_gpio, > + !pdata->wakeup_active); > + if (ret) { > + dev_err(dev, "gpio %d direction output error %d\n", > + pdata->wakeup_gpio, ret); > + return ret; > + } > + } > + pdata->msg_num = 0; > + init_waitqueue_head(&pdata->msg_wait); > + for (i = 0; i < 8; i++) > + atomic_set(&pdata->msg_done[i], 0); > + > + return ret; > +} > + > +static int get_remote_node_dev(struct rk1608_state *pdev) > +{ > + struct i2c_client *sensor_pdev = NULL; > + struct device *dev = pdev->dev; > + struct device_node *parent = dev->of_node; > + struct device_node *node, *pre_node = NULL; > + struct device_node *remote = NULL; > + int ret, sensor_nums = 0; > + > + node = of_graph_get_next_endpoint(parent, pre_node); > + if (node) { > + of_node_put(pre_node); > + pre_node = node; > + } else { > + dev_err(dev, "fieled to get endpoint\n"); > + return -EINVAL; > + } > + while ((node = of_graph_get_next_endpoint(parent, pre_node)) != NULL) { > + of_node_put(pre_node); > + pre_node = node; > + remote = of_graph_get_remote_port_parent(node); > + if (!remote) { > + dev_err(dev, "%s: no valid device\n", __func__); > + of_node_put(remote); > + ret = -EINVAL; > + } > + > + sensor_pdev = of_find_i2c_device_by_node(remote); > + of_node_put(remote); > + > + if (!sensor_pdev) { > + dev_err(dev, "fieled to get Sensor device\n"); fieled -> failed > + ret = -EINVAL; > + } else { > + pdev->cd[sensor_nums] = i2c_get_clientdata(sensor_pdev); > + if (pdev->cd[sensor_nums]) > + sensor_nums++; > + else > + dev_err(dev, "fieled to get Sensor drvdata\n"); Ditto. > + ret = 0; > + } > + } > + pdev->sensor_nums = sensor_nums; > + if (pdev->sensor_nums) > + dev_info(dev, "get Sensor (nums=%d) dev is OK!\n", > + pdev->sensor_nums); > + > + return ret; > +} > + > +static int rk1608_probe(struct spi_device *spi) > +{ > + struct rk1608_state *rk1608; > + struct v4l2_subdev *sd; > + struct v4l2_ctrl_handler *handler; > + > + int ret; > + > + rk1608 = devm_kzalloc(&spi->dev, sizeof(*rk1608), GFP_KERNEL); > + if (!rk1608) > + return -ENOMEM; > + rk1608->dev = &spi->dev; > + rk1608->spi = spi; > + spi_set_drvdata(spi, rk1608); > + ret = rk1608_parse_dt_property(rk1608); > + if (ret) { > + dev_err(rk1608->dev, "rk1608 parse dt property err(%x)\n", ret); > + goto parse_err; > + } > + ret = get_remote_node_dev(rk1608); > + if (ret) > + dev_warn(rk1608->dev, "get remote node dev err(%x)\n", ret); > + rk1608->sensor_cnt = 0; > + mutex_init(&rk1608->sensor_lock); > + mutex_init(&rk1608->send_msg_lock); > + mutex_init(&rk1608->lock); > + sd = &rk1608->sd; > + v4l2_spi_subdev_init(sd, spi, &rk1608_subdev_ops); > + > + handler = &rk1608->ctrl_handler; > + ret = v4l2_ctrl_handler_init(handler, 1); > + if (ret) > + goto handler_init_err; > + > + rk1608->link_freq = v4l2_ctrl_new_int_menu(handler, NULL, > + V4L2_CID_LINK_FREQ, > + 0, 0, &rk1608->link_freqs); > + if (rk1608->link_freq) > + rk1608->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY; > + > + if (handler->error) > + goto handler_err; > + > + sd->ctrl_handler = handler; > + sd->internal_ops = &rk1608_subdev_internal_ops; > + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; Does the platform driver expose this subdev as a /dev/v4l-subdevX device node? If so, then you can test it with v4l2-compliance (-u option). Recently I added support for testing v4l-subdev devices to the compliance tests. This is still early days and it relies on core fixes that have not been merged yet: https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=media-fixes I hope that they will be merged soon, though (this week). > + > + rk1608->pad.flags = MEDIA_PAD_FL_SOURCE; > + sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; Did you compile against the mainline code? This define isn't available anymore for kernel drivers. Instead you should do: sd->entity.function = MEDIA_ENT_F_CAM_SENSOR; > + > + ret = media_entity_init(&sd->entity, 1, &rk1608->pad, 0); > + if (ret < 0) > + goto handler_err; > + > + ret = v4l2_async_register_subdev(sd); > + if (ret < 0) > + goto register_err; > + dev_info(rk1608->dev, "DSP rk1608 Driver probe is OK!\n"); > + > + return 0; > +register_err: > + media_entity_cleanup(&sd->entity); > +handler_err: > + v4l2_ctrl_handler_free(handler); > +handler_init_err: > + v4l2_device_unregister_subdev(&rk1608->sd); > + mutex_destroy(&rk1608->lock); > + mutex_destroy(&rk1608->send_msg_lock); > + mutex_destroy(&rk1608->sensor_lock); > +parse_err: > + kfree(rk1608); > + return ret; > +} > + > +static int rk1608_remove(struct spi_device *spi) > +{ > + struct rk1608_state *rk1608 = spi_get_drvdata(spi); > + > + v4l2_async_unregister_subdev(&rk1608->sd); > + media_entity_cleanup(&rk1608->sd.entity); > + v4l2_ctrl_handler_free(&rk1608->ctrl_handler); > + v4l2_device_unregister_subdev(&rk1608->sd); > + mutex_destroy(&rk1608->lock); > + mutex_destroy(&rk1608->send_msg_lock); > + mutex_destroy(&rk1608->sensor_lock); > + kfree(rk1608); > + > + return 0; > +} > + > +static const struct spi_device_id rk1608_id[] = { > + { "RK1608", 0 }, > + { } > +}; > +MODULE_DEVICE_TABLE(spi, rk1608_id); > + > +#if IS_ENABLED(CONFIG_OF) > +static const struct of_device_id rk1608_of_match[] = { > + { .compatible = "rockchip,rk1608" }, > + { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, rk1608_of_match); > +#endif > + > +static struct spi_driver rk1608_driver = { > + .driver = { > + .of_match_table = of_match_ptr(rk1608_of_match), > + .name = "RK1608", > + }, > + .probe = rk1608_probe, > + .remove = rk1608_remove, > + .id_table = rk1608_id, > +}; > + > +module_spi_driver(rk1608_driver); > + > +MODULE_AUTHOR("Rockchip Camera/ISP team"); > +MODULE_DESCRIPTION("A DSP driver for rk1608 chip"); > +MODULE_LICENSE("Dual BSD/GPL"); The SPDX tag says GPL-2.0, this says Dual BSD/GPL. Something isn't right. > diff --git a/drivers/media/spi/rk1608.h b/drivers/media/spi/rk1608.h > new file mode 100644 > index 0000000..bbfa9ad > --- /dev/null > +++ b/drivers/media/spi/rk1608.h > @@ -0,0 +1,471 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/** > + * Rockchip rk1608 driver > + * > + * Copyright (C) 2017 Rockchip Electronics Co., Ltd. > + * > + */ > + > +#ifndef __RK1608_H__ > +#define __RK1608_H__ > + > +#include <linux/i2c.h> > +#include <linux/string.h> > +#include <linux/spi/spi.h> > +#include <linux/types.h> > + > +#define RK1608_OP_TRY_MAX 3 > +#define RK1608_OP_TRY_DELAY 10 > +#define RK1608_CMD_WRITE 0x00000011 > +#define RK1608_CMD_WRITE_REG0 0X00010011 > +#define RK1608_CMD_WRITE_REG1 0X00020011 > +#define RK1608_CMD_READ 0x00000077 > +#define RK1608_CMD_READ_BEGIN 0x000000aa > +#define RK1608_CMD_QUERY 0x000000ff > +#define RK1608_CMD_QUERY_REG2 0x000001ff > +#define RK1608_STATE_ID_MASK 0xffff0000 > +#define RK1608_STATE_ID 0X16080000 > +#define RK1608_STATE_MASK 0x0000ffff > +#define APB_CMD_WRITE_REG1 0X00020011 > +#define RK1608_R_MSG_QUEUE_ADDR 0x60050000 > + > +#define RK1608_IRQ_TYPE_MSG 0x12345678 > +#define BOOT_REQUEST_ADDR 0x18000010 > +#define RK1608_HEAD_ADDR 0x60000000 > +#define RK1608_FW_NAME "rk1608.rkl" > +#define RK1608_S_MSG_QUEUE_ADDR 0x60050010 > +#define RK1608_PMU_SYS_REG0 0x120000f0 > +#define RK1608_MSG_QUEUE_OK_MASK 0xffff0001 > +#define RK1608_MSG_QUEUE_OK_TAG 0x16080001 > +#define RK1608_MAX_OP_BYTES 60000 > +#define MSG_SYNC_TIMEOUT 50 > + > +#define BOOT_FLAG_CRC (0x01 << 0) > +#define BOOT_FLAG_EXE (0x01 << 1) > +#define BOOT_FLAG_LOAD_PMEM (0x01 << 2) > +#define BOOT_FLAG_ACK (0x01 << 3) > +#define BOOT_FLAG_READ_WAIT (0x01 << 4) > +#define BOOT_FLAG_BOOT_REQUEST (0x01 << 5) > + > +#define DEBUG_DUMP_ALL_SEND_RECV_MSG 0 > +#define RK1608_MCLK_RATE (24 * 1000 * 1000ul) > +#define SENSOR_TIMEOUT 1000 > +#define GRF_BASE_ADDR 0xff770000 > +#define GRF_GPIO2B_IOMUX 0x0014 > +#define GRF_IO_VSEL 0x0380 > + > +#define OPM_SLAVE_MODE 0X100000 > +#define RSD_SEL_2CYC 0X008000 > +#define DFS_SEL_16BIT 0X000002 > +#define SPI_CTRL0 0x11060000 > +#define SPI_ENR 0x11060008 > +#define CRUPMU_CLKSEL14_CON 0x12008098 > +#define PMUGRF_GPIO1A_E 0x12030040 > +#define PMUGRF_GPIO1B_E 0x12030044 > +#define BIT7_6_SEL_8MA 0xf000a000 > +#define BIT1_0_SEL_8MA 0x000f000a > +#define SPI0_PLL_SEL_APLL 0xff004000 > +#define INVALID_ID -1 > +#define RK1608_MAX_SEC_NUM 10 > + > +#ifndef MIN > +#define MIN(a, b) ((a) < (b) ? (a) : (b)) > +#endif > + > +#ifndef MSB2LSB32 > +#define MSB2LSB32(x) ((((u32)x & 0x80808080) >> 7) | \ > + (((u32)x & 0x40404040) >> 5) | \ > + (((u32)x & 0x20202020) >> 3) | \ > + (((u32)x & 0x10101010) >> 1) | \ > + (((u32)x & 0x08080808) << 1) | \ > + (((u32)x & 0x04040404) << 3) | \ > + (((u32)x & 0x02020202) << 5) | \ > + (((u32)x & 0x01010101) << 7)) > +#endif > + > +struct camera_info { > + s8 cam_id; > + s8 in_mipi; > + s8 out_mipi; > + s8 mipi_lane; > + u8 i2c_bus; > + u8 data_type; > + u8 field; > + u8 colorspace; > + u16 code; > + u16 width; > + u16 height; > + u16 htotal; > + u16 vtotal; > + u32 mipi_clock; > +}; > + > +struct camera_dev { > + struct v4l2_subdev sd; > + struct i2c_client *client; > + struct mutex lock; /*lock resource*/ > + struct camera_info ci; > +}; > + > +struct rk1608_state { > + struct v4l2_subdev sd; > + struct media_pad pad; > + struct mutex lock; /* protect resource */ > + struct mutex sensor_lock; /* protect sensor */ > + struct mutex send_msg_lock; /* protect msg */ > + struct camera_dev *cd[2]; > + struct device *dev; > + struct spi_device *spi; > + struct clk *mclk; > + struct clk *mipi_clk; > + struct clk *pd_cif; > + struct clk *aclk_cif; > + struct clk *hclk_cif; > + struct clk *cif_clk_in; > + struct clk *cif_clk_out; > + struct clk *clk_mipi_24m; > + struct clk *hclk_mipiphy; > + void __iomem *grf_gpio2b_iomux; > + void __iomem *grf_io_vsel; > + int powerdown1; > + int rst1; > + int powerdown0; > + int rst0; > + int power_count; > + int reset_gpio; > + int reset_active; > + int irq_gpio; > + int irq; > + int sleepst_gpio; > + int sleepst_irq; > + int wakeup_gpio; > + int wakeup_active; > + int powerdown_gpio; > + int powerdown_active; > + int msg_num; > + u32 sensor_cnt; > + u32 sensor_nums; > + u32 max_speed_hz; > + atomic_t msg_done[8]; > + wait_queue_head_t msg_wait; > + struct v4l2_ctrl *link_freq; > + struct v4l2_ctrl_handler ctrl_handler; > + s64 link_freqs; > +}; > + > +struct rk1608_section { > + union { > + u32 offset; > + u32 wait_value; > + }; > + u32 size; > + union { > + u32 load_addr; > + u32 wait_addr; > + }; > + u16 wait_time; > + u16 timeout; > + u16 crc_16; > + u8 flag; > + u8 type; > +}; > + > +struct rk1608_header { > + char version[32]; > + u32 header_size; > + u32 section_count; > + struct rk1608_section sections[RK1608_MAX_SEC_NUM]; > +}; > + > +struct rk1608_boot_req { > + u32 flag; > + u32 load_addr; > + u32 boot_len; > + u8 status; > + u8 dummy[2]; > + u8 cmd; > +}; > + > +struct rk1608_msg_queue { > + u32 buf_head; /* msg buffer head */ > + u32 buf_tail; /* msg buffer tail */ > + u32 cur_send; /* current msg send postition */ postition -> position > + u32 cur_recv; /* current msg receive position */ > +}; > + > +struct msg { > + u32 size; /* unit 4 bytes */ > + u16 type; /* msg identification */ > + s8 camera_id; > + s8 sync; > +}; > + > +struct msg_init { > + u32 size; /* unit 4 bytes */ > + u16 type; > + u8 camera_id; > + u8 sync; Just replace this with: struct msg msg; That also allows you to remove the (struct msg *) casts in the driver. > + > + u32 i2c_bus; > + u32 i2c_clk; > + s8 in_mipi_phy; > + s8 out_mipi_phy; > + s8 mipi_lane; > + s8 bayer; > + u8 sensor_name[32]; > + u8 i2c_slave_addr; > +}; > + > +struct msg_t { > + u32 size; /* unit 4 bytes */ > + u16 type; > + union { > + u8 camera_id; > + u8 core_id; > + } id; > + union { > + u8 sync; > + u8 log_level; > + s8 err; > + } mux; > +}; Why not use the unions in struct msg and get rid of this msg_t struct? This looks weird. It looks like there are really a few variants of this basic msg struct. You can do something like this: struct msg { u32 size; /* unit 4 bytes */ u16 type; union { struct { /* use for types ... */ u8 camera_id; u8 sync; }; struct { /* use for types ... */ u8 core_id; u8 log_level; }; struct { /* use for types ... */ ... }; }; }; I'm not 100% certain if you can use anonymous structs here, so you may have to give them names. Which might be a good idea regardless, it's probably more readable (e.g. msg.sensor.camera_id = ...). > + > +struct preisp_vc_cfg { > + s8 data_type; > + s8 decode_format; > + s8 flag; > + s8 unused; > + u16 width; > + u16 height; > +}; > + > +struct msg_in_size { > + struct msg_t msg_head; > + struct preisp_vc_cfg channel; > +}; > + > +struct msg_out_size { > + u32 size; /* unit 4 bytes */ > + u16 type; > + u8 camera_id; > + u8 sync; Again, this can be replaced with 'struct msg msg;'. > + > + u16 width; > + u16 height; > + u32 mipi_clk; > + u16 line_length_pclk; > + u16 frame_length_lines; > +}; > + > +enum { > + /* AP -> RK1608 > + * 1 msg of sensor This comment is confusing. I thought it meant that there was one sensor message, but it seems to be more like a 'section' number or something. > + */ > + id_msg_init_sensor_t = 0x0001, > + id_msg_set_input_size_t, > + id_msg_set_output_size_t, > + id_msg_set_stream_in_on_t, > + id_msg_set_stream_in_off_t, > + id_msg_set_stream_out_on_t, > + id_msg_set_stream_out_off_t, > + > + /* AP -> RK1608 > + * 2 msg of take picture > + */ > + id_msg_take_picture_t = 0x0021, > + id_msg_take_picture_done_t, > + > + /* AP -> RK1608 > + * 3 msg of realtime parameter > + */ > + id_msg_rt_args_t = 0x0031, > + > + /* AP -> RK1608 > + * 4 msg of power manager > + */ > + id_msg_set_sys_mode_bypass_t = 0x0200, > + id_msg_set_sys_mode_standby_t, > + id_msg_set_sys_mode_idle_enable_t, > + id_msg_set_sys_mode_idle_disable_t, > + id_msg_set_sys_mode_slave_rk1608_on_t, > + id_msg_set_sys_mode_slave_rk1608_off_t, > + > + /* AP -> RK1608 > + * 5 msg of debug config > + */ > + id_msg_set_log_level_t = 0x0250, > + > + /* RK1608 -> AP > + * 6 response of sensor msg > + */ > + id_msg_init_sensor_ret_t = 0x0301, > + id_msg_set_input_size_ret_t, > + id_msg_set_output_size_ret_t, > + id_msg_set_stream_in_on_ret_t, > + id_msg_set_stream_in_off_ret_t, > + id_msg_set_stream_out_on_ret_t, > + id_msg_set_stream_out_off_ret_t, > + > + /* RK1608 -> AP > + * 7 response of take picture msg > + */ > + id_msg_take_picture_ret_t = 0x0320, > + id_msg_take_picture_done_ret_t, > + > + /* RK1608 -> AP > + * 8 response of realtime parameter msg > + */ > + id_msg_rt_args_ret_t = 0x0330, > + > + /* rk1608 -> AP */ > + id_msg_do_i2c_t = 0x0390, > + /* AP -> rk1608 */ > + id_msg_do_i2c_ret_t, > + > + /* RK1608 -> AP > + * 9 msg of print log > + */ > + id_msg_rk1608_log_t = 0x0400, > + > + /* dsi2csi dump */ > + id_msg_dsi2sci_rgb_dump_t = 0x6000, > + id_msg_dsi2sci_nv12_dump_t = 0x6001, > + > + /* RK1608 -> AP > + * 10 msg of xfile > + */ > + id_msg_xfile_import_t = 0x8000 + 0x0600, > + id_msg_xfile_export_t, > + id_msg_xfile_mkdir_t > +}; > + > +struct msg_rk1608_log_t { > + u32 size; > + u16 type; > + s8 core_id; > + s8 log_level; > +}; Hmm. This is basically a struct msg. These structs/enums need a lot more documentation. Especially some high-level documentation on how they fit together. > + > +int rk1608_send_msg_to_dsp(struct rk1608_state *pdata, const struct msg *m); > +/** > + * rk1608_write - RK1608 synchronous write > + * > + * @spi: spi device > + * @addr: resource address > + * @data: data buffer > + * @data_len: data buffer size, in bytes > + * Context: can sleep > + * > + * It returns zero on success, else a negative error code. > + */ > +int rk1608_write(struct spi_device *spi, s32 addr, > + const s32 *data, size_t data_len); > + > +/** > + * rk1608_safe_write - RK1608 synchronous write with state check > + * > + * @spi: spi device > + * @addr: resource address > + * @data: data buffer > + * @data_len: data buffer size, in bytes > + * Context: can sleep > + * > + * It returns zero on success, else operation state code. > + */ > +int rk1608_safe_write(struct spi_device *spi, > + s32 addr, const s32 *data, size_t data_len); > + > +/** > + * rk1608_read - RK1608 synchronous read > + * > + * @spi: spi device > + * @addr: resource address > + * @data: data buffer [out] > + * @data_len: data buffer size, in bytes > + * Context: can sleep > + * > + * It returns zero on success, else a negative error code. > + */ > +int rk1608_read(struct spi_device *spi, s32 addr, > + s32 *data, size_t data_len); > + > +/** > + * rk1608_safe_read - RK1608 synchronous read with state check > + * > + * @spi: spi device > + * @addr: resource address > + * @data: data buffer [out] > + * @data_len: data buffer size, in bytes > + * Context: can sleep > + * > + * It returns zero on success, else operation state code. > + */ > +int rk1608_safe_read(struct spi_device *spi, > + s32 addr, s32 *data, size_t data_len); > + > +/** > + * rk1608_operation_query - RK1608 last operation state query > + * > + * @spi: spi device > + * @state: last operation state [out] > + * Context: can sleep > + * > + * It returns zero on success, else a negative error code. > + */ > +int rk1608_operation_query(struct spi_device *spi, s32 *state); > + > +/** > + * rk1608_interrupt_request - RK1608 request a rk1608 interrupt > + * > + * @spi: spi device > + * @interrupt_num: interrupt identification > + * Context: can sleep > + * > + * It returns zero on success, else a negative error code. > + */ > +int rk1608_interrupt_request(struct spi_device *spi, > + s32 interrupt_num); > + > +static int rk1608_read_wait(struct spi_device *spi, > + const struct rk1608_section *sec); > + > +static int rk1608_boot_request(struct spi_device *spi, > + const struct rk1608_section *sec); > + > +static int rk1608_download_section(struct spi_device *spi, const u8 *data, > + const struct rk1608_section *sec); > +/** > + * rk1608_download_fw: - rk1608 firmware download through spi > + * > + * @spi: spi device > + * @fw_name: name of firmware file, NULL for default firmware name > + * Context: can sleep > + * > + * It returns zero on success, else a negative error code. > + **/ > +int rk1608_download_fw(struct spi_device *spi, const char *fw_name); > + > +/** > + * rk1608_msq_read_head - read rk1608 msg queue head > + * > + * @spi: spi device > + * @addr: msg queue head addr > + * @m: msg queue pointer > + * > + * It returns zero on success, else a negative error code. > + */ > +int rk1608_msq_read_head(struct spi_device *spi, > + u32 addr, struct rk1608_msg_queue *q); > + > +/** > + * rk1608_msq_recv_msg - receive a msg from RK1608 -> AP msg queue > + * > + * @q: msg queue > + * @m: a msg pointer buf [out] > + * > + * need call rk1608_msq_free_received_msg to free msg after msg use done > + * > + * It returns zero on success, else a negative error code. > + */ > +int rk1608_msq_recv_msg(struct spi_device *spi, struct msg **m); > +#endif > Regards, Hans ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] [media] Add Rockchip RK1608 driver 2018-02-26 8:16 ` [PATCH V2 1/2] [media] Add Rockchip RK1608 driver Wen Nuan 2018-02-26 9:50 ` Hans Verkuil @ 2018-02-26 10:12 ` Linus Walleij 2018-02-26 15:15 ` Heiko Stuebner 2018-02-27 3:15 ` 温暖 1 sibling, 2 replies; 8+ messages in thread From: Linus Walleij @ 2018-02-26 10:12 UTC (permalink / raw) To: Wen Nuan, Heiko Stuebner, David Wu Cc: Mauro Carvalho Chehab, David S. Miller, Greg KH, Randy Dunlap, jacob2.chen, linux-kernel, linux-media, Eddie Cai On Mon, Feb 26, 2018 at 9:16 AM, Wen Nuan <leo.wen@rock-chips.com> wrote: > +#include <linux/of_gpio.h> Please do not use this old API in new drivers. Just use GPIO descriptors and only #include <linux/gpio/consumer.h> There is documentation in Documentation/gpio/consumer.txt > +static int rk1608_pin_power(struct rk1608_state *pdata, int on) > +{ > + unsigned int grf_val = 0; > + > + if (on) { > + clk_prepare_enable(pdata->pd_cif); > + clk_prepare_enable(pdata->aclk_cif); > + clk_prepare_enable(pdata->hclk_cif); > + clk_prepare_enable(pdata->cif_clk_in); > + clk_prepare_enable(pdata->cif_clk_out); > + clk_prepare_enable(pdata->clk_mipi_24m); > + clk_prepare_enable(pdata->hclk_mipiphy); > + clk_set_rate(pdata->cif_clk_out, RK1608_MCLK_RATE); > + > + clk_prepare_enable(pdata->mipi_clk); > + clk_set_rate(pdata->mipi_clk, RK1608_MCLK_RATE); > + > + gpio_direction_output(pdata->rst1, 0); Instead of this old GPIO API, put GPIO descriptors struct gpio_desc *rst1; etc in your state container and use gpiod_direction_output() etc. > + pdata->grf_gpio2b_iomux = ioremap((resource_size_t) > + (GRF_BASE_ADDR + > + GRF_GPIO2B_IOMUX), 4); > + grf_val = __raw_readl(pdata->grf_gpio2b_iomux); > + __raw_writel(((grf_val) | (1 << 6) | (1 << (6 + 16))), > + pdata->grf_gpio2b_iomux); > + > + pdata->grf_io_vsel = ioremap((resource_size_t) > + (GRF_BASE_ADDR + GRF_IO_VSEL), 4); > + grf_val = __raw_readl(pdata->grf_io_vsel); > + __raw_writel(((grf_val) | (1 << 1) | (1 << (1 + 16))), > + pdata->grf_io_vsel); You are doing pin control on the side of the pin control subsystem it looks like? I think David Wu and Heiko Stubner needs to have a look at what you are doing here to suggest other solutions. Apart from that, why use __raw_writel instead of just writel()? > +static int rk1608_parse_dt_property(struct rk1608_state *pdata) > +{ (...) > + enum of_gpio_flags flags; Don't use this. > + ret = of_get_named_gpio_flags(node, "rockchip,reset1", 0, &flags); You should not use custom properties for GPIO names, they need names like this: gpios-reset1 = <&gpioN 1 GPIO_ACTIVE_HIGH> See Documentation/devicetree/bindings/gpio/gpio.txt > + if (ret <= 0) > + dev_err(dev, "can not find reset1 error %d\n", ret); > + pdata->rst1 = ret; > + > + ret = devm_gpio_request(dev, pdata->rst1, "rockchip-reset1"); > + if (ret) { > + dev_err(dev, "gpio pdata->rst1 %d request error %d\n", > + pdata->rst1, ret); > + return ret; > + } > + gpio_set_value(pdata->rst1, 0); > + ret = gpio_direction_output(pdata->rst1, 0); > + if (ret) { > + dev_err(dev, "gpio %d direction output error %d\n", > + pdata->rst1, ret); > + return ret; > + } As you see this become tedious and repetitive. Instead use: pdata->rst1 = gpiod_get(dev, "reset1", GPIOD_OUT_LOW); if (IS_ERR(pdata->rst1)) return PTR_ERR(pdata->rst1); After this point you know that you have a valid handle on the GPIO line and it is initialized low. > +struct rk1608_state { (...) > + void __iomem *grf_gpio2b_iomux; I suspect this should be done with pin control. > + void __iomem *grf_io_vsel; And this should maybe use a regulator. > + int powerdown1; > + int rst1; > + int powerdown0; > + int rst0; > + int power_count; > + int reset_gpio; > + int reset_active; > + int irq_gpio; > + int irq; > + int sleepst_gpio; > + int sleepst_irq; > + int wakeup_gpio; > + int wakeup_active; > + int powerdown_gpio; > + int powerdown_active; Anything that us a GPIO should be a struct gpio_desc *. You do not need to keep track of if they are active I guess, but I haven't looked close. They should probably be bool rather than int if necessary. But notice that we have gpiod_get_optional() and if you use that you can just check if the gpio_desc * is NULL like if (!pdata->wakeup_gpio) gpiod_set_value() ... Yours, Linus Walleij ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] [media] Add Rockchip RK1608 driver 2018-02-26 10:12 ` Linus Walleij @ 2018-02-26 15:15 ` Heiko Stuebner 2018-02-27 3:15 ` 温暖 1 sibling, 0 replies; 8+ messages in thread From: Heiko Stuebner @ 2018-02-26 15:15 UTC (permalink / raw) To: Linus Walleij Cc: Wen Nuan, David Wu, Mauro Carvalho Chehab, David S. Miller, Greg KH, Randy Dunlap, jacob2.chen, linux-kernel, linux-media, Eddie Cai Hi Linus, thanks for catching these things :-) . Am Montag, 26. Februar 2018, 11:12:30 CET schrieb Linus Walleij: > On Mon, Feb 26, 2018 at 9:16 AM, Wen Nuan <leo.wen@rock-chips.com> wrote: > > + pdata->grf_gpio2b_iomux = ioremap((resource_size_t) > > + (GRF_BASE_ADDR + > > + GRF_GPIO2B_IOMUX), 4); > > + grf_val = __raw_readl(pdata->grf_gpio2b_iomux); > > + __raw_writel(((grf_val) | (1 << 6) | (1 << (6 + 16))), > > + pdata->grf_gpio2b_iomux); > > + > > + pdata->grf_io_vsel = ioremap((resource_size_t) > > + (GRF_BASE_ADDR + GRF_IO_VSEL), 4); > > + grf_val = __raw_readl(pdata->grf_io_vsel); > > + __raw_writel(((grf_val) | (1 << 1) | (1 << (1 + 16))), > > + pdata->grf_io_vsel); > > You are doing pin control on the side of the pin control subsystem > it looks like? > > I think David Wu and Heiko Stubner needs to have a look at what you > are doing here to suggest other solutions. Especially as the rk1608 seems to be some a spi-connected peripheral. So it should definitly not touch _any_ soc-specific registers at all. I just looked up the patch in patchwork and apart from the one Linus quoted above, I found quite a bit more open-coded pinctrl settings as well as direct writes to the clock controller and even io-voltage selections. All these things are highly soc-specific so vary with each soc this ic gets connected to and the kernel does provide abstractions for all of them. For clock-rates there are the clock-apis and also the assigned-clock* properties for the devicetree, pinctrl supports multiple states and io-vsel selections normally should just monitor the supply-regulator via the io-domain driver we already have [See vqmmc handling in for sd-cards for example]. So this driver should not touch anything of that sort and therefore should _not_ contain any iomem-based read or write at all. Heiko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] [media] Add Rockchip RK1608 driver 2018-02-26 10:12 ` Linus Walleij 2018-02-26 15:15 ` Heiko Stuebner @ 2018-02-27 3:15 ` 温暖 2018-02-27 15:12 ` Heiko Stuebner 1 sibling, 1 reply; 8+ messages in thread From: 温暖 @ 2018-02-27 3:15 UTC (permalink / raw) To: Linus Walleij Cc: Heiko Stuebner, David Wu, Mauro Carvalho Chehab, David S. Miller, Greg KH, Randy Dunlap, jacob2.chen, linux-kernel, linux-media, Eddie Cai [-- Attachment #1: Type: text/html, Size: 13964 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] [media] Add Rockchip RK1608 driver 2018-02-27 3:15 ` 温暖 @ 2018-02-27 15:12 ` Heiko Stuebner 2018-02-28 1:23 ` 回复： " 温暖 0 siblings, 1 reply; 8+ messages in thread From: Heiko Stuebner @ 2018-02-27 15:12 UTC (permalink / raw) To: 温暖 Cc: Linus Walleij, David Wu, Mauro Carvalho Chehab, David S. Miller, Greg KH, Randy Dunlap, jacob2.chen, linux-kernel, linux-media, Eddie Cai Hi Leo, Am Dienstag, 27. Februar 2018, 04:15:46 CET schrieb 温暖: > Thank you for your advice! I will revise it according to your suggestion. please also keep an eye on my reply to Linus' mail pointing out some other issues where the driver should not tie into soc-specific areas like the clock controller etc. Thanks Heiko Am Dienstag, 27. Februar 2018, 04:15:46 CET schrieb 温暖: > On 2/26/2018 18:12，Linus Walleij<linus.walleij@linaro.org> wrote： > On Mon, Feb 26, 2018 at 9:16 AM, Wen Nuan <leo.wen@rock-chips.com> wrote: > + pdata->grf_gpio2b_iomux = ioremap((resource_size_t) > + (GRF_BASE_ADDR + > + GRF_GPIO2B_IOMUX), 4); > + grf_val = __raw_readl(pdata->grf_gpio2b_iomux); > + __raw_writel(((grf_val) | (1 << 6) | (1 << (6 + 16))), > + pdata->grf_gpio2b_iomux); > + > + pdata->grf_io_vsel = ioremap((resource_size_t) > + (GRF_BASE_ADDR + GRF_IO_VSEL), 4); > + grf_val = __raw_readl(pdata->grf_io_vsel); > + __raw_writel(((grf_val) | (1 << 1) | (1 << (1 + 16))), > + pdata->grf_io_vsel); > > You are doing pin control on the side of the pin control subsystem > it looks like? > > I think David Wu and Heiko Stubner needs to have a look at what you > are doing here to suggest other solutions. > > Apart from that, why use __raw_writel instead of just writel()? > > This pin is iomux, default GPIO, need to be changed to CLK. > This CLK is provided to external sensor for use. > I'll use writel(). As stated, please don't directly access soc blocks like the clock controller or iomuxes, there are standard APIs like the general clock API and also assigned-clock* devicetree properties. Similarly for pinctrl access. So there should not be any writel (or ioremap) at all in this spi driver I'd think. Thanks Heiko ^ permalink raw reply [flat|nested] 8+ messages in thread
* 回复： [PATCH V2 1/2] [media] Add Rockchip RK1608 driver 2018-02-27 15:12 ` Heiko Stuebner @ 2018-02-28 1:23 ` 温暖 0 siblings, 0 replies; 8+ messages in thread From: 温暖 @ 2018-02-28 1:23 UTC (permalink / raw) To: Heiko Stuebner Cc: Linus Walleij, David Wu, Mauro Carvalho Chehab, David S. Miller, Greg KH, Randy Dunlap, jacob2.chen, linux-kernel, linux-media, Eddie Cai [-- Attachment #1: Type: text/html, Size: 5925 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-02-28 1:23 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-02-26 8:16 [PATCH V2 0/2] Rockchip: Add RK1608 driver and DT-bindings Wen Nuan 2018-02-26 8:16 ` [PATCH V2 1/2] [media] Add Rockchip RK1608 driver Wen Nuan 2018-02-26 9:50 ` Hans Verkuil 2018-02-26 10:12 ` Linus Walleij 2018-02-26 15:15 ` Heiko Stuebner 2018-02-27 3:15 ` 温暖 2018-02-27 15:12 ` Heiko Stuebner 2018-02-28 1:23 ` 回复： " 温暖
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).