* [PATCH] hexdump: do not print debug dumps for !CONFIG_DEBUG
@ 2015-07-22 7:54 Linus Walleij
0 siblings, 0 replies; only message in thread
From: Linus Walleij @ 2015-07-22 7:54 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Linus Walleij
The function print_hex_dump_debug() is likely supposed to be
analogous to pr_debug() or dev_dbg() & friends. Currently it
will adhere to dynamic debug, but will not stub out prints if
CONFIG_DEBUG is not set. Let's make it do the right thing,
because I am tired of having my dmesg buffer full of hex
dumps on production systems.
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Andrew: I think this is your file. I did spend some time
shaking my head thinking this basic thing just can't be wrong,
but it appears it is.
---
include/linux/printk.h | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/include/linux/printk.h b/include/linux/printk.h
index a6298b27ac99..2d154b13d6cc 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -456,11 +456,17 @@ static inline void print_hex_dump_bytes(const char *prefix_str, int prefix_type,
groupsize, buf, len, ascii) \
dynamic_hex_dump(prefix_str, prefix_type, rowsize, \
groupsize, buf, len, ascii)
-#else
+#elif defined(DEBUG)
#define print_hex_dump_debug(prefix_str, prefix_type, rowsize, \
groupsize, buf, len, ascii) \
print_hex_dump(KERN_DEBUG, prefix_str, prefix_type, rowsize, \
groupsize, buf, len, ascii)
-#endif /* defined(CONFIG_DYNAMIC_DEBUG) */
+#else
+static inline void print_hex_dump_debug(const char *prefix_str, int prefix_type,
+ int rowsize, int groupsize,
+ const void *buf, size_t len, bool ascii)
+{
+}
+#endif
#endif
--
2.4.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-07-22 7:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-22 7:54 [PATCH] hexdump: do not print debug dumps for !CONFIG_DEBUG Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).