linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Staging : wilc1000: Remove braces for single statement blocks
@ 2015-07-29  6:48 Shraddha Barke
  0 siblings, 0 replies; 3+ messages in thread
From: Shraddha Barke @ 2015-07-29  6:48 UTC (permalink / raw)
  To: Johnny Kim, Julia Lawall, Rachel Kim, Dean Lee, Chris Park,
	Greg Kroah-Hartman, devel, linux-wireless, linux-kernel
  Cc: Shraddha Barke

This patch fixes the following checkpatch.pl warning:

WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index ed6ac45..eb1b8f2 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -855,9 +855,8 @@ s32 ParseNetworkInfo(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo)
 
 		/* Get DTIM Period */
 		pu8TimElm = get_tim_elm(pu8msa, (u16RxLen + FCS_LEN), u8index);
-		if (pu8TimElm != 0) {
+		if (pu8TimElm != 0)
 			pstrNetworkInfo->u8DtimPeriod = pu8TimElm[3];
-		}
 		pu8IEs = &pu8msa[MAC_HDR_LEN + TIME_STAMP_LEN + BEACON_INTERVAL_LEN + CAP_INFO_LEN];
 		u16IEsLen = u16RxLen - (MAC_HDR_LEN + TIME_STAMP_LEN + BEACON_INTERVAL_LEN + CAP_INFO_LEN);
 
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Staging:wilc1000 :Remove braces for single statement blocks
  2015-07-31  5:15 [PATCH] Staging:wilc1000 :Remove " Shraddha Barke
@ 2015-07-31  5:32 ` Vaishali Thakkar
  0 siblings, 0 replies; 3+ messages in thread
From: Vaishali Thakkar @ 2015-07-31  5:32 UTC (permalink / raw)
  To: Shraddha Barke
  Cc: linux-wireless, Rachel Kim, Dean Lee, Chris Park,
	Greg Kroah-Hartman, Johnny Kim, linux-kernel, devel

On 31 Jul 2015 10:49, "Shraddha Barke" <shraddha.6596@gmail.com> wrote:
>
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: braces {} are not necessary for single statement blocks

There should be one line space between your commit log
and Signed-off-by line.

> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 4d5bd1c..1143282 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -1055,10 +1055,8 @@ s32 DeallocateSurveyResults(wid_site_survey_reslts_s *pstrSurveyResults)
>  {
>         s32 s32Error = WILC_SUCCESS;
>
> -       if (pstrSurveyResults != NULL) {
> +       if (pstrSurveyResults != NULL)
>                 WILC_FREE(pstrSurveyResults);
> -       }
> -
>         return s32Error;
>  }
>  #endif
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] Staging:wilc1000 :Remove braces for single statement blocks
@ 2015-07-31  5:15 Shraddha Barke
  2015-07-31  5:32 ` Vaishali Thakkar
  0 siblings, 1 reply; 3+ messages in thread
From: Shraddha Barke @ 2015-07-31  5:15 UTC (permalink / raw)
  To: Dean Lee, Rachel Kim, Johnny Kim, Chris Park, Greg Kroah-Hartman,
	linux-wireless, devel, linux-kernel
  Cc: Shraddha Barke

This patch fixes the following checkpatch.pl warning:

WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 4d5bd1c..1143282 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -1055,10 +1055,8 @@ s32 DeallocateSurveyResults(wid_site_survey_reslts_s *pstrSurveyResults)
 {
 	s32 s32Error = WILC_SUCCESS;
 
-	if (pstrSurveyResults != NULL) {
+	if (pstrSurveyResults != NULL)
 		WILC_FREE(pstrSurveyResults);
-	}
-
 	return s32Error;
 }
 #endif
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-31  5:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-29  6:48 [PATCH] Staging : wilc1000: Remove braces for single statement blocks Shraddha Barke
2015-07-31  5:15 [PATCH] Staging:wilc1000 :Remove " Shraddha Barke
2015-07-31  5:32 ` Vaishali Thakkar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).