[PATCH V2] iio: declare struct to fix warning

[PATCH V2] iio: declare struct to fix warning

[Pengyu Ma]

When compile iio related driver the following warning shown:

include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
declared inside parameter list
  int (*set_trigger_state)(struct iio_trigger *trig, bool state);

include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
declared inside parameter list
           struct iio_dev *indio_dev);

'struct iio_dev' and 'struct iio_trigger' was used before declaration,
forward declaration for these structs to fix warning.

Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
---
 include/linux/iio/trigger.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
index fa76c79..974cf73 100644
--- a/include/linux/iio/trigger.h
+++ b/include/linux/iio/trigger.h
@@ -18,6 +18,10 @@ struct iio_subirq {
 	bool enabled;
 };
 
+/* forward declaration */
+struct iio_dev;
+struct iio_trigger;
+
 /**
  * struct iio_trigger_ops - operations structure for an iio_trigger.
  * @owner:		used to monitor usage count of the trigger.
-- 
2.4.3

Re: [PATCH V2] iio: declare struct to fix warning

[Pengyu Ma]

If this patch is fine, could somebody help me to merge into upstream kernel?

Thanks,
Pengyu

On 08/03/2015 10:39 AM, Pengyu Ma wrote:
> When compile iio related driver the following warning shown:
>
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
>             struct iio_dev *indio_dev);
>
> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
> forward declaration for these structs to fix warning.
>
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> ---
>   include/linux/iio/trigger.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index fa76c79..974cf73 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -18,6 +18,10 @@ struct iio_subirq {
>   	bool enabled;
>   };
>   
> +/* forward declaration */
> +struct iio_dev;
> +struct iio_trigger;
> +
>   /**
>    * struct iio_trigger_ops - operations structure for an iio_trigger.
>    * @owner:		used to monitor usage count of the trigger.

Re: [PATCH V2] iio: declare struct to fix warning

[Lars-Peter Clausen]

On 08/04/2015 09:52 AM, Pengyu Ma wrote:
> If this patch is fine, could somebody help me to merge into upstream kernel?

It will be merged, don't worry. But things typically take a bit longer than
just a single day.

> 
> Thanks,
> Pengyu
> 
> On 08/03/2015 10:39 AM, Pengyu Ma wrote:
>> When compile iio related driver the following warning shown:
>>
>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>> declared inside parameter list
>>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>
>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>> declared inside parameter list
>>             struct iio_dev *indio_dev);
>>
>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>> forward declaration for these structs to fix warning.
>>
>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>> ---
>>   include/linux/iio/trigger.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>> index fa76c79..974cf73 100644
>> --- a/include/linux/iio/trigger.h
>> +++ b/include/linux/iio/trigger.h
>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>       bool enabled;
>>   };
>>   +/* forward declaration */
>> +struct iio_dev;
>> +struct iio_trigger;
>> +
>>   /**
>>    * struct iio_trigger_ops - operations structure for an iio_trigger.
>>    * @owner:        used to monitor usage count of the trigger.
> 

Re: [PATCH V2] iio: declare struct to fix warning

[Pengyu Ma]

On 08/04/2015 03:54 PM, Lars-Peter Clausen wrote:
> On 08/04/2015 09:52 AM, Pengyu Ma wrote:
>> If this patch is fine, could somebody help me to merge into upstream kernel?
> It will be merged, don't worry. But things typically take a bit longer than
> just a single day.
So it's will be merge by patch, no need a pull-request, right?

Thanks,
Pengyu
>> Thanks,
>> Pengyu
>>
>> On 08/03/2015 10:39 AM, Pengyu Ma wrote:
>>> When compile iio related driver the following warning shown:
>>>
>>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>>> declared inside parameter list
>>>     int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>>
>>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>>> declared inside parameter list
>>>              struct iio_dev *indio_dev);
>>>
>>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>>> forward declaration for these structs to fix warning.
>>>
>>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>>> ---
>>>    include/linux/iio/trigger.h | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>>> index fa76c79..974cf73 100644
>>> --- a/include/linux/iio/trigger.h
>>> +++ b/include/linux/iio/trigger.h
>>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>>        bool enabled;
>>>    };
>>>    +/* forward declaration */
>>> +struct iio_dev;
>>> +struct iio_trigger;
>>> +
>>>    /**
>>>     * struct iio_trigger_ops - operations structure for an iio_trigger.
>>>     * @owner:        used to monitor usage count of the trigger.

Re: [PATCH V2] iio: declare struct to fix warning

[Crt Mori]

On 4 August 2015 at 09:56, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>
>
> On 08/04/2015 03:54 PM, Lars-Peter Clausen wrote:
>>
>> On 08/04/2015 09:52 AM, Pengyu Ma wrote:
>>>
>>> If this patch is fine, could somebody help me to merge into upstream
>>> kernel?
>>
>> It will be merged, don't worry. But things typically take a bit longer
>> than
>> just a single day.
>
> So it's will be merge by patch, no need a pull-request, right?
Correct.
>
> Thanks,
> Pengyu
>
>>> Thanks,
>>> Pengyu
>>>
>>> On 08/03/2015 10:39 AM, Pengyu Ma wrote:
>>>>
>>>> When compile iio related driver the following warning shown:
>>>>
>>>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>>>> declared inside parameter list
>>>>     int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>>>
>>>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>>>> declared inside parameter list
>>>>              struct iio_dev *indio_dev);
>>>>
>>>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>>>> forward declaration for these structs to fix warning.
>>>>
>>>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>>>> ---
>>>>    include/linux/iio/trigger.h | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>>>> index fa76c79..974cf73 100644
>>>> --- a/include/linux/iio/trigger.h
>>>> +++ b/include/linux/iio/trigger.h
>>>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>>>        bool enabled;
>>>>    };
>>>>    +/* forward declaration */
>>>> +struct iio_dev;
>>>> +struct iio_trigger;
>>>> +
>>>>    /**
>>>>     * struct iio_trigger_ops - operations structure for an iio_trigger.
>>>>     * @owner:        used to monitor usage count of the trigger.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2] iio: declare struct to fix warning

[Lars-Peter Clausen]

On 08/04/2015 09:56 AM, Pengyu Ma wrote:
> 
> 
> On 08/04/2015 03:54 PM, Lars-Peter Clausen wrote:
>> On 08/04/2015 09:52 AM, Pengyu Ma wrote:
>>> If this patch is fine, could somebody help me to merge into upstream kernel?
>> It will be merged, don't worry. But things typically take a bit longer than
>> just a single day.
> So it's will be merge by patch, no need a pull-request, right?

Yes, Jonathan will pick it up and apply it to the IIO tree.

Thanks for the patch.

> 
> Thanks,
> Pengyu
>>> Thanks,
>>> Pengyu
>>>
>>> On 08/03/2015 10:39 AM, Pengyu Ma wrote:
>>>> When compile iio related driver the following warning shown:
>>>>
>>>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>>>> declared inside parameter list
>>>>     int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>>>
>>>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>>>> declared inside parameter list
>>>>              struct iio_dev *indio_dev);
>>>>
>>>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>>>> forward declaration for these structs to fix warning.
>>>>
>>>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>>>> ---
>>>>    include/linux/iio/trigger.h | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>>>> index fa76c79..974cf73 100644
>>>> --- a/include/linux/iio/trigger.h
>>>> +++ b/include/linux/iio/trigger.h
>>>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>>>        bool enabled;
>>>>    };
>>>>    +/* forward declaration */
>>>> +struct iio_dev;
>>>> +struct iio_trigger;
>>>> +
>>>>    /**
>>>>     * struct iio_trigger_ops - operations structure for an iio_trigger.
>>>>     * @owner:        used to monitor usage count of the trigger.
> 

Re: [PATCH V2] iio: declare struct to fix warning

[Daniel Baluta]

On Mon, Aug 3, 2015 at 5:39 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
> When compile iio related driver the following warning shown:
>
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
>   int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
>            struct iio_dev *indio_dev);
>
> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
> forward declaration for these structs to fix warning.
>
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> ---
>  include/linux/iio/trigger.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index fa76c79..974cf73 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -18,6 +18,10 @@ struct iio_subirq {
>         bool enabled;
>  };
>
> +/* forward declaration */
I would remove this comment. It doesn't says much.

> +struct iio_dev;
> +struct iio_trigger;
> +
>  /**
>   * struct iio_trigger_ops - operations structure for an iio_trigger.
>   * @owner:             used to monitor usage count of the trigger.

thanks,
Daniel.

Re: [PATCH V2] iio: declare struct to fix warning

[Pengyu Ma]

On 08/04/2015 04:03 PM, Daniel Baluta wrote:
> On Mon, Aug 3, 2015 at 5:39 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>> When compile iio related driver the following warning shown:
>>
>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>> declared inside parameter list
>>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>
>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>> declared inside parameter list
>>             struct iio_dev *indio_dev);
>>
>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>> forward declaration for these structs to fix warning.
>>
>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>> ---
>>   include/linux/iio/trigger.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>> index fa76c79..974cf73 100644
>> --- a/include/linux/iio/trigger.h
>> +++ b/include/linux/iio/trigger.h
>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>          bool enabled;
>>   };
>>
>> +/* forward declaration */
> I would remove this comment. It doesn't says much.
OK, Do I need a v3 review or you apply it with your modification directly?

Pengyu
>
>> +struct iio_dev;
>> +struct iio_trigger;
>> +
>>   /**
>>    * struct iio_trigger_ops - operations structure for an iio_trigger.
>>    * @owner:             used to monitor usage count of the trigger.
> thanks,
> Daniel.

Re: [PATCH V2] iio: declare struct to fix warning

[Daniel Baluta]

On Tue, Aug 4, 2015 at 11:11 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>
>
> On 08/04/2015 04:03 PM, Daniel Baluta wrote:
>>
>> On Mon, Aug 3, 2015 at 5:39 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>>>
>>> When compile iio related driver the following warning shown:
>>>
>>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>>> declared inside parameter list
>>>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>>
>>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>>> declared inside parameter list
>>>             struct iio_dev *indio_dev);
>>>
>>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>>> forward declaration for these structs to fix warning.
>>>
>>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>>> ---
>>>   include/linux/iio/trigger.h | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>>> index fa76c79..974cf73 100644
>>> --- a/include/linux/iio/trigger.h
>>> +++ b/include/linux/iio/trigger.h
>>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>>          bool enabled;
>>>   };
>>>
>>> +/* forward declaration */
>>
>> I would remove this comment. It doesn't says much.
>
> OK, Do I need a v3 review or you apply it with your modification directly?

Please send v3, Jonathan will appreciate this :).

thanks,
Daniel.

Re: [PATCH V2] iio: declare struct to fix warning

[Jonathan Cameron]

On 04/08/15 09:14, Daniel Baluta wrote:
> On Tue, Aug 4, 2015 at 11:11 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>>
>>
>> On 08/04/2015 04:03 PM, Daniel Baluta wrote:
>>>
>>> On Mon, Aug 3, 2015 at 5:39 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>>>>
>>>> When compile iio related driver the following warning shown:
>>>>
>>>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>>>> declared inside parameter list
>>>>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>>>
>>>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>>>> declared inside parameter list
>>>>             struct iio_dev *indio_dev);
>>>>
>>>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>>>> forward declaration for these structs to fix warning.
>>>>
>>>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>>>> ---
>>>>   include/linux/iio/trigger.h | 4 ++++
>>>>   1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>>>> index fa76c79..974cf73 100644
>>>> --- a/include/linux/iio/trigger.h
>>>> +++ b/include/linux/iio/trigger.h
>>>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>>>          bool enabled;
>>>>   };
>>>>
>>>> +/* forward declaration */
>>>
>>> I would remove this comment. It doesn't says much.
>>
>> OK, Do I need a v3 review or you apply it with your modification directly?
> 
> Please send v3, Jonathan will appreciate this :).
I will indeed ;)

Thanks,
> 
> thanks,
> Daniel.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>