From: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
To: gregkh@linuxfoundation.org, ming.lei@canonical.com
Cc: corbet@lwn.net, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, dwmw2@infradead.org,
dhowells@redhat.com, seth.forshee@canonical.com,
rusty@rustcorp.com.au, mmarek@suse.cz, mjg59@srcf.ucam.org,
kyle@kernel.org, linux-security-module@vger.kernel.org,
keyrings@linux-nfs.org, "Luis R. Rodriguez" <mcgrof@suse.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Kees Cook" <keescook@chromium.org>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Takashi Iwai" <tiwai@suse.de>,
"Vojtěch Pavlík" <vojtech@suse.cz>
Subject: [PATCH 1/4] firmware: generalize "firmware" as "system data" helpers
Date: Tue, 4 Aug 2015 15:00:01 -0700 [thread overview]
Message-ID: <1438725604-22795-2-git-send-email-mcgrof@do-not-panic.com> (raw)
In-Reply-To: <1438725604-22795-1-git-send-email-mcgrof@do-not-panic.com>
From: "Luis R. Rodriguez" <mcgrof@suse.com>
Historically firmware_class code was added to help
get device driver firmware binaries but these days
request_firmware*() helpers are being repurposed for
general system data needed by the kernel.
Annotate this before we extend firmare_class more,
as this is expected. We want to generalize the code
as much as possible.
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Casey Schaufler <casey@schaufler-ca.com>
Cc: Ming Lei <ming.lei@canonical.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Vojtěch Pavlík <vojtech@suse.cz>
Cc: Kyle McMartin <kyle@kernel.org>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
---
drivers/base/firmware_class.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 894bda114224..f97e76cca069 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -353,15 +353,15 @@ static int fw_get_filesystem_firmware(struct device *device,
rc = fw_read_file_contents(file, buf);
fput(file);
if (rc)
- dev_warn(device, "firmware, attempted to load %s, but failed with error %d\n",
- path, rc);
+ dev_warn(device, "system data, attempted to load %s, but failed with error %d\n",
+ path, rc);
else
break;
}
__putname(path);
if (!rc) {
- dev_dbg(device, "firmware: direct-loading firmware %s\n",
+ dev_dbg(device, "system data: direct-loading firmware %s\n",
buf->fw_id);
mutex_lock(&fw_lock);
set_bit(FW_STATUS_DONE, &buf->status);
@@ -1051,7 +1051,7 @@ _request_firmware_prepare(struct firmware **firmware_p, const char *name,
}
if (fw_get_builtin_firmware(firmware, name)) {
- dev_dbg(device, "firmware: using built-in firmware %s\n", name);
+ dev_dbg(device, "system data: using built-in system data%s\n", name);
return 0; /* assigned */
}
--
2.3.2.209.gd67f9d5.dirty
next prev parent reply other threads:[~2015-08-04 22:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 22:00 [PATCH 0/4] firmware_class: few small code shifts Luis R. Rodriguez
2015-08-04 22:00 ` Luis R. Rodriguez [this message]
2015-10-04 19:16 ` [PATCH 1/4] firmware: generalize "firmware" as "system data" helpers Greg KH
2015-10-05 21:22 ` Luis R. Rodriguez
2015-10-06 9:08 ` Greg KH
2015-10-06 17:28 ` [PATCH 1/4] firmware: generalize "firmware" as "system data" helpers] Luis R. Rodriguez
2015-10-08 20:16 ` [PATCH 1/4] firmware: generalize "firmware" as "system data" helpers Josh Boyer
2015-12-17 19:16 ` Luis R. Rodriguez
2015-08-04 22:00 ` [PATCH 2/4] firmware: move completing fw into a helper Luis R. Rodriguez
2015-08-04 22:00 ` [PATCH 3/4] firmware: fold successful fw read early Luis R. Rodriguez
2015-08-09 13:29 ` Ming Lei
2015-08-10 16:43 ` Luis R. Rodriguez
2015-08-04 22:00 ` [PATCH 4/4] firmware: generalize reading file contents as a helper Luis R. Rodriguez
2015-08-21 21:23 ` [PATCH 0/4] firmware_class: few small code shifts Luis R. Rodriguez
2015-08-22 5:38 ` Greg KH
2015-08-22 21:18 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438725604-22795-2-git-send-email-mcgrof@do-not-panic.com \
--to=mcgrof@do-not-panic.com \
--cc=akpm@linux-foundation.org \
--cc=casey@schaufler-ca.com \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=keyrings@linux-nfs.org \
--cc=kyle@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=ming.lei@canonical.com \
--cc=mjg59@srcf.ucam.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
--cc=seth.forshee@canonical.com \
--cc=tiwai@suse.de \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).