* [PATCH] vbox: fix link error with 'gcc -Og'
@ 2018-11-02 15:38 Arnd Bergmann
2018-11-02 19:43 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-11-02 15:38 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Arnd Bergmann, Hans de Goede, Kees Cook, Randy Dunlap, linux-kernel
With the new CONFIG_CC_OPTIMIZE_FOR_DEBUGGING option, we get a link
error in the vboxguest driver, when that fails to optimize out the
call to the compat handler:
drivers/virt/vboxguest/vboxguest_core.o: In function `vbg_ioctl_hgcm_call':
vboxguest_core.c:(.text+0x1f6e): undefined reference to `vbg_hgcm_call32'
Another compile-time check documents better what we want and avoids
the error.
Acked-by: Randy Dunlap<rdunlap@infradead.org>
Tested-by: Randy Dunlap<rdunlap@infradead.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/virt/vboxguest/vboxguest_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
index 3093655c7b92..1475ed5ffcde 100644
--- a/drivers/virt/vboxguest/vboxguest_core.c
+++ b/drivers/virt/vboxguest/vboxguest_core.c
@@ -1312,7 +1312,7 @@ static int vbg_ioctl_hgcm_call(struct vbg_dev *gdev,
return -EINVAL;
}
- if (f32bit)
+ if (IS_ENABLED(CONFIG_COMPAT) && f32bit)
ret = vbg_hgcm_call32(gdev, client_id,
call->function, call->timeout_ms,
VBG_IOCTL_HGCM_CALL_PARMS32(call),
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vbox: fix link error with 'gcc -Og'
2018-11-02 15:38 [PATCH] vbox: fix link error with 'gcc -Og' Arnd Bergmann
@ 2018-11-02 19:43 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2018-11-02 19:43 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman; +Cc: Kees Cook, Randy Dunlap, linux-kernel
Hi,
On 11/2/18 4:38 PM, Arnd Bergmann wrote:
> With the new CONFIG_CC_OPTIMIZE_FOR_DEBUGGING option, we get a link
> error in the vboxguest driver, when that fails to optimize out the
> call to the compat handler:
>
> drivers/virt/vboxguest/vboxguest_core.o: In function `vbg_ioctl_hgcm_call':
> vboxguest_core.c:(.text+0x1f6e): undefined reference to `vbg_hgcm_call32'
>
> Another compile-time check documents better what we want and avoids
> the error.
>
> Acked-by: Randy Dunlap<rdunlap@infradead.org>
> Tested-by: Randy Dunlap<rdunlap@infradead.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thank you, looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/virt/vboxguest/vboxguest_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
> index 3093655c7b92..1475ed5ffcde 100644
> --- a/drivers/virt/vboxguest/vboxguest_core.c
> +++ b/drivers/virt/vboxguest/vboxguest_core.c
> @@ -1312,7 +1312,7 @@ static int vbg_ioctl_hgcm_call(struct vbg_dev *gdev,
> return -EINVAL;
> }
>
> - if (f32bit)
> + if (IS_ENABLED(CONFIG_COMPAT) && f32bit)
> ret = vbg_hgcm_call32(gdev, client_id,
> call->function, call->timeout_ms,
> VBG_IOCTL_HGCM_CALL_PARMS32(call),
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-02 19:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-02 15:38 [PATCH] vbox: fix link error with 'gcc -Og' Arnd Bergmann
2018-11-02 19:43 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).