* [PATCH] ARM: Feroceon: use of_iomap() to map register base
@ 2015-08-08 12:11 Masahiro Yamada
2015-08-13 9:57 ` Olof Johansson
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2015-08-08 12:11 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Illia Ragozin, arm, Nicolas Pitre, Jason Cooper, Andrew Lunn,
Arnd Bergmann, Jason Gunthorpe, Maxime Bizon, Masahiro Yamada,
Russell King, linux-kernel
The sequence of of_address_to_resource() and ioremap() can be
replaced with of_iomap().
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/mm/cache-feroceon-l2.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/arm/mm/cache-feroceon-l2.c b/arch/arm/mm/cache-feroceon-l2.c
index 097181e..5c1b7a7 100644
--- a/arch/arm/mm/cache-feroceon-l2.c
+++ b/arch/arm/mm/cache-feroceon-l2.c
@@ -368,7 +368,6 @@ int __init feroceon_of_init(void)
struct device_node *node;
void __iomem *base;
bool l2_wt_override = false;
- struct resource res;
#if defined(CONFIG_CACHE_FEROCEON_L2_WRITETHROUGH)
l2_wt_override = true;
@@ -376,10 +375,7 @@ int __init feroceon_of_init(void)
node = of_find_matching_node(NULL, feroceon_ids);
if (node && of_device_is_compatible(node, "marvell,kirkwood-cache")) {
- if (of_address_to_resource(node, 0, &res))
- return -ENODEV;
-
- base = ioremap(res.start, resource_size(&res));
+ base = of_iomap(node, 0);
if (!base)
return -ENOMEM;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: Feroceon: use of_iomap() to map register base
2015-08-08 12:11 [PATCH] ARM: Feroceon: use of_iomap() to map register base Masahiro Yamada
@ 2015-08-13 9:57 ` Olof Johansson
0 siblings, 0 replies; 2+ messages in thread
From: Olof Johansson @ 2015-08-13 9:57 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-arm-kernel, Illia Ragozin, arm, Nicolas Pitre,
Jason Cooper, Andrew Lunn, Arnd Bergmann, Jason Gunthorpe,
Maxime Bizon, Russell King, linux-kernel
On Sat, Aug 08, 2015 at 09:11:39PM +0900, Masahiro Yamada wrote:
> The sequence of of_address_to_resource() and ioremap() can be
> replaced with of_iomap().
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Olof Johansson <olof@lixom.net>
Please submit this to Russell's patch tracker, he's usually the one who merges
patches to arch/arm/mm/*.
-Olof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-13 10:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-08 12:11 [PATCH] ARM: Feroceon: use of_iomap() to map register base Masahiro Yamada
2015-08-13 9:57 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).