* [PATCH] [SCSI] bfa: check if port is non NULL before dereferencing
@ 2015-08-17 12:03 Johannes Thumshirn
0 siblings, 0 replies; only message in thread
From: Johannes Thumshirn @ 2015-08-17 12:03 UTC (permalink / raw)
To: Anil Gurumurthy, Sudarsana Kalluru, James E.J. Bottomley
Cc: linux-scsi, linux-kernel, Johannes Thumshirn
In bfa_fcs_lport_get_rport_max_speed() check if port is non NULL before
dereferencing it's child port->fcs->bfa to trl_enabled.
NB: I'm not entirely sure if port can even be NULL, so the check for NULL might
be useless as well.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
drivers/scsi/bfa/bfa_fcs_lport.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c
index ff75ef8..096c2a2 100644
--- a/drivers/scsi/bfa/bfa_fcs_lport.c
+++ b/drivers/scsi/bfa/bfa_fcs_lport.c
@@ -5826,12 +5826,14 @@ bfa_fcs_lport_get_rport_max_speed(bfa_fcs_lport_t *port)
bfa_port_speed_t max_speed = 0;
struct bfa_port_attr_s port_attr;
bfa_port_speed_t port_speed, rport_speed;
- bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
+ bfa_boolean_t trl_enabled;
if (port == NULL)
return 0;
+ trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
+
fcs = port->fcs;
/* Get Physical port's current speed */
--
2.5.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-08-17 12:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-17 12:03 [PATCH] [SCSI] bfa: check if port is non NULL before dereferencing Johannes Thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).