[PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

[PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

[Chen-Yu Tsai]

of_clk_set_defaults uses the type 'bool', but clk-conf.h does not
include its definition.

This results in a compile error when only clk-conf.h is used.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Cc: stable@vger.kernel.org
---
 include/linux/clk/clk-conf.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/clk/clk-conf.h b/include/linux/clk/clk-conf.h
index f3050e15f833..e0c362363c38 100644
--- a/include/linux/clk/clk-conf.h
+++ b/include/linux/clk/clk-conf.h
@@ -7,6 +7,8 @@
  * published by the Free Software Foundation.
  */
 
+#include <linux/types.h>
+
 struct device_node;
 
 #if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK)
-- 
2.5.0

Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

[Stephen Boyd]

On 08/18, Chen-Yu Tsai wrote:
> of_clk_set_defaults uses the type 'bool', but clk-conf.h does not
> include its definition.
> 
> This results in a compile error when only clk-conf.h is used.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> Cc: stable@vger.kernel.org

Why is stable Cc-ed? Is there some sort of compilation failure on
stable kernels?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

[Chen-Yu Tsai]

On Tue, Aug 25, 2015 at 5:28 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 08/18, Chen-Yu Tsai wrote:
>> of_clk_set_defaults uses the type 'bool', but clk-conf.h does not
>> include its definition.
>>
>> This results in a compile error when only clk-conf.h is used.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> Cc: stable@vger.kernel.org
>
> Why is stable Cc-ed? Is there some sort of compilation failure on
> stable kernels?

There isn't for now. Though I don't see why we shouldn't fix this for
stable kernels as well. It's possible other people or third-party
vendors working with stable/LTS kernels (Android?) may run into it.

I'm perfectly fine with not Cc-ing stable. It just seemed like the
right thing to do.


Regards
ChenYu

Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

[Michal Kubecek]

On Tue, Aug 25, 2015 at 10:55:28AM +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 25, 2015 at 5:28 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 08/18, Chen-Yu Tsai wrote:
> >> of_clk_set_defaults uses the type 'bool', but clk-conf.h does not
> >> include its definition.
> >>
> >> This results in a compile error when only clk-conf.h is used.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> Cc: stable@vger.kernel.org
> >
> > Why is stable Cc-ed? Is there some sort of compilation failure on
> > stable kernels?
> 
> There isn't for now. Though I don't see why we shouldn't fix this for
> stable kernels as well. It's possible other people or third-party
> vendors working with stable/LTS kernels (Android?) may run into it.

How about 

   - It must fix a real bug that bothers people (not a, "This could be a
   problem..." type thing).

in Documentation/stable_kernel_rules.txt?

Michal Kubecek

Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

[Chen-Yu Tsai]

On Tue, Aug 25, 2015 at 2:59 PM, Michal Kubecek <mkubecek@suse.cz> wrote:
> On Tue, Aug 25, 2015 at 10:55:28AM +0800, Chen-Yu Tsai wrote:
>> On Tue, Aug 25, 2015 at 5:28 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> > On 08/18, Chen-Yu Tsai wrote:
>> >> of_clk_set_defaults uses the type 'bool', but clk-conf.h does not
>> >> include its definition.
>> >>
>> >> This results in a compile error when only clk-conf.h is used.
>> >>
>> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> >> Cc: stable@vger.kernel.org
>> >
>> > Why is stable Cc-ed? Is there some sort of compilation failure on
>> > stable kernels?
>>
>> There isn't for now. Though I don't see why we shouldn't fix this for
>> stable kernels as well. It's possible other people or third-party
>> vendors working with stable/LTS kernels (Android?) may run into it.
>
> How about
>
>    - It must fix a real bug that bothers people (not a, "This could be a
>    problem..." type thing).
>
> in Documentation/stable_kernel_rules.txt?

My bad. I'll send a new version without the CC.

ChenYu

Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

[Stephen Boyd]

On 08/25, Chen-Yu Tsai wrote:
> On Tue, Aug 25, 2015 at 2:59 PM, Michal Kubecek <mkubecek@suse.cz> wrote:
> >
> > How about
> >
> >    - It must fix a real bug that bothers people (not a, "This could be a
> >    problem..." type thing).
> >
> > in Documentation/stable_kernel_rules.txt?
> 
> My bad. I'll send a new version without the CC.

No need. I'll strip off the cc when applying.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project