linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] mfd: bcm590xx: Remove unnecessary MODULE_ALIAS()
@ 2015-08-30 22:58 Javier Martinez Canillas
  2015-08-30 22:58 ` [PATCH 2/2] mfd: rt5033: " Javier Martinez Canillas
  2015-09-20  4:19 ` [PATCH 1/2] mfd: bcm590xx: " Lee Jones
  0 siblings, 2 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-08-30 22:58 UTC (permalink / raw)
  To: linux-kernel; +Cc: Javier Martinez Canillas, Lee Jones, Samuel Ortiz

The driver has a I2C device id table that is used to create the module
aliases and also "bcm590xx" isn't a supported I2C id, so it's never used.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/mfd/bcm590xx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index da2af5b4f855..320aaefee718 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers/mfd/bcm590xx.c
@@ -128,4 +128,3 @@ module_i2c_driver(bcm590xx_i2c_driver);
 MODULE_AUTHOR("Matt Porter <mporter@linaro.org>");
 MODULE_DESCRIPTION("BCM590xx multi-function driver");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("i2c:bcm590xx");
-- 
2.4.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] mfd: rt5033: Remove unnecessary MODULE_ALIAS()
  2015-08-30 22:58 [PATCH 1/2] mfd: bcm590xx: Remove unnecessary MODULE_ALIAS() Javier Martinez Canillas
@ 2015-08-30 22:58 ` Javier Martinez Canillas
  2015-09-20  4:20   ` Lee Jones
  2015-09-20  4:19 ` [PATCH 1/2] mfd: bcm590xx: " Lee Jones
  1 sibling, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-08-30 22:58 UTC (permalink / raw)
  To: linux-kernel; +Cc: Javier Martinez Canillas, Lee Jones, Samuel Ortiz

The driver has a I2C device id table that is used to create the module
aliases which already contains a "rt5033". So the alias is not needed.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/mfd/rt5033.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
index d60f91619c4a..110de2a583af 100644
--- a/drivers/mfd/rt5033.c
+++ b/drivers/mfd/rt5033.c
@@ -137,7 +137,6 @@ static struct i2c_driver rt5033_driver = {
 };
 module_i2c_driver(rt5033_driver);
 
-MODULE_ALIAS("i2c:rt5033");
 MODULE_DESCRIPTION("Richtek RT5033 multi-function core driver");
 MODULE_AUTHOR("Beomho Seo <beomho.seo@samsung.com>");
 MODULE_LICENSE("GPL");
-- 
2.4.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] mfd: bcm590xx: Remove unnecessary MODULE_ALIAS()
  2015-08-30 22:58 [PATCH 1/2] mfd: bcm590xx: Remove unnecessary MODULE_ALIAS() Javier Martinez Canillas
  2015-08-30 22:58 ` [PATCH 2/2] mfd: rt5033: " Javier Martinez Canillas
@ 2015-09-20  4:19 ` Lee Jones
  1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2015-09-20  4:19 UTC (permalink / raw)
  To: Javier Martinez Canillas; +Cc: linux-kernel, Samuel Ortiz

On Mon, 31 Aug 2015, Javier Martinez Canillas wrote:

> The driver has a I2C device id table that is used to create the module
> aliases and also "bcm590xx" isn't a supported I2C id, so it's never used.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
>  drivers/mfd/bcm590xx.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
> index da2af5b4f855..320aaefee718 100644
> --- a/drivers/mfd/bcm590xx.c
> +++ b/drivers/mfd/bcm590xx.c
> @@ -128,4 +128,3 @@ module_i2c_driver(bcm590xx_i2c_driver);
>  MODULE_AUTHOR("Matt Porter <mporter@linaro.org>");
>  MODULE_DESCRIPTION("BCM590xx multi-function driver");
>  MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("i2c:bcm590xx");

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] mfd: rt5033: Remove unnecessary MODULE_ALIAS()
  2015-08-30 22:58 ` [PATCH 2/2] mfd: rt5033: " Javier Martinez Canillas
@ 2015-09-20  4:20   ` Lee Jones
  0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2015-09-20  4:20 UTC (permalink / raw)
  To: Javier Martinez Canillas; +Cc: linux-kernel, Samuel Ortiz

On Mon, 31 Aug 2015, Javier Martinez Canillas wrote:

> The driver has a I2C device id table that is used to create the module
> aliases which already contains a "rt5033". So the alias is not needed.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
>  drivers/mfd/rt5033.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
> index d60f91619c4a..110de2a583af 100644
> --- a/drivers/mfd/rt5033.c
> +++ b/drivers/mfd/rt5033.c
> @@ -137,7 +137,6 @@ static struct i2c_driver rt5033_driver = {
>  };
>  module_i2c_driver(rt5033_driver);
>  
> -MODULE_ALIAS("i2c:rt5033");
>  MODULE_DESCRIPTION("Richtek RT5033 multi-function core driver");
>  MODULE_AUTHOR("Beomho Seo <beomho.seo@samsung.com>");
>  MODULE_LICENSE("GPL");

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-20  4:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-30 22:58 [PATCH 1/2] mfd: bcm590xx: Remove unnecessary MODULE_ALIAS() Javier Martinez Canillas
2015-08-30 22:58 ` [PATCH 2/2] mfd: rt5033: " Javier Martinez Canillas
2015-09-20  4:20   ` Lee Jones
2015-09-20  4:19 ` [PATCH 1/2] mfd: bcm590xx: " Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).