From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
peter@korsgaard.com, festevam@gmail.com, kieranbingham@gmail.com
Cc: kernel@stlinux.com, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH v2 3/7] hwrng: core: Simplify RNG switching from sysfs
Date: Thu, 17 Sep 2015 14:45:53 +0100 [thread overview]
Message-ID: <1442497557-9271-4-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1442497557-9271-1-git-send-email-lee.jones@linaro.org>
If we attempt to use sysfs to change the current RNG in the usual
way i.e. issuing something like:
`echo 8a8a000.rng > /sys/devices/virtual/misc/hw_random/rng_current`
... it will fail because the code doesn't currently take the '\n'
into consideration. Well, now it does.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/char/hw_random/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index da8faf7..2d4a969 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -323,7 +323,7 @@ static ssize_t hwrng_attr_current_store(struct device *dev,
return -ERESTARTSYS;
err = -ENODEV;
list_for_each_entry(rng, &rng_list, list) {
- if (strcmp(rng->name, buf) == 0) {
+ if (sysfs_streq(rng->name, buf)) {
err = 0;
if (rng != current_rng)
err = set_current_rng(rng);
--
1.9.1
next prev parent reply other threads:[~2015-09-17 13:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 13:45 [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP Lee Jones
2015-09-17 13:45 ` [PATCH v2 1/7] Documentation: hw_random: Fix device node name reference /dev/hw_random => /dev/hwrng Lee Jones
2015-09-18 10:18 ` Kieran Bingham
2015-09-17 13:45 ` [PATCH v2 2/7] hwrng: Kconfig: " Lee Jones
2015-09-18 10:19 ` Kieran Bingham
2015-09-17 13:45 ` Lee Jones [this message]
2015-09-17 14:08 ` [PATCH v2 3/7] hwrng: core: Simplify RNG switching from sysfs Peter Korsgaard
2015-09-17 13:45 ` [PATCH v2 4/7] hwrng: st: Provide DT bindings for ST's Random Number Generator Lee Jones
2015-09-18 16:21 ` Stephen Boyd
2015-09-18 16:23 ` Lee Jones
2015-09-17 13:45 ` [PATCH v2 5/7] hwrng: st: Add support for ST's HW " Lee Jones
2015-09-18 10:44 ` Kieran Bingham
2015-10-05 10:44 ` Daniel Thompson
2015-10-05 12:11 ` Lee Jones
2015-10-05 12:54 ` Daniel Thompson
2015-10-05 14:52 ` Lee Jones
2015-09-17 13:45 ` [PATCH v2 6/7] ARM: STi: STiH407: Enable the 2 HW Random Number Generators for STiH4{07,10} Lee Jones
2015-10-01 10:57 ` [STLinux Kernel] [PATCH v2 6/7] ARM: STi: STiH407: Enable the 2 HW Random Number Generators for STiH4{07, 10} Maxime Coquelin
2015-09-17 13:45 ` [PATCH v2 7/7] MAINTAINERS: Add ST's Random Number Generator to the ST entry Lee Jones
2015-09-18 14:07 ` [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP Herbert Xu
2015-09-18 14:53 ` Lee Jones
2015-09-18 15:11 ` Herbert Xu
2015-09-18 15:51 ` Lee Jones
2015-09-18 23:12 ` Herbert Xu
2015-09-19 9:21 ` Lee Jones
2015-09-20 1:23 ` Herbert Xu
2015-09-20 4:39 ` Lee Jones
2015-09-29 14:29 ` Lee Jones
2015-09-30 13:47 ` Herbert Xu
2015-09-30 14:15 ` Lee Jones
2015-09-30 14:28 ` Herbert Xu
2015-09-30 14:49 ` [STLinux Kernel] " Maxime Coquelin
2015-09-30 14:50 ` Lee Jones
2015-09-29 9:20 ` [STLinux Kernel] " Peter Griffin
2015-09-29 10:42 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442497557-9271-4-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@stlinux.com \
--cc=kieranbingham@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).