From: Kieran Bingham <kieranbingham@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org, peter@korsgaard.com,
festevam@gmail.com, kernel@stlinux.com
Subject: Re: [PATCH v2 1/7] Documentation: hw_random: Fix device node name reference /dev/hw_random => /dev/hwrng
Date: Fri, 18 Sep 2015 11:18:51 +0100 [thread overview]
Message-ID: <CAB3z_RrhD9wx+P_BTd8ULPUDoFHLE5h=fPZDxZWTUoHpF2_w=g@mail.gmail.com> (raw)
In-Reply-To: <1442497557-9271-2-git-send-email-lee.jones@linaro.org>
On 17 September 2015 at 14:45, Lee Jones <lee.jones@linaro.org> wrote:
> In April 2009, commit d405640 ("Driver Core: misc: add node name support
> for misc devices.") inadvertently changed the device node name from
> /dev/hw_random to /dev/hwrng. Since 6 years has passed since the change
> it seems unpractical to change it back, as this node name is probably
> considered ABI by now. So instead, we'll just change the documentation
> to match the current situation.
>
> NB: It looks like rng-tools have already been updated.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
I see the KConfig change went into a separate patch.
That's fine by me:
Acked-by: Kieran Bingham <kieranbingham@gmail.com>
> ---
> Documentation/hw_random.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/hw_random.txt b/Documentation/hw_random.txt
> index 026e237..fce1634 100644
> --- a/Documentation/hw_random.txt
> +++ b/Documentation/hw_random.txt
> @@ -3,7 +3,7 @@ Introduction:
> The hw_random framework is software that makes use of a
> special hardware feature on your CPU or motherboard,
> a Random Number Generator (RNG). The software has two parts:
> - a core providing the /dev/hw_random character device and its
> + a core providing the /dev/hwrng character device and its
> sysfs support, plus a hardware-specific driver that plugs
> into that core.
>
> @@ -14,7 +14,7 @@ Introduction:
>
> http://sourceforge.net/projects/gkernel/
>
> - Those tools use /dev/hw_random to fill the kernel entropy pool,
> + Those tools use /dev/hwrng to fill the kernel entropy pool,
> which is used internally and exported by the /dev/urandom and
> /dev/random special files.
>
> @@ -32,13 +32,13 @@ Theory of operation:
> The rng-tools package uses such tests in "rngd", and lets you
> run them by hand with a "rngtest" utility.
>
> - /dev/hw_random is char device major 10, minor 183.
> + /dev/hwrng is char device major 10, minor 183.
>
> CLASS DEVICE. There is a /sys/class/misc/hw_random node with
> two unique attributes, "rng_available" and "rng_current". The
> "rng_available" attribute lists the hardware-specific drivers
> available, while "rng_current" lists the one which is currently
> - connected to /dev/hw_random. If your system has more than one
> + connected to /dev/hwrng. If your system has more than one
> RNG available, you may change the one used by writing a name from
> the list in "rng_available" into "rng_current".
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2015-09-18 10:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 13:45 [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP Lee Jones
2015-09-17 13:45 ` [PATCH v2 1/7] Documentation: hw_random: Fix device node name reference /dev/hw_random => /dev/hwrng Lee Jones
2015-09-18 10:18 ` Kieran Bingham [this message]
2015-09-17 13:45 ` [PATCH v2 2/7] hwrng: Kconfig: " Lee Jones
2015-09-18 10:19 ` Kieran Bingham
2015-09-17 13:45 ` [PATCH v2 3/7] hwrng: core: Simplify RNG switching from sysfs Lee Jones
2015-09-17 14:08 ` Peter Korsgaard
2015-09-17 13:45 ` [PATCH v2 4/7] hwrng: st: Provide DT bindings for ST's Random Number Generator Lee Jones
2015-09-18 16:21 ` Stephen Boyd
2015-09-18 16:23 ` Lee Jones
2015-09-17 13:45 ` [PATCH v2 5/7] hwrng: st: Add support for ST's HW " Lee Jones
2015-09-18 10:44 ` Kieran Bingham
2015-10-05 10:44 ` Daniel Thompson
2015-10-05 12:11 ` Lee Jones
2015-10-05 12:54 ` Daniel Thompson
2015-10-05 14:52 ` Lee Jones
2015-09-17 13:45 ` [PATCH v2 6/7] ARM: STi: STiH407: Enable the 2 HW Random Number Generators for STiH4{07,10} Lee Jones
2015-10-01 10:57 ` [STLinux Kernel] [PATCH v2 6/7] ARM: STi: STiH407: Enable the 2 HW Random Number Generators for STiH4{07, 10} Maxime Coquelin
2015-09-17 13:45 ` [PATCH v2 7/7] MAINTAINERS: Add ST's Random Number Generator to the ST entry Lee Jones
2015-09-18 14:07 ` [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP Herbert Xu
2015-09-18 14:53 ` Lee Jones
2015-09-18 15:11 ` Herbert Xu
2015-09-18 15:51 ` Lee Jones
2015-09-18 23:12 ` Herbert Xu
2015-09-19 9:21 ` Lee Jones
2015-09-20 1:23 ` Herbert Xu
2015-09-20 4:39 ` Lee Jones
2015-09-29 14:29 ` Lee Jones
2015-09-30 13:47 ` Herbert Xu
2015-09-30 14:15 ` Lee Jones
2015-09-30 14:28 ` Herbert Xu
2015-09-30 14:49 ` [STLinux Kernel] " Maxime Coquelin
2015-09-30 14:50 ` Lee Jones
2015-09-29 9:20 ` [STLinux Kernel] " Peter Griffin
2015-09-29 10:42 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB3z_RrhD9wx+P_BTd8ULPUDoFHLE5h=fPZDxZWTUoHpF2_w=g@mail.gmail.com' \
--to=kieranbingham@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).