* [PATCH] [media] c8sectpfe: Fix uninitialized variable in load_slim_core_fw()
@ 2015-09-18 22:33 Christian Engelmayer
0 siblings, 0 replies; only message in thread
From: Christian Engelmayer @ 2015-09-18 22:33 UTC (permalink / raw)
To: srinivas.kandagatla, maxime.coquelin, patrice.chotard
Cc: mchehab, linux-arm-kernel, kernel, linux-media, linux-kernel,
Christian Engelmayer
Variable err in function load_slim_core_fw() is used without initializer.
Make sure that the result is deterministic. Detected by Coverity CID
1324265.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
Compile tested only. Applies against linux-next.
---
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
index 486aef50d99b..cd146464a80c 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
@@ -1106,7 +1106,7 @@ static int load_slim_core_fw(const struct firmware *fw, void *context)
phdr = (Elf32_Phdr *)(fw->data + ehdr->e_phoff);
/* go through the available ELF segments */
- for (i = 0; i < ehdr->e_phnum && !err; i++, phdr++) {
+ for (i = 0, err = 0; i < ehdr->e_phnum && !err; i++, phdr++) {
/* Only consider LOAD segments */
if (phdr->p_type != PT_LOAD)
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-09-18 22:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-18 22:33 [PATCH] [media] c8sectpfe: Fix uninitialized variable in load_slim_core_fw() Christian Engelmayer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).