* RESEND: [PATCH v3 net-next] sky2: use random address if EEPROM is bad
@ 2015-09-28 16:51 Liviu Dudau
2015-09-29 22:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Liviu Dudau @ 2015-09-28 16:51 UTC (permalink / raw)
To: Stephen Hemminger, Mirko Lindner, Florian Fainelli, Ryan Harkin,
Sergei Shtylyov
Cc: netdev, lkml, David Miller
On some embedded systems the EEPROM does not contain a valid MAC address.
In that case it is better to fallback to a generated mac address and
let init scripts fix the value later.
Reported-by: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
[Changed handcoded setup to use eth_hw_addr_random() and to save new address into HW]
Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
---
drivers/net/ethernet/marvell/sky2.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index d9f4498..5606a04 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -4819,6 +4819,18 @@ static struct net_device *sky2_init_netdev(struct sky2_hw *hw, unsigned port,
memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port * 8,
ETH_ALEN);
+ /* if the address is invalid, use a random value */
+ if (!is_valid_ether_addr(dev->dev_addr)) {
+ struct sockaddr sa = { AF_UNSPEC };
+
+ netdev_warn(dev,
+ "Invalid MAC address, defaulting to random\n");
+ eth_hw_addr_random(dev);
+ memcpy(sa.sa_data, dev->dev_addr, ETH_ALEN);
+ if (sky2_set_mac_address(dev, &sa))
+ netdev_warn(dev, "Failed to set MAC address.\n");
+ }
+
return dev;
}
--
2.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: RESEND: [PATCH v3 net-next] sky2: use random address if EEPROM is bad
2015-09-28 16:51 RESEND: [PATCH v3 net-next] sky2: use random address if EEPROM is bad Liviu Dudau
@ 2015-09-29 22:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-09-29 22:00 UTC (permalink / raw)
To: Liviu.Dudau
Cc: stephen, mlindner, f.fainelli, ryan.harkin, sergei.shtylyov,
netdev, linux-kernel
From: Liviu Dudau <Liviu.Dudau@arm.com>
Date: Mon, 28 Sep 2015 17:51:51 +0100
> On some embedded systems the EEPROM does not contain a valid MAC address.
> In that case it is better to fallback to a generated mac address and
> let init scripts fix the value later.
>
> Reported-by: Liviu Dudau <Liviu.Dudau@arm.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> [Changed handcoded setup to use eth_hw_addr_random() and to save new address into HW]
> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-29 22:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-28 16:51 RESEND: [PATCH v3 net-next] sky2: use random address if EEPROM is bad Liviu Dudau
2015-09-29 22:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).