* [PATCH v2 0/2] Make oxili GDSC parent of oxili_cx GDSC
@ 2015-10-01 19:22 Stephen Boyd
2015-10-01 19:22 ` [PATCH v2 1/2] PM / Domains: Make pm_genpd_{add,remove}_subdomain() available to modules Stephen Boyd
2015-10-01 19:22 ` [PATCH v2 2/2] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC Stephen Boyd
0 siblings, 2 replies; 9+ messages in thread
From: Stephen Boyd @ 2015-10-01 19:22 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: linux-kernel, linux-clk, linux-pm, linux-arm-msm, Rob Clark,
Rajendra Nayak, Rafael J . Wysocki, Kevin Hilman, Ulf Hansson
I'd like to take these patches through clk tree for v4.4, so PM
maintainers please ack patch 1.
Changes from v1:
* New patch to export symbols
* Remove subdomain on driver remove
Cc: Rob Clark <robdclark@gmail.com>
Cc: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Kevin Hilman <khilman@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Stephen Boyd (2):
PM / Domains: Make pm_genpd_{add,remove}_subdomain() available to
modules
clk: qcom: Make oxili GDSC parent of oxili_cx GDSC
drivers/base/power/domain.c | 2 ++
drivers/clk/qcom/mmcc-msm8974.c | 11 ++++++++++-
2 files changed, 12 insertions(+), 1 deletion(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/2] PM / Domains: Make pm_genpd_{add,remove}_subdomain() available to modules
2015-10-01 19:22 [PATCH v2 0/2] Make oxili GDSC parent of oxili_cx GDSC Stephen Boyd
@ 2015-10-01 19:22 ` Stephen Boyd
2015-10-05 20:55 ` Rafael J. Wysocki
2015-10-01 19:22 ` [PATCH v2 2/2] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC Stephen Boyd
1 sibling, 1 reply; 9+ messages in thread
From: Stephen Boyd @ 2015-10-01 19:22 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: linux-kernel, linux-clk, linux-pm, linux-arm-msm, Rob Clark,
Rajendra Nayak, Rafael J . Wysocki, Kevin Hilman, Ulf Hansson
Export these symbols so they can be used in loadable kernel
modules.
Cc: Rob Clark <robdclark@gmail.com>
Cc: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Kevin Hilman <khilman@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/base/power/domain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index cf4950d92937..9b0f5a06a82b 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1348,6 +1348,7 @@ int pm_genpd_add_subdomain(struct generic_pm_domain *genpd,
return ret;
}
+EXPORT_SYMBOL_GPL(pm_genpd_add_subdomain);
/**
* pm_genpd_remove_subdomain - Remove a subdomain from an I/O PM domain.
@@ -1395,6 +1396,7 @@ out:
return ret;
}
+EXPORT_SYMBOL_GPL(pm_genpd_remove_subdomain);
/* Default device callbacks for generic PM domains. */
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC
2015-10-01 19:22 [PATCH v2 0/2] Make oxili GDSC parent of oxili_cx GDSC Stephen Boyd
2015-10-01 19:22 ` [PATCH v2 1/2] PM / Domains: Make pm_genpd_{add,remove}_subdomain() available to modules Stephen Boyd
@ 2015-10-01 19:22 ` Stephen Boyd
2015-10-06 19:32 ` Stephen Boyd
1 sibling, 1 reply; 9+ messages in thread
From: Stephen Boyd @ 2015-10-01 19:22 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: linux-kernel, linux-clk, Rob Clark, Rafael J . Wysocki,
Kevin Hilman, linux-pm, linux-arm-msm, Ulf Hansson,
Rajendra Nayak
The oxili_cx GDSC is inside the power domain of the oxili GDSC.
Add the dependency so that the CX domain can properly power up.
Reported-by: Rob Clark <robdclark@gmail.com>
Cc: Rajendra Nayak <rnayak@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/clk/qcom/mmcc-msm8974.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c
index fe8320dc41db..cf2a7c9c95e6 100644
--- a/drivers/clk/qcom/mmcc-msm8974.c
+++ b/drivers/clk/qcom/mmcc-msm8974.c
@@ -2615,6 +2615,7 @@ MODULE_DEVICE_TABLE(of, mmcc_msm8974_match_table);
static int mmcc_msm8974_probe(struct platform_device *pdev)
{
struct regmap *regmap;
+ int ret;
regmap = qcom_cc_map(pdev, &mmcc_msm8974_desc);
if (IS_ERR(regmap))
@@ -2623,11 +2624,19 @@ static int mmcc_msm8974_probe(struct platform_device *pdev)
clk_pll_configure_sr_hpm_lp(&mmpll1, regmap, &mmpll1_config, true);
clk_pll_configure_sr_hpm_lp(&mmpll3, regmap, &mmpll3_config, false);
- return qcom_cc_really_probe(pdev, &mmcc_msm8974_desc, regmap);
+ ret = qcom_cc_really_probe(pdev, &mmcc_msm8974_desc, regmap);
+ if (ret)
+ return ret;
+
+ ret = pm_genpd_add_subdomain(&oxili_gdsc.pd, &oxilicx_gdsc.pd);
+ if (ret)
+ qcom_cc_remove(pdev);
+ return ret;
}
static int mmcc_msm8974_remove(struct platform_device *pdev)
{
+ pm_genpd_remove_subdomain(&oxili_gdsc.pd, &oxilicx_gdsc.pd);
qcom_cc_remove(pdev);
return 0;
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] PM / Domains: Make pm_genpd_{add,remove}_subdomain() available to modules
2015-10-01 19:22 ` [PATCH v2 1/2] PM / Domains: Make pm_genpd_{add,remove}_subdomain() available to modules Stephen Boyd
@ 2015-10-05 20:55 ` Rafael J. Wysocki
2015-10-06 19:32 ` Stephen Boyd
0 siblings, 1 reply; 9+ messages in thread
From: Rafael J. Wysocki @ 2015-10-05 20:55 UTC (permalink / raw)
To: Stephen Boyd
Cc: Mike Turquette, linux-kernel, linux-clk, linux-pm, linux-arm-msm,
Rob Clark, Rajendra Nayak, Kevin Hilman, Ulf Hansson
On Thursday, October 01, 2015 12:22:53 PM Stephen Boyd wrote:
> Export these symbols so they can be used in loadable kernel
> modules.
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Rajendra Nayak <rnayak@codeaurora.org>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Kevin Hilman <khilman@kernel.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> drivers/base/power/domain.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index cf4950d92937..9b0f5a06a82b 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1348,6 +1348,7 @@ int pm_genpd_add_subdomain(struct generic_pm_domain *genpd,
>
> return ret;
> }
> +EXPORT_SYMBOL_GPL(pm_genpd_add_subdomain);
>
> /**
> * pm_genpd_remove_subdomain - Remove a subdomain from an I/O PM domain.
> @@ -1395,6 +1396,7 @@ out:
>
> return ret;
> }
> +EXPORT_SYMBOL_GPL(pm_genpd_remove_subdomain);
>
> /* Default device callbacks for generic PM domains. */
This is fine by me, please feel free to add my ACK to it.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] PM / Domains: Make pm_genpd_{add,remove}_subdomain() available to modules
2015-10-05 20:55 ` Rafael J. Wysocki
@ 2015-10-06 19:32 ` Stephen Boyd
0 siblings, 0 replies; 9+ messages in thread
From: Stephen Boyd @ 2015-10-06 19:32 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Mike Turquette, linux-kernel, linux-clk, linux-pm, linux-arm-msm,
Rob Clark, Rajendra Nayak, Kevin Hilman, Ulf Hansson
On 10/05, Rafael J. Wysocki wrote:
> On Thursday, October 01, 2015 12:22:53 PM Stephen Boyd wrote:
> >
> > /**
> > * pm_genpd_remove_subdomain - Remove a subdomain from an I/O PM domain.
> > @@ -1395,6 +1396,7 @@ out:
> >
> > return ret;
> > }
> > +EXPORT_SYMBOL_GPL(pm_genpd_remove_subdomain);
> >
> > /* Default device callbacks for generic PM domains. */
>
> This is fine by me, please feel free to add my ACK to it.
>
Thanks. Applied to clk-next.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC
2015-10-01 19:22 ` [PATCH v2 2/2] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC Stephen Boyd
@ 2015-10-06 19:32 ` Stephen Boyd
2015-11-13 4:19 ` Rajendra Nayak
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Boyd @ 2015-10-06 19:32 UTC (permalink / raw)
To: Mike Turquette
Cc: linux-kernel, linux-clk, Rob Clark, Rafael J . Wysocki,
Kevin Hilman, linux-pm, linux-arm-msm, Ulf Hansson,
Rajendra Nayak
On 10/01, Stephen Boyd wrote:
> The oxili_cx GDSC is inside the power domain of the oxili GDSC.
> Add the dependency so that the CX domain can properly power up.
>
> Reported-by: Rob Clark <robdclark@gmail.com>
> Cc: Rajendra Nayak <rnayak@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC
2015-10-06 19:32 ` Stephen Boyd
@ 2015-11-13 4:19 ` Rajendra Nayak
2015-11-13 6:14 ` Stephen Boyd
0 siblings, 1 reply; 9+ messages in thread
From: Rajendra Nayak @ 2015-11-13 4:19 UTC (permalink / raw)
To: Stephen Boyd, Mike Turquette
Cc: linux-kernel, linux-clk, Rob Clark, Rafael J . Wysocki,
Kevin Hilman, linux-pm, linux-arm-msm, Ulf Hansson
On 10/07/2015 01:02 AM, Stephen Boyd wrote:
> On 10/01, Stephen Boyd wrote:
>> The oxili_cx GDSC is inside the power domain of the oxili GDSC.
>> Add the dependency so that the CX domain can properly power up.
>>
>> Reported-by: Rob Clark <robdclark@gmail.com>
>> Cc: Rajendra Nayak <rnayak@codeaurora.org>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>
> Applied to clk-next
I don't see this in clk-next. Was this dropped for some reason?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC
2015-11-13 4:19 ` Rajendra Nayak
@ 2015-11-13 6:14 ` Stephen Boyd
2015-11-13 6:28 ` Rajendra Nayak
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Boyd @ 2015-11-13 6:14 UTC (permalink / raw)
To: Rajendra Nayak
Cc: Mike Turquette, linux-kernel, linux-clk, Rob Clark,
Rafael J . Wysocki, Kevin Hilman, linux-pm, linux-arm-msm,
Ulf Hansson
On 11/13, Rajendra Nayak wrote:
>
> On 10/07/2015 01:02 AM, Stephen Boyd wrote:
> > On 10/01, Stephen Boyd wrote:
> >> The oxili_cx GDSC is inside the power domain of the oxili GDSC.
> >> Add the dependency so that the CX domain can properly power up.
> >>
> >> Reported-by: Rob Clark <robdclark@gmail.com>
> >> Cc: Rajendra Nayak <rnayak@codeaurora.org>
> >> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> >> ---
> >
> > Applied to clk-next
>
> I don't see this in clk-next. Was this dropped for some reason?
>
Hm.. It's merged into Linus' tree now
b68f2c3b882202aba97a488c1fede0e99f7261e2
unless I missed something.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC
2015-11-13 6:14 ` Stephen Boyd
@ 2015-11-13 6:28 ` Rajendra Nayak
0 siblings, 0 replies; 9+ messages in thread
From: Rajendra Nayak @ 2015-11-13 6:28 UTC (permalink / raw)
To: Stephen Boyd
Cc: Mike Turquette, linux-kernel, linux-clk, Rob Clark,
Rafael J . Wysocki, Kevin Hilman, linux-pm, linux-arm-msm,
Ulf Hansson
On 11/13/2015 11:44 AM, Stephen Boyd wrote:
> On 11/13, Rajendra Nayak wrote:
>>
>> On 10/07/2015 01:02 AM, Stephen Boyd wrote:
>>> On 10/01, Stephen Boyd wrote:
>>>> The oxili_cx GDSC is inside the power domain of the oxili GDSC.
>>>> Add the dependency so that the CX domain can properly power up.
>>>>
>>>> Reported-by: Rob Clark <robdclark@gmail.com>
>>>> Cc: Rajendra Nayak <rnayak@codeaurora.org>
>>>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>>>> ---
>>>
>>> Applied to clk-next
>>
>> I don't see this in clk-next. Was this dropped for some reason?
>>
>
> Hm.. It's merged into Linus' tree now
>
> b68f2c3b882202aba97a488c1fede0e99f7261e2
>
> unless I missed something.
right, sorry, I seemed to be wrongly looking at the gcc driver instead
of mmcc.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-11-13 6:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-01 19:22 [PATCH v2 0/2] Make oxili GDSC parent of oxili_cx GDSC Stephen Boyd
2015-10-01 19:22 ` [PATCH v2 1/2] PM / Domains: Make pm_genpd_{add,remove}_subdomain() available to modules Stephen Boyd
2015-10-05 20:55 ` Rafael J. Wysocki
2015-10-06 19:32 ` Stephen Boyd
2015-10-01 19:22 ` [PATCH v2 2/2] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC Stephen Boyd
2015-10-06 19:32 ` Stephen Boyd
2015-11-13 4:19 ` Rajendra Nayak
2015-11-13 6:14 ` Stephen Boyd
2015-11-13 6:28 ` Rajendra Nayak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).