* [PATCH] storvsc: use small sg_tablesize on x86
@ 2015-09-08 10:06 Olaf Hering
2015-10-01 20:30 ` KY Srinivasan
0 siblings, 1 reply; 13+ messages in thread
From: Olaf Hering @ 2015-09-08 10:06 UTC (permalink / raw)
To: kys, haiyangz, JBottomley; +Cc: linux-kernel, linux-scsi, Olaf Hering
Reducing the sg_tablesize allows booting of 32bit kernels in VMs, after
commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set the
tablesize based on the information given by the host")
[ 5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 -> 0x20
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
drivers/scsi/storvsc_drv.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 40c43ae..36bf183 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1907,6 +1907,11 @@ static int storvsc_probe(struct hv_device *device,
* from the host.
*/
host->sg_tablesize = (stor_device->max_transfer_bytes >> PAGE_SHIFT);
+#if defined(CONFIG_X86_32)
+ dev_warn(&device->device, "adjusting sg_tablesize 0x%x -> 0x%x",
+ host->sg_tablesize, MAX_MULTIPAGE_BUFFER_COUNT);
+ host->sg_tablesize = MAX_MULTIPAGE_BUFFER_COUNT;
+#endif
/* Register the HBA and start the scsi bus scan */
ret = scsi_add_host(host, &device->device);
^ permalink raw reply related [flat|nested] 13+ messages in thread
* RE: [PATCH] storvsc: use small sg_tablesize on x86
2015-09-08 10:06 [PATCH] storvsc: use small sg_tablesize on x86 Olaf Hering
@ 2015-10-01 20:30 ` KY Srinivasan
2015-10-01 20:51 ` James Bottomley
0 siblings, 1 reply; 13+ messages in thread
From: KY Srinivasan @ 2015-10-01 20:30 UTC (permalink / raw)
To: Olaf Hering, Haiyang Zhang, JBottomley; +Cc: linux-kernel, linux-scsi
> -----Original Message-----
> From: Olaf Hering [mailto:olaf@aepfle.de]
> Sent: Tuesday, September 8, 2015 3:07 AM
> To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; JBottomley@odin.com
> Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; Olaf Hering
> <olaf@aepfle.de>
> Subject: [PATCH] storvsc: use small sg_tablesize on x86
>
> Reducing the sg_tablesize allows booting of 32bit kernels in VMs, after
> commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set the
> tablesize based on the information given by the host")
>
> [ 5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 -> 0x20
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
> drivers/scsi/storvsc_drv.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 40c43ae..36bf183 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1907,6 +1907,11 @@ static int storvsc_probe(struct hv_device *device,
> * from the host.
> */
> host->sg_tablesize = (stor_device->max_transfer_bytes >>
> PAGE_SHIFT);
> +#if defined(CONFIG_X86_32)
> + dev_warn(&device->device, "adjusting sg_tablesize 0x%x -> 0x%x",
> + host->sg_tablesize,
> MAX_MULTIPAGE_BUFFER_COUNT);
> + host->sg_tablesize = MAX_MULTIPAGE_BUFFER_COUNT;
> +#endif
>
> /* Register the HBA and start the scsi bus scan */
> ret = scsi_add_host(host, &device->device);
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] storvsc: use small sg_tablesize on x86
2015-10-01 20:30 ` KY Srinivasan
@ 2015-10-01 20:51 ` James Bottomley
2015-10-01 21:27 ` KY Srinivasan
2015-10-02 17:14 ` Olaf Hering
0 siblings, 2 replies; 13+ messages in thread
From: James Bottomley @ 2015-10-01 20:51 UTC (permalink / raw)
To: KY Srinivasan; +Cc: Olaf Hering, Haiyang Zhang, linux-kernel, linux-scsi
On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:
>
> > -----Original Message-----
> > From: Olaf Hering [mailto:olaf@aepfle.de]
> > Sent: Tuesday, September 8, 2015 3:07 AM
> > To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; JBottomley@odin.com
> > Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; Olaf Hering
> > <olaf@aepfle.de>
> > Subject: [PATCH] storvsc: use small sg_tablesize on x86
> >
> > Reducing the sg_tablesize allows booting of 32bit kernels in VMs, after
> > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set the
> > tablesize based on the information given by the host")
> >
> > [ 5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 -> 0x20
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> > drivers/scsi/storvsc_drv.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> > index 40c43ae..36bf183 100644
> > --- a/drivers/scsi/storvsc_drv.c
> > +++ b/drivers/scsi/storvsc_drv.c
> > @@ -1907,6 +1907,11 @@ static int storvsc_probe(struct hv_device *device,
> > * from the host.
> > */
> > host->sg_tablesize = (stor_device->max_transfer_bytes >>
> > PAGE_SHIFT);
> > +#if defined(CONFIG_X86_32)
> > + dev_warn(&device->device, "adjusting sg_tablesize 0x%x -> 0x%x",
> > + host->sg_tablesize,
> > MAX_MULTIPAGE_BUFFER_COUNT);
> > + host->sg_tablesize = MAX_MULTIPAGE_BUFFER_COUNT;
> > +#endif
Um, this is a bit architecture specific (I know Azure is x86, but
still). Can you make the define check CONFIG_32BIT rather than
CONFIG_X86_32?
James
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] storvsc: use small sg_tablesize on x86
2015-10-01 20:51 ` James Bottomley
@ 2015-10-01 21:27 ` KY Srinivasan
2015-10-02 17:14 ` Olaf Hering
1 sibling, 0 replies; 13+ messages in thread
From: KY Srinivasan @ 2015-10-01 21:27 UTC (permalink / raw)
To: James Bottomley; +Cc: Olaf Hering, Haiyang Zhang, linux-kernel, linux-scsi
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2364 bytes --]
> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com]
> Sent: Thursday, October 1, 2015 1:52 PM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: Olaf Hering <olaf@aepfle.de>; Haiyang Zhang
> <haiyangz@microsoft.com>; linux-kernel@vger.kernel.org; linux-
> scsi@vger.kernel.org
> Subject: Re: [PATCH] storvsc: use small sg_tablesize on x86
>
> On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:
> >
> > > -----Original Message-----
> > > From: Olaf Hering [mailto:olaf@aepfle.de]
> > > Sent: Tuesday, September 8, 2015 3:07 AM
> > > To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > > <haiyangz@microsoft.com>; JBottomley@odin.com
> > > Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; Olaf Hering
> > > <olaf@aepfle.de>
> > > Subject: [PATCH] storvsc: use small sg_tablesize on x86
> > >
> > > Reducing the sg_tablesize allows booting of 32bit kernels in VMs, after
> > > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set
> the
> > > tablesize based on the information given by the host")
> > >
> > > [ 5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 -> 0x20
> > >
> > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> > > ---
> > > drivers/scsi/storvsc_drv.c | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> > > index 40c43ae..36bf183 100644
> > > --- a/drivers/scsi/storvsc_drv.c
> > > +++ b/drivers/scsi/storvsc_drv.c
> > > @@ -1907,6 +1907,11 @@ static int storvsc_probe(struct hv_device
> *device,
> > > * from the host.
> > > */
> > > host->sg_tablesize = (stor_device->max_transfer_bytes >>
> > > PAGE_SHIFT);
> > > +#if defined(CONFIG_X86_32)
> > > + dev_warn(&device->device, "adjusting sg_tablesize 0x%x -> 0x%x",
> > > + host->sg_tablesize,
> > > MAX_MULTIPAGE_BUFFER_COUNT);
> > > + host->sg_tablesize = MAX_MULTIPAGE_BUFFER_COUNT;
> > > +#endif
>
> Um, this is a bit architecture specific (I know Azure is x86, but
> still). Can you make the define check CONFIG_32BIT rather than
> CONFIG_X86_32?
Thanks, will do.
K. Y
>
> James
>
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] storvsc: use small sg_tablesize on x86
2015-10-01 20:51 ` James Bottomley
2015-10-01 21:27 ` KY Srinivasan
@ 2015-10-02 17:14 ` Olaf Hering
2016-01-25 8:35 ` Olaf Hering
1 sibling, 1 reply; 13+ messages in thread
From: Olaf Hering @ 2015-10-02 17:14 UTC (permalink / raw)
To: James Bottomley; +Cc: KY Srinivasan, Haiyang Zhang, linux-kernel, linux-scsi
On Thu, Oct 01, James Bottomley wrote:
> On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:
> > > +#if defined(CONFIG_X86_32)
> Um, this is a bit architecture specific (I know Azure is x86, but
> still). Can you make the define check CONFIG_32BIT rather than
> CONFIG_X86_32?
According to arch/x86/Kconfig there is no such thing.
Olaf
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] storvsc: use small sg_tablesize on x86
2015-10-02 17:14 ` Olaf Hering
@ 2016-01-25 8:35 ` Olaf Hering
2016-01-27 23:09 ` KY Srinivasan
0 siblings, 1 reply; 13+ messages in thread
From: Olaf Hering @ 2016-01-25 8:35 UTC (permalink / raw)
To: James Bottomley; +Cc: KY Srinivasan, Haiyang Zhang, linux-kernel, linux-scsi
On Fri, Oct 02, Olaf Hering wrote:
> On Thu, Oct 01, James Bottomley wrote:
>
> > On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:
>
> > > > +#if defined(CONFIG_X86_32)
>
> > Um, this is a bit architecture specific (I know Azure is x86, but
> > still). Can you make the define check CONFIG_32BIT rather than
> > CONFIG_X86_32?
>
> According to arch/x86/Kconfig there is no such thing.
What is the status of this change? Looks like there is nothing more to
do on my side.
Olaf
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] storvsc: use small sg_tablesize on x86
2016-01-25 8:35 ` Olaf Hering
@ 2016-01-27 23:09 ` KY Srinivasan
2016-01-28 6:00 ` James Bottomley
0 siblings, 1 reply; 13+ messages in thread
From: KY Srinivasan @ 2016-01-27 23:09 UTC (permalink / raw)
To: Olaf Hering, James Bottomley; +Cc: Haiyang Zhang, linux-kernel, linux-scsi
> -----Original Message-----
> From: Olaf Hering [mailto:olaf@aepfle.de]
> Sent: Monday, January 25, 2016 12:35 AM
> To: James Bottomley <James.Bottomley@HansenPartnership.com>
> Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; linux-kernel@vger.kernel.org; linux-
> scsi@vger.kernel.org
> Subject: Re: [PATCH] storvsc: use small sg_tablesize on x86
>
> On Fri, Oct 02, Olaf Hering wrote:
>
> > On Thu, Oct 01, James Bottomley wrote:
> >
> > > On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:
> >
> > > > > +#if defined(CONFIG_X86_32)
> >
> > > Um, this is a bit architecture specific (I know Azure is x86, but
> > > still). Can you make the define check CONFIG_32BIT rather than
> > > CONFIG_X86_32?
> >
> > According to arch/x86/Kconfig there is no such thing.
>
> What is the status of this change? Looks like there is nothing more to
> do on my side.
Olaf,
We do have the config option: CONFIG_X86_64. Perhaps we could use this.
Could you resubmit the patch with this change.
Regards,
K. Y
>
> Olaf
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] storvsc: use small sg_tablesize on x86
2016-01-27 23:09 ` KY Srinivasan
@ 2016-01-28 6:00 ` James Bottomley
2016-01-28 6:48 ` Olaf Hering
0 siblings, 1 reply; 13+ messages in thread
From: James Bottomley @ 2016-01-28 6:00 UTC (permalink / raw)
To: KY Srinivasan, Olaf Hering; +Cc: Haiyang Zhang, linux-kernel, linux-scsi
On Wed, 2016-01-27 at 23:09 +0000, KY Srinivasan wrote:
>
> > -----Original Message-----
> > From: Olaf Hering [mailto:olaf@aepfle.de]
> > Sent: Monday, January 25, 2016 12:35 AM
> > To: James Bottomley <James.Bottomley@HansenPartnership.com>
> > Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; linux-kernel@vger.kernel.org; linux-
> > scsi@vger.kernel.org
> > Subject: Re: [PATCH] storvsc: use small sg_tablesize on x86
> >
> > On Fri, Oct 02, Olaf Hering wrote:
> >
> > > On Thu, Oct 01, James Bottomley wrote:
> > >
> > > > On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:
> > >
> > > > > > +#if defined(CONFIG_X86_32)
> > >
> > > > Um, this is a bit architecture specific (I know Azure is x86,
> > > > but
> > > > still). Can you make the define check CONFIG_32BIT rather than
> > > > CONFIG_X86_32?
> > >
> > > According to arch/x86/Kconfig there is no such thing.
> >
> > What is the status of this change? Looks like there is nothing more
> > to do on my side.
>
> Olaf,
>
> We do have the config option: CONFIG_X86_64. Perhaps we could use
> this. Could you resubmit the patch with this change.
It's not really architecture independent, is it? Just use the bit
width config.
James
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] storvsc: use small sg_tablesize on x86
2016-01-28 6:00 ` James Bottomley
@ 2016-01-28 6:48 ` Olaf Hering
2016-01-28 15:37 ` James Bottomley
0 siblings, 1 reply; 13+ messages in thread
From: Olaf Hering @ 2016-01-28 6:48 UTC (permalink / raw)
To: James Bottomley; +Cc: KY Srinivasan, Haiyang Zhang, linux-kernel, linux-scsi
On Wed, Jan 27, James Bottomley wrote:
> It's not really architecture independent, is it? Just use the bit
> width config.
Again: which one? This driver is not for mips|powerpc|score|sh.
Olaf
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] storvsc: use small sg_tablesize on x86
2016-01-28 6:48 ` Olaf Hering
@ 2016-01-28 15:37 ` James Bottomley
2016-02-26 22:11 ` KY Srinivasan
0 siblings, 1 reply; 13+ messages in thread
From: James Bottomley @ 2016-01-28 15:37 UTC (permalink / raw)
To: Olaf Hering; +Cc: KY Srinivasan, Haiyang Zhang, linux-kernel, linux-scsi
On Thu, 2016-01-28 at 07:48 +0100, Olaf Hering wrote:
> On Wed, Jan 27, James Bottomley wrote:
>
> > It's not really architecture independent, is it? Just use the bit
> > width config.
>
> Again: which one? This driver is not for mips|powerpc|score|sh.
zgrep CONFIG_.*BIT /proc/config.gz
[...]
CONFIG_64BIT=y
James
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] storvsc: use small sg_tablesize on x86
2016-01-28 15:37 ` James Bottomley
@ 2016-02-26 22:11 ` KY Srinivasan
0 siblings, 0 replies; 13+ messages in thread
From: KY Srinivasan @ 2016-02-26 22:11 UTC (permalink / raw)
To: James Bottomley, Olaf Hering; +Cc: Haiyang Zhang, linux-kernel, linux-scsi
> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com]
> Sent: Thursday, January 28, 2016 7:37 AM
> To: Olaf Hering <olaf@aepfle.de>
> Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; linux-kernel@vger.kernel.org; linux-
> scsi@vger.kernel.org
> Subject: Re: [PATCH] storvsc: use small sg_tablesize on x86
>
> On Thu, 2016-01-28 at 07:48 +0100, Olaf Hering wrote:
> > On Wed, Jan 27, James Bottomley wrote:
> >
> > > It's not really architecture independent, is it? Just use the bit
> > > width config.
> >
> > Again: which one? This driver is not for mips|powerpc|score|sh.
>
> zgrep CONFIG_.*BIT /proc/config.gz
> [...]
> CONFIG_64BIT=y
>
> James
Olaf,
Would you be resubmitting this patch?
Thanks,
K. Y
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] storvsc: use small sg_tablesize on x86
2016-05-16 20:26 Joseph Salisbury
@ 2016-05-17 13:07 ` Olaf Hering
0 siblings, 0 replies; 13+ messages in thread
From: Olaf Hering @ 2016-05-17 13:07 UTC (permalink / raw)
To: Joseph Salisbury
Cc: KY Srinivasan, James Bottomley, Haiyang Zhang, LKML, linux-scsi
On Mon, May 16, Joseph Salisbury wrote:
> > CONFIG_64BIT=y
> It doesn't appear this patch ever landed in Mainline. Olaf, do you have
> plans to submit this patch?
Yes, will do.
Olaf
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] storvsc: use small sg_tablesize on x86
@ 2016-05-16 20:26 Joseph Salisbury
2016-05-17 13:07 ` Olaf Hering
0 siblings, 1 reply; 13+ messages in thread
From: Joseph Salisbury @ 2016-05-16 20:26 UTC (permalink / raw)
To: olaf; +Cc: KY Srinivasan, James Bottomley, Haiyang Zhang, LKML, linux-scsi
Replying to thread:
https://lkml.org/lkml/2016/2/26/1090
> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com]
> Sent: Thursday, January 28, 2016 7:37 AM
> To: Olaf Hering <olaf@aepfle.de>
> Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; linux-kernel@vger.kernel.org; linux-
> scsi@vger.kernel.org
> Subject: Re: [PATCH] storvsc: use small sg_tablesize on x86
>
> On Thu, 2016-01-28 at 07:48 +0100, Olaf Hering wrote:
> > On Wed, Jan 27, James Bottomley wrote:
> >
> > > It's not really architecture independent, is it? Just use the bit
> > > width config.
> >
> > Again: which one? This driver is not for mips|powerpc|score|sh.
>
> zgrep CONFIG_.*BIT /proc/config.gz
> [...]
> CONFIG_64BIT=y
>
> James
Olaf,
Would you be resubmitting this patch?
Thanks,
K. Y
Hello,
It doesn't appear this patch ever landed in Mainline. Olaf, do you have
plans to submit this patch?
Thanks,
Joe
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-05-17 13:07 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-08 10:06 [PATCH] storvsc: use small sg_tablesize on x86 Olaf Hering
2015-10-01 20:30 ` KY Srinivasan
2015-10-01 20:51 ` James Bottomley
2015-10-01 21:27 ` KY Srinivasan
2015-10-02 17:14 ` Olaf Hering
2016-01-25 8:35 ` Olaf Hering
2016-01-27 23:09 ` KY Srinivasan
2016-01-28 6:00 ` James Bottomley
2016-01-28 6:48 ` Olaf Hering
2016-01-28 15:37 ` James Bottomley
2016-02-26 22:11 ` KY Srinivasan
2016-05-16 20:26 Joseph Salisbury
2016-05-17 13:07 ` Olaf Hering
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).